Bug 677623 - hw/dmx/dmxgc.c:dmxChangeClip(): size of clientClipType
Summary: hw/dmx/dmxgc.c:dmxChangeClip(): size of clientClipType
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: xorg-x11-server
Version: rawhide
Hardware: All
OS: All
unspecified
unspecified
Target Milestone: ---
Assignee: Kevin E. Martin
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-02-15 11:45 UTC by Sami Farin
Modified: 2011-02-15 15:27 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-02-15 15:27:35 UTC
Type: ---


Attachments (Terms of Use)

Description Sami Farin 2011-02-15 11:45:33 UTC
Description of problem:
you are overconfident about the size of those two bits ;)

    unsigned int        clientClipType : 2; /* CT_<kind> */
    switch (pGC->clientClipType) {
    case CT_UNSORTED:
#define CT_UNSORTED             6

Version-Release number of selected component (if applicable):
1.9.99.1-4

How reproducible:
100%

Steps to Reproduce:
1. .
2.
3.
  
Actual results:
6 is bigger than 3

Expected results:
who knows?  I didn't code it

Additional info:
.

Comment 1 Kevin E. Martin 2011-02-15 15:27:35 UTC
Read the comment further down in the dmxgc.c code...

    case CT_PIXMAP:
    case CT_UNSORTED:
    case CT_YSORTED:
    case CT_YXSORTED:
    case CT_YXBANDED:
        /* These clip types are condensed down to either NONE or REGION
           in the mi code */

The other types are converted to CT_NONE or CT_REGION in the miregion.c code (via the call to pGC->funcs->ChangeClip), so the only types that are actually ever assigned to pGC->clientClipType are CT_NONE and CT_REGION and the other cases in this switch are just there to acknowledge that fact, but can never actually occur.


Note You need to log in before you can comment on or make changes to this bug.