Bug 677676 - Don't autostart print-applet in gnome for f15
Summary: Don't autostart print-applet in gnome for f15
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: system-config-printer
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Tim Waugh
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-02-15 14:48 UTC by Matthias Clasen
Modified: 2011-03-03 02:54 UTC (History)
3 users (show)

Fixed In Version: system-config-printer-1.3.1-1.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-03-03 02:54:05 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Matthias Clasen 2011-02-15 14:48:37 UTC
gnome 3 brings its own print notifications. Please change the NotShowIn line in 
/etc/xdg/autostart/print-applet.desktop to

NotShowIn=GNOME;KDE;

for F15 and onwards.

Thanks

Comment 1 Tim Waugh 2011-02-15 15:27:51 UTC
Matthias, will this break automatic print driver installation, or does GNOME 3 already handle this?

https://fedoraproject.org/wiki/Features/AutomaticPrintDriverInstallation

Comment 2 Tim Waugh 2011-02-15 15:38:30 UTC
Note that system-config-printer-applet also provides the interface that displays notifications about printers being connected, i.e. this stuff:

http://cyberelk.net/tim/2007/05/24/new-printer-notification-mock-ups/

Can GNOME 3 do that now?

Comment 3 Matthias Clasen 2011-02-15 17:21:26 UTC
The code looks like it gives you the notification, at least. 

http://git.gnome.org/browse/gnome-settings-daemon/tree/plugins/print-notifications/gsd-print-notifications-manager.c

Comment 4 Matthias Clasen 2011-02-15 17:25:15 UTC
CCing mkasik to get information about printer driver installation

Comment 5 Tim Waugh 2011-02-15 17:58:36 UTC
Oh. :-(  Thanks for the link to the code.  I have comments:

It's using a really old method of doing that stuff (com.redhat.PrinterSpooler, which should only be used for QueueChanged, not anything else), and looks to be *incredibly* inefficient:

num_jobs = cupsGetJobs (&jobs, printer_name, 1, CUPS_WHICHJOBS_ALL);

(that might take a minute or more, blocking not only gnome-settings-daemon but also cupsd for all that time -- every time it is run.)

Also it looks like it's showing notifications every time *any* print job changes, not just "mine"?

Not only that, but is it showing "Printer added" notifications every time a new printer is advertised on the network?

The way it ought to be done is using IPP subscriptions.  This is much more efficient.  Timeliness can be improved by using D-Bus, but a different interface should be used by preference: org.cups.cupsd.Notifier.

Additionally, only "my" jobs should trigger desktop notifications.  Otherwise I'll have notifications whenever anyone prints documents.

It looks like there is no notification of printer issues i.e. printer-state-reasons.  Hopefully that's planned?

No, there's no support there yet for automatic print driver installation AFAICS.

I'd like to help if I can...

Comment 6 Matthias Clasen 2011-02-15 19:00:13 UTC
Sure, any hints you have will be gladly received. I hope Marek is listening here now.

Comment 7 Marek Kašík 2011-02-16 09:27:06 UTC
Hi Tim,

thank you for your comments. I'm going to fix it right now.

Marek

Comment 8 Tim Waugh 2011-02-16 15:57:15 UTC
I've just built system-config-printer-1.3.0-2.fc15.  It still runs the applet, but only gets it to start the NewPrinterNotification and PrinterDriversInstaller D-Bus services.  Job notifications are not done.

Once gnome-settings-daemon handles the New Printer notifications (com.redhat.NewPrinterNotification) and PrinterDriversInstaller requests (com.redhat.PrinterDriversInstaller), we can kill the applet completely.

Comment 9 Fedora Update System 2011-02-16 15:59:25 UTC
system-config-printer-1.3.0-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/system-config-printer-1.3.0-2.fc15

Comment 10 Fedora Update System 2011-02-16 21:29:06 UTC
system-config-printer-1.3.0-2.fc15 has been pushed to the Fedora 15 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update system-config-printer'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/system-config-printer-1.3.0-2.fc15

Comment 11 Fedora Update System 2011-02-17 22:25:08 UTC
system-config-printer-1.3.1-1.fc15 has been pushed to the Fedora 15 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update system-config-printer'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/system-config-printer-1.3.1-1.fc15

Comment 12 Fedora Update System 2011-03-03 02:53:54 UTC
system-config-printer-1.3.1-1.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.