Bug 678071 - deleting provider accounts w/ instances , needs error message.
Summary: deleting provider accounts w/ instances , needs error message.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: CloudForms Cloud Engine
Classification: Retired
Component: aeolus-conductor
Version: 0.3.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
Assignee: Tomas Sedovic
QA Contact: wes hayutin
URL: http://10.16.120.137/deltacloud/admin...
Whiteboard:
Depends On:
Blocks: ce-beta
TreeView+ depends on / blocked
 
Reported: 2011-02-16 16:42 UTC by wes hayutin
Modified: 2012-01-26 12:27 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Embargoed:


Attachments (Terms of Use)

Description wes hayutin 2011-02-16 16:42:59 UTC
Description of problem:

recreate:
1. create a provider
2. create a provider account
3. try to delete the provider account..

Processing Admin::ProviderAccountsController#index (for 10.11.228.65 at 2011-02-16 11:42:22) [GET]
  Parameters: {"action"=>"index", "controller"=>"admin/provider_accounts"}
Rendering template within layouts/application
Rendering admin/provider_accounts/index
Completed in 687ms (View: 33, DB: 29) | 200 OK [http://10.16.120.137/deltacloud/admin/provider_accounts]


Processing Admin::ProviderAccountsController#multi_destroy (for 10.11.228.65 at 2011-02-16 11:42:25) [DELETE]
  Parameters: {"accounts_selected"=>["1"], "__rewrite"=>{"delete"=>"Delete"}, "action"=>"multi_destroy", "controller"=>"admin/provider_accounts", "__map"=>{"delete"=>{"method"=>"DELETE", "url"=>"/deltacloud/admin/provider_accounts/multi_destroy"}}}
Redirected to http://10.16.120.137/deltacloud/admin/provider_accounts
Completed in 572ms (DB: 44) | 302 Found [http://10.16.120.137/deltacloud/admin/provider_accounts/multi_destroy]


Processing Admin::ProviderAccountsController#index (for 10.11.228.65 at 2011-02-16 11:42:26) [GET]
  Parameters: {"action"=>"index", "controller"=>"admin/provider_accounts"}
Rendering template within layouts/application
Rendering admin/provider_accounts/index
Completed in 306ms (View: 24, DB: 25) | 200 OK [http://10.16.120.137/deltacloud/admin/provider_accounts]

Comment 1 wes hayutin 2011-02-16 17:28:10 UTC
Testing this more now..
This may just be due to running instances.. In which case the proper warning message should be issued.

Comment 2 Dave Johnson 2011-02-28 19:33:15 UTC
Even with stopped instances, you cannot delete the provider account and the user gets zero feedback.

Comment 3 wes hayutin 2011-03-11 16:58:41 UTC
adding to the ce-beta blocking tracker

Comment 4 wes hayutin 2011-03-14 15:24:27 UTC
this is a blocker for the automation

Comment 5 Tomas Sedovic 2011-03-15 09:46:26 UTC
Posted a fix to the aeolus-devel mailing list:

https://fedorahosted.org/pipermail/aeolus-devel/2011-March/000624.html

With the patch you should be able to delete the account if all its instances are stopped. And it displays an error message otherwise.

Comment 6 Tomas Sedovic 2011-03-30 11:31:14 UTC
The missing error message issue is fixed in the `next` branch.

However, the only way to delete a provider account is when there are no instances associated with it.

The reason is that some instances could be started again after they're stopped.

To resolve the confusion, 2 things should be done:

1) making it easier/possible to delete instances

2) distinguish between stopped instances that are truly dead (stateless) and those that can be started again (stateful). Then we can delete an account that has no restartable instances associated with it.

I think these should be made into separate issues, though.

Comment 7 Dave Johnson 2011-03-30 13:32:55 UTC
Just an FYI for #1 in comment 6, bug 683986 tracks the issue were selecting multiple instances only stops one.  

An idea for easier with the assumption of a fix for bug 683986, perhaps have the delete recognize running instances, ask for a acknowledgement like a checkbox, and do both actions for the user in one delete action.

Comment 8 Shveta 2011-04-07 10:18:50 UTC
Providers can be deleted now.

Comment 9 Shveta 2011-04-14 12:24:27 UTC
1) Create a provider.
2) Create a provider account.
3) Launch Instance.


With running instance : Account ssachdev was not deleted. There are instances associated with it.

With stopped instance also :Account ssachdev was not deleted. There are instances associated with it.

Provider account cannot be deleted.

Comment 10 wes hayutin 2011-06-14 15:39:36 UTC
moving to on_qa for review

Comment 11 Shveta 2011-07-04 13:53:31 UTC
Verified : 

1) with running instances , account cannot be deleted with this validation message .

Errors

    * Account ssachdev_west was not deleted. There are instances associated with it.



2) Without running instance , account can be deleted.

Comment 12 wes hayutin 2011-08-01 19:55:48 UTC
release pending...

Comment 13 wes hayutin 2011-08-01 19:57:27 UTC
release pending...

Comment 15 wes hayutin 2011-12-08 13:50:46 UTC
perm close

Comment 16 wes hayutin 2011-12-08 13:53:55 UTC
closing out old bugs


Note You need to log in before you can comment on or make changes to this bug.