Bug 678195 - Review Request: perl-MooseX-OneArgNew - Teach ->new to accept single, non-hashref arguments
Summary: Review Request: perl-MooseX-OneArgNew - Teach ->new to accept single, non-has...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/MooseX-On...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-02-17 04:30 UTC by Iain Arnell
Modified: 2011-05-25 02:40 UTC (History)
2 users (show)

Fixed In Version: perl-MooseX-OneArgNew-0.001-1.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-05-25 02:40:01 UTC
Type: ---
Embargoed:
mmaslano: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Iain Arnell 2011-02-17 04:30:45 UTC
Spec URL: http://fedorapeople.org/~iarnell/review/perl-MooseX-OneArgNew.spec
SRPM URL: http://fedorapeople.org/~iarnell/review/perl-MooseX-OneArgNew-0.001-1.fc16.src.rpm

Description:
MooseX::OneArgNew lets your constructor take a single argument, which will
be translated into the value for a one-entry hashref. It is a parameterized
role with two parameters:

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2845776

*rt-0.10_01

Comment 1 Marcela Mašláňová 2011-03-28 08:37:36 UTC
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source 87675d2bb98525d787e7509e6d581f50 OK
- package MUST successfully compile and build OK
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

http://koji.fedoraproject.org/koji/taskinfo?taskID=2953107
rpm -qp --provides ~/Downloads/perl-MooseX-OneArgNew-0.001-1.fc16.noarch.rpm 
perl(MooseX::OneArgNew) = 0.001
perl-MooseX-OneArgNew = 0.001-1.fc16
rpm -qp --requires ~/Downloads/perl-MooseX-OneArgNew-0.001-1.fc16.noarch.rpm 
perl(:MODULE_COMPAT_5.12.3)  
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
perl(Moose::Util::TypeConstraints)  
perl(MooseX::Role::Parameterized)  
perl(namespace::autoclean)  
rpmlib(PayloadIsXz) <= 5.2-1

ACCEPTED

Comment 2 Iain Arnell 2011-03-28 08:55:39 UTC
Thanks, Marcela.

New Package SCM Request
=======================
Package Name: perl-MooseX-OneArgNew
Short Description: Teach ->new to accept single, non-hashref arguments
Owners: iarnell
Branches: f13 f14 f15
InitialCC: perl-sig

Comment 3 Jason Tibbitts 2011-03-28 13:59:10 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2011-03-28 14:38:56 UTC
perl-MooseX-OneArgNew-0.001-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/perl-MooseX-OneArgNew-0.001-1.fc15

Comment 5 Fedora Update System 2011-04-02 05:56:51 UTC
perl-MooseX-OneArgNew-0.001-1.fc15 has been pushed to the Fedora 15 stable repository.

Comment 6 Fedora Update System 2011-05-11 03:55:45 UTC
perl-MooseX-OneArgNew-0.001-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-MooseX-OneArgNew-0.001-1.fc14

Comment 7 Fedora Update System 2011-05-13 23:14:53 UTC
perl-MooseX-OneArgNew-0.001-1.fc14 has been pushed to the Fedora 14 testing repository.

Comment 8 Fedora Update System 2011-05-25 02:39:55 UTC
perl-MooseX-OneArgNew-0.001-1.fc14 has been pushed to the Fedora 14 stable repository.


Note You need to log in before you can comment on or make changes to this bug.