Hide Forgot
Spec URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-gtksourceview2/rubygem-gtksourceview2.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-gtksourceview2/rubygem-gtksourceview2-0.90.7-2.fc.src.rpm Description: Ruby/GtkSourceView2 is a Ruby binding of gtksourceview-2.x. Koji scratch build For F-15: http://koji.fedoraproject.org/koji/taskinfo?taskID=2849725 For F-14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2849722
http://mtasaka.fedorapeople.org/Review_request/rubygem-gtksourceview2/rubygem-gtksourceview2-0.90.8-1.fc.src.rpm http://mtasaka.fedorapeople.org/Review_request/rubygem-gtksourceview2/rubygem-gtksourceview2.spec * Thu Mar 10 2011 Mamoru Tasaka <mtasaka> - 0.90.8-1 - 0.90.8
I am taking this review.
* gtk2 dependency - Upstream specifies gtk2 >= 0.90.8 runtime dependency while you allow dependency on 0.90.7. I just want to ensure that this is intentional, not by mistake. * rpmlint output: - rubygem-gtksourceview2.spec:116: W: mixed-use-of-spaces-and-tabs (spaces: line 116, tab: line 1) - rubygem-gtksourceview2.src: W: strange-permission gtksourceview2-0.90.8.gem 0600L Otherwise I have no objections. So this package is APPROVED.
Thank you. I will address your comments. New Package SCM Request ======================= Package Name: rubygem-gtksourceview2 Short Description: Ruby binding of gtksourceview-2.x Owners: mtasaka Branches: f15 f14
Git done (by process-git-requests).
Built, push request submitted. Thank you for the review and git procedure, closing.