Bug 678793 - [PATCH] add support for more Matrix-UPS revisions to apcsmart driver
Summary: [PATCH] add support for more Matrix-UPS revisions to apcsmart driver
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: nut
Version: rawhide
Hardware: All
OS: All
unspecified
low
Target Milestone: ---
Assignee: Michal Hlavinka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-02-19 18:44 UTC by Charles R. Anderson
Modified: 2011-09-04 18:12 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2011-09-04 18:12:06 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Add support for Matrix-UPS firmware 0XM/0XI with additional commands (648 bytes, patch)
2011-02-19 18:44 UTC, Charles R. Anderson
no flags Details | Diff

Description Charles R. Anderson 2011-02-19 18:44:26 UTC
Created attachment 479713 [details]
Add support for Matrix-UPS firmware 0XM/0XI with additional commands

Description of problem:
The attached patch adds support for Matrix-UPS revision strings 0XI and 0XM to the apcsmart driver.

The revision string itself isn't completely opaque--it is made up of different parts as documented on http://homepage1.nifty.com/Que/plamo/apc-ups/manual/upsbible.html under "Old Firmware Revision".  This implies that many more combinations of characters could be added to support more revisions & configurations.  Indeed, 0XI and 0XM only differ by the placement of the 208V/240V input voltage select wire.

The first character can be 0 or 5 for Matrix-UPS 3000 vs. Matrix-UPS 5000.  The second character is the actual firmware revision.  I've read in various forums about revisions U, W, X, Y, and Z.  There is probably a V as well.  The last character seems to be I for 240V and M for 208V, which I can change on mine by the placement of the input voltage select wire. 

I've also tested the expanded command list which enables nut to access more functionality on my Matrix-UPS 3000.  I suggest that this same expanded list could be applied to all the other firmware combinations as well.

Please consider adding at least this patch which is limited to 0XI/0XM initially.  Thanks.

Version-Release number of selected component (if applicable):
nut-2.6.0-1.fc14

Comment 1 Michal Hlavinka 2011-02-21 14:02:31 UTC
Thanks for reporting this. I can see you've already sent this patch to upstream mailing list which is the correct way how get patch applied in nut. I'll add this patch to our nut package once upstream accepts it.

Comment 2 Charles R. Anderson 2011-09-04 18:12:06 UTC
I see this has been added.  Closing.  Thanks.


Note You need to log in before you can comment on or make changes to this bug.