Bug 679180 - logging.properties not listed as a config file in the rpm
Summary: logging.properties not listed as a config file in the rpm
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: java-1.6.0-openjdk
Version: 5.8
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: rc
: ---
Assignee: jiri vanek
QA Contact: BaseOS QE - Apps
URL:
Whiteboard:
Depends On: 680144
Blocks: 924828
TreeView+ depends on / blocked
 
Reported: 2011-02-21 20:06 UTC by Jason Pyeron
Modified: 2013-04-23 05:49 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 924828 (view as bug list)
Environment:
Last Closed: 2013-03-22 14:52:55 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
patch for %files section (1.41 KB, patch)
2011-02-22 22:34 UTC, Jason Pyeron
no flags Details | Diff
console log showing gcc/g++ build requires issues (3.27 MB, text/plain)
2011-02-23 20:24 UTC, Jason Pyeron
no flags Details
patch for %files and build requires (1.54 KB, patch)
2011-02-23 20:35 UTC, Jason Pyeron
no flags Details | Diff
no build require update (1.20 KB, patch)
2011-02-24 13:10 UTC, Jason Pyeron
jvanek: review+
Details | Diff


Links
System ID Private Priority Status Summary Last Updated
PD Inc Project 1471 0 None None None Never

Description Jason Pyeron 2011-02-21 20:06:08 UTC
Description of problem:

modify the logging.properties, then update the package via normal yum process, not you chages will go away if there is a newer rpm package.

Version-Release number of selected component (if applicable):


How reproducible:

always

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:

logging.properties.rpmnew file created instead

Additional info:

working on a patch to the spec file

Comment 1 jiri vanek 2011-02-22 08:40:46 UTC
Then logging properties should be marked as config(noreplace)

%config(noreplace) jre/lib/logging.properties

Comment 2 Jason Pyeron 2011-02-22 22:34:30 UTC
Created attachment 480287 [details]
patch for %files section

also fixes a build requirement by adding BuildRequires: gcc-c++

Comment 3 jiri vanek 2011-02-23 07:59:42 UTC
Why have you added this? BuildRequires: gcc-c++
There is no need for it.

Comment 4 Jason Pyeron 2011-02-23 12:59:06 UTC
if you do not have it installed then the build will fail.

remove g++ and try to build.

Comment 5 jiri vanek 2011-02-23 13:31:21 UTC
 gcc-c++ is always added as dependence of dependence.

Comment 6 Jason Pyeron 2011-02-23 19:23:11 UTC
(In reply to comment #5)
>  gcc-c++ is always added as dependence of dependence.

Which dependency? I ask because, I must have managed to break something, if that was the case.

The build failed the first time with a g++ not found.

Comment 7 Jason Pyeron 2011-02-23 20:24:23 UTC
Created attachment 480566 [details]
console log showing gcc/g++ build requires issues

As you can see gcc is a dependency for g++ but g++ is not a dependency for any package needed by the build requires or rpm-build.

Comment 8 Jason Pyeron 2011-02-23 20:35:35 UTC
Created attachment 480572 [details]
patch for %files and build requires

Comment 9 jiri vanek 2011-02-24 10:20:54 UTC
I still must disagree. When build is done on clean system (mock) tehn all dependencies are available. For missing gcc/g++ There must be fault on your machine. 
Please run mock build, nd you will be sure. The dependece can't be add. 


I will apply
%config(noreplace) %{_jvmdir}/%{jredir}/lib/logging.properties
into spec file asap I recieve acks.

Comment 10 Jason Pyeron 2011-02-24 13:10:21 UTC
Created attachment 480752 [details]
no build require update

I am testing in mockbuild right now, if I can reproduce I will open another bug.

Comment 11 Jason Pyeron 2011-02-24 13:28:01 UTC
did you even do a mock build? it is complaining wildly.

Comment 12 Jason Pyeron 2011-02-24 13:30:06 UTC
I have opened bug 680144 for the build requires issues.

Comment 17 Jason Pyeron 2013-03-22 17:53:05 UTC
why? the patch was submitted over a year ago, and approved.

Comment 18 jiri vanek 2013-03-25 09:11:33 UTC
https://bugzilla.redhat.com/show_bug.cgi?id=924828

This is the clone for rhe 6.4. The  fix will bubble probably also to 5.X

Comment 19 jiri vanek 2013-03-25 17:12:59 UTC
Builds with fix of this were pushed to fedora.
if they will pass theirs usual QA, I'm for inclusion into next CPU for Rhel and for jdks 6
http://pkgs.fedoraproject.org/cgit/java-1.7.0-openjdk.git/commit/?id=89e2aea2f9880efd4ad773ef9dc566225c9ae9ef


Note You need to log in before you can comment on or make changes to this bug.