Bug 679185 - doesn't handle stderr well
Summary: doesn't handle stderr well
Keywords:
Status: CLOSED DUPLICATE of bug 682001
Alias: None
Product: Fedora
Classification: Fedora
Component: system-config-services
Version: 15
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nils Philippsen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-02-21 20:23 UTC by Bill Nottingham
Modified: 2014-03-17 03:26 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2011-04-27 11:12:43 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
PATCH: use re.search and re.MULTILINE (1.95 KB, patch)
2011-02-21 20:23 UTC, Bill Nottingham
no flags Details | Diff

Description Bill Nottingham 2011-02-21 20:23:32 UTC
Created attachment 479989 [details]
PATCH: use re.search and re.MULTILINE

Description of problem:

In chkconfig-1.3.50, we added some warnings to --list output, to note that it may not be accurate on a system where native systemd services occupy the same name.

This breaks s-c-services. While the attached fix won't necessarily fix it for any native systemd services, it does fix it to not choke when --list output also prints a warning to stderr.

Version-Release number of selected component (if applicable):

system-config-services-0.99.47-2.fc15.noarch

How reproducible:

100%

Steps to Reproduce:
1. upgrade chkconfig
2. run s-c-services
  
Actual results:

Hey, it thinks everything is disabled!

Expected results:

Not that.

Comment 1 Bill Nottingham 2011-04-26 21:50:34 UTC
Note: I would like to commit & push:

 http://git.fedorahosted.org/git/?p=chkconfig.git;a=commitdiff;h=55c0f3e082a3531974f83278fc2c1e0f85897ac1

This may or may not make this situation worse.

Comment 2 Nils Philippsen 2011-04-27 11:12:43 UTC
With the switch to systemd and all the changes that still need to be done in s-c-services, this bug completely went off the screen for me, but I've come up with something very similar to your patch (only in a few more places to be sure) in the upstream commit 22d090b9acf1df0f850b3172347ac64f6c72b94d.

I've looked at your chkconfig patch but didn't find anything obvious that should cause problems, so please go ahead and build. I'll close this one as duplicate to bug #682001 which covers the whole systemd adaptation thing.

*** This bug has been marked as a duplicate of bug 682001 ***


Note You need to log in before you can comment on or make changes to this bug.