Bug 679433 - [RFE] Add output of lsblk command to sos reports
Summary: [RFE] Add output of lsblk command to sos reports
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: sos
Version: 6.1
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Bryn M. Reeves
QA Contact: BaseOS QE - Apps
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-02-22 15:13 UTC by David Kutálek
Modified: 2012-04-23 13:01 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
The lsblk utility shows the tree structure of all block devices in the system. With this update, sos captures the output of the lsblk utility and includes it in sos reports.
Clone Of:
Environment:
Last Closed: 2011-05-19 14:27:54 UTC
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2011:0773 0 normal SHIPPED_LIVE sos bug fix and enhancement update 2011-05-18 18:08:30 UTC

Description David Kutálek 2011-02-22 15:13:34 UTC
Description of problem:

lsblk command was introduced in RHEL6.1 to show tree structure of device mapper devices. It is very useful in situations with complicated storage setup, like when using RAID, dm-crypt, etc.

Version-Release number of selected component (if applicable):

sos-2.2-3.el6

How reproducible:

output of lsblk is not present in sos report with devicemapper plugin enabled

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Will attach a patch later today.

Comment 1 Karel Zak 2011-02-22 16:23:07 UTC
(In reply to comment #0)
> lsblk command was introduced in RHEL6.1 to show tree structure of device 
> mapper devices. It is very useful in situations with complicated storage 
> setup, like when using RAID, dm-crypt, etc.

It's not restricted to device-mapper devices. It lists all block devices.

> Will attach a patch later today.

Cool, I think that a simple 'lsblk' call without options is enough.

Comment 2 Bryn M. Reeves 2011-02-22 16:39:19 UTC
Yeah, I don't think that this goes into the device-mapper plugin (it's not device-mapper..) but I do think that we should include it.

We also have a request (that I was planning to accept) to include dmsetup ls --tree output in sos:

  bug 674354 [ rawhide ]
  bug 675559 [ RHEL6 ]

Technically lsblk is a superset of the data provided by dmsetup ls --tree but unless someone has a strong argument against it I think my inclination is to include both of them for now.

Comment 3 David Kutálek 2011-02-22 20:37:43 UTC
Yes I agree integrating both is ok.

Wanted to do patch against devicemapper plugin, but since it is general thing, it should go elsewhere. Bryn what plugin would you use: general? system? This will be one liner, so feel free to add it to correct place :-).

Comment 4 Bryn M. Reeves 2011-02-25 12:35:42 UTC
It's not obvious really.. if we had a "devices" or "block" plugin then I think that would be the best place for it.

One of the problems we have in sos at the moment is that there is no clear orgnisation of the plugins so we have a level of duplication and uncertainty about where to add new features.

This is something that we want to address upstream in future releases but for now I'm inclined to put it in the filesys.py plugin - there's already several block device related commands in there (blkid, hdparm, etc.) and there's already a load of cleanup needed in the devicemapper plugin.

Comment 7 Tomas Capek 2011-05-18 14:45:33 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
The lsblk utility shows the tree structure of all block devices in the system. With this update, sos captures the output of the lsblk utility and includes it in sos reports.

Comment 8 errata-xmlrpc 2011-05-19 14:27:54 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0773.html


Note You need to log in before you can comment on or make changes to this bug.