Bug 679461 - Package upload does not check if the package is already associated with the repo
Summary: Package upload does not check if the package is already associated with the repo
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Pulp
Classification: Retired
Component: user-experience
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: Pradeep Kilambi
QA Contact: Preethi Thomas
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-02-22 15:57 UTC by Preethi Thomas
Modified: 2013-09-09 16:36 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-24 20:16:36 UTC


Attachments (Terms of Use)

Description Preethi Thomas 2011-02-22 15:57:35 UTC
Description of problem:


[root@preethi upload]# rpm -q pulp
pulp-0.0.140-1.fc14.noarch


[root@preethi upload]# pulp-admin -u admin -p redhat package upload -r local-repo -r upload-1 --dir /root/upload/ --nosig -v
* Starting Package Upload

* Performing Package Uploads to Pulp server
Package [pulp-cds-0.0.140-1.fc14.noarch.rpm] already exists on the server with checksum [b5ad6375bd7c240cb16855761b39f8b2d7e77c2defb744cbfee639fa2b84bb5f]

* Performing Repo Associations 
Successfully associated the following to Repo [local-repo]: 
 Packages: 
/root/upload/pulp-cds-0.0.140-1.fc14.noarch.rpm 
 
 Files: 
None
Successfully associated the following to Repo [upload-1]: 
 Packages: 
/root/upload/pulp-cds-0.0.140-1.fc14.noarch.rpm 
 
 Files: 
None

* Package Upload complete.

[root@preethi upload]# 
[root@preethi upload]# 
[root@preethi upload]# pulp-admin -u admin -p redhat package upload -r local-repo -r upload-1 --dir /root/upload/ --nosig -v
* Starting Package Upload

* Performing Package Uploads to Pulp server
Package [pulp-cds-0.0.140-1.fc14.noarch.rpm] already exists on the server with checksum [b5ad6375bd7c240cb16855761b39f8b2d7e77c2defb744cbfee639fa2b84bb5f]

* Performing Repo Associations 
Successfully associated the following to Repo [local-repo]: 
 Packages: 
/root/upload/pulp-cds-0.0.140-1.fc14.noarch.rpm 
 
 Files: 
None
Successfully associated the following to Repo [upload-1]: 
 Packages: 
/root/upload/pulp-cds-0.0.140-1.fc14.noarch.rpm 
 
 Files: 
None

* Package Upload complete.

Comment 1 Pradeep Kilambi 2011-02-22 17:15:05 UTC
This is mostly a message change. The associations happens as a batch operation on server. So server doesnt necessarily tell the client whats being skipped, we just get back the obj if it already exists.

so modified the message to be :

$ sudo pulp-admin package upload /home/pkilambi/Downloads/adobe-release-i386-1.0-1.noarch.rpm  /home/pkilambi/Downloads/skytux-repo-1.0-4.noarch.rpm -v --repoid=testcs --nosig
* Starting Package Upload

* Performing Package Uploads to Pulp server
Package [adobe-release-i386-1.0-1.noarch.rpm] already exists on the server with checksum [aefad650828ddb5da9ebd76b326542f6e96b969c17b7859bcba6e2e3a6c0184e]
Package [skytux-repo-1.0-4.noarch.rpm] already exists on the server with checksum [fa6c87a7d7cdab86e1ef43b1f596ecff35854f1863353f130b197fc549336def]

* Performing Repo Associations 
Package association Complete for Repo [testcs]: 
 Packages: 
skytux-repo-1.0-4.noarch.rpm
adobe-release-i386-1.0-1.noarch.rpm 
 
 Files: 
None

* Package Upload complete.

Comment 2 Jeff Ortel 2011-02-23 17:59:53 UTC
Build: 0.141

Comment 3 Preethi Thomas 2011-03-07 18:49:41 UTC
[root@preethi ~]# rpm -q pulp
pulp-0.0.144-1.fc14.noarch


The message does not say its already associated

failing 



[root@preethi ~]# pulp-admin content upload -r upload2 --dir=/root/upload/ --nosig -v 
* Starting Package Upload

* Performing Package Uploads to Pulp server
Package [grinder-0.0.81-1.fc14.noarch.rpm] already exists on the server with checksum [4b9ff81cfbdc749b70e7ae20a370d783adcafbf7dcaa7d057b103422524c294f]
Package [gofer-0.20-1.fc14.noarch.rpm] already exists on the server with checksum [37f3605eabbb0ef9fb73f504b84422036e9af17f3d6247d594e610ca2a727df2]
Package [test.csv] already exists on the server with checksum [c97eabbafd39ff9f254ce5923f374f7d0083b2b5d7eb195a61465d68b7d4f91f]
Package [amanda-3.1.3-2.fc14.x86_64.rpm] already exists on the server with checksum [9f9276dc92ddcead4b07b5c6dfff9d060af9aa837699c0aa09147e40751122fc]
Package [grinder-0.0.81-1.noarch.rpm] already exists on the server with checksum [b111b13c7f68ba76eebaa51ac2a58b1989e8a56b797d682ad204f4ef84380ee6]
Package [grinder-0.0.81-1.noarch.rpm.1] already exists on the server with checksum [b111b13c7f68ba76eebaa51ac2a58b1989e8a56b797d682ad204f4ef84380ee6]
Package [pulp-cds-0.0.143-1.fc14.noarch.rpm] already exists on the server with checksum [9af33e425ed50a43d046baabacf45a4c2fc7516089dae9a4313014ca20436b69]
Package [antlr-2.7.7-6.fc12.x86_64.rpm] already exists on the server with checksum [0837d348a134abaa42aa5be4764f570c192581d56dedddf9b1bc34db9e238a7f]

* Performing Repo Associations 
Package association Complete for Repo [upload2]: 
 Packages: 
grinder-0.0.81-1.fc14.noarch.rpm
amanda-3.1.3-2.fc14.x86_64.rpm
antlr-2.7.7-6.fc12.x86_64.rpm
pulp-cds-0.0.143-1.fc14.noarch.rpm
gofer-0.20-1.fc14.noarch.rpm
grinder-0.0.81-1.noarch.rpm
grinder-0.0.81-1.noarch.rpm.1 
 
 Files: 
test.csv

* Content Upload complete.
[root@preethi ~]# 
[root@preethi ~]# 
[root@preethi ~]# pulp-admin content upload -r upload2 --dir=/root/upload/ --nosig -v 
* Starting Package Upload

* Performing Package Uploads to Pulp server
Package [grinder-0.0.81-1.fc14.noarch.rpm] already exists on the server with checksum [4b9ff81cfbdc749b70e7ae20a370d783adcafbf7dcaa7d057b103422524c294f]
Package [gofer-0.20-1.fc14.noarch.rpm] already exists on the server with checksum [37f3605eabbb0ef9fb73f504b84422036e9af17f3d6247d594e610ca2a727df2]
Package [test.csv] already exists on the server with checksum [c97eabbafd39ff9f254ce5923f374f7d0083b2b5d7eb195a61465d68b7d4f91f]
Package [amanda-3.1.3-2.fc14.x86_64.rpm] already exists on the server with checksum [9f9276dc92ddcead4b07b5c6dfff9d060af9aa837699c0aa09147e40751122fc]
Package [grinder-0.0.81-1.noarch.rpm] already exists on the server with checksum [b111b13c7f68ba76eebaa51ac2a58b1989e8a56b797d682ad204f4ef84380ee6]
Package [grinder-0.0.81-1.noarch.rpm.1] already exists on the server with checksum [b111b13c7f68ba76eebaa51ac2a58b1989e8a56b797d682ad204f4ef84380ee6]
Package [pulp-cds-0.0.143-1.fc14.noarch.rpm] already exists on the server with checksum [9af33e425ed50a43d046baabacf45a4c2fc7516089dae9a4313014ca20436b69]
Package [antlr-2.7.7-6.fc12.x86_64.rpm] already exists on the server with checksum [0837d348a134abaa42aa5be4764f570c192581d56dedddf9b1bc34db9e238a7f]

* Performing Repo Associations 
Package association Complete for Repo [upload2]: 
 Packages: 
grinder-0.0.81-1.fc14.noarch.rpm
amanda-3.1.3-2.fc14.x86_64.rpm
antlr-2.7.7-6.fc12.x86_64.rpm
pulp-cds-0.0.143-1.fc14.noarch.rpm
gofer-0.20-1.fc14.noarch.rpm
grinder-0.0.81-1.noarch.rpm
grinder-0.0.81-1.noarch.rpm.1 
 
 Files: 
test.csv

* Content Upload complete.

Comment 5 Preethi Thomas 2011-10-10 18:39:17 UTC
Fails_qa

[root@preethi ~]# rpm -q pulp
pulp-0.0.237-2.fc15.noarch


See under Repo Associations that the message is displayed twice. Not sure that was the intention

[root@preethi ~]# pulp-admin content upload mod_wsgi-3.2-3.sslpatch.fc15.x86_64.rpm -r upload --nosig -v
* Starting Content Upload

* Performing Content Uploads to Pulp server
Content [mod_wsgi-3.2-3.sslpatch.fc15.x86_64.rpm] already exists on the server with checksum [81b22d5e7e1ce72a5cb71831f34568ddfdc51997e7f113c12b0a577548e724d2]

* Performing Repo Associations 
Package with same NVREA [(u'mod_wsgi', u'0', u'3.2', u'3.sslpatch.fc15', u'x86_64')] already exists in repo [upload]
Package with same filename [mod_wsgi-3.2-3.sslpatch.fc15.x86_64.rpm] already exists in repo [upload]
Content association Complete for Repo [upload]: 
 Packages: 
mod_wsgi-3.2-3.sslpatch.fc15.x86_64.rpm 
 
 Files: 
None

* Content Upload complete.

Comment 6 Preethi Thomas 2011-10-10 19:51:39 UTC
Moving to verified as per my conversation wit prad


<prad-> thats just showing you the validations when we ran associate.. we always check for nvrea and filename
<prad-> which is what its showing
<prad-> basically checking if nvrea exists and filename is valid

Comment 7 Preethi Thomas 2012-02-24 20:16:36 UTC
Pulp v1.0 is released
Closed Current Release.

Comment 8 Preethi Thomas 2012-02-24 20:17:53 UTC
Pulp v1.0 is released.


Note You need to log in before you can comment on or make changes to this bug.