Bug 679672 - The 'Max Allowance' field must be an integer
Summary: The 'Max Allowance' field must be an integer
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise MRG
Classification: Red Hat
Component: cumin
Version: Development
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: 2.0
: ---
Assignee: Trevor McKay
QA Contact: Jan Sarenik
URL:
Whiteboard:
Depends On:
Blocks: 693778
TreeView+ depends on / blocked
 
Reported: 2011-02-23 07:45 UTC by Jan Sarenik
Modified: 2011-06-23 15:40 UTC (History)
2 users (show)

Fixed In Version: cumin-0.1.4654
Doc Type: Bug Fix
Doc Text:
Cause The Max Allowance limit input for a submission would not allow a floating point value even though a floating value is valid. Consequence Cumin would reject a limit change if the value entered was a float with en error message "The Max Allowance field must be an integer". Fix Modify the cumin input field to allow float or integer. Result Users may now enter integer or floating point values for the Max Allowance limit on a submission.
Clone Of:
Environment:
Last Closed: 2011-06-23 15:40:23 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2011:0889 0 normal SHIPPED_LIVE Red Hat Enterprise MRG Grid 2.0 Release 2011-06-23 15:35:53 UTC

Description Jan Sarenik 2011-02-23 07:45:09 UTC
Changing limit in Cumin works, but you have to overwrite
the decimal point number with integer without point.

cumin-0.1.4552-1.el5

How reproducible: 100%

Steps to Reproduce:
1. Grid -> Limits
2. Click on the name of some limit.
  
Actual results: "Max allowance" includes decimal point.

Expected results: Integer only.

Comment 1 Matthew Farrellee 2011-03-03 19:21:32 UTC
Limits are not integers, cumin should not be forcing them to be.

Submit a job with:

cmd=/bin/sleep
args=1d
concurrency_limits=sleep
queue

Comment 2 Jan Sarenik 2011-03-04 12:58:15 UTC
Matt, sorry for misunderstanding, I am talking not about the
name of the limit, but about the number to which are the
running processes limited.

So instead of "concurrency_limits=JASANLIMIT" in a submit file
I am talking about "JASANLIMIT_LIMIT = 1" in /etc/condor/...
which can be set from Cumin with help of "ENABLE_RUNTIME_CONFIG = TRUE"
condor config variable.

Comment 3 Matthew Farrellee 2011-03-04 13:19:58 UTC
JASANLIMIT_LIMIT = 1.5 is valid configuration

concurrency_limits=JASANLIMIT:.5 is a valid request

Comment 4 Jan Sarenik 2011-03-07 09:32:11 UTC
Ah, now I see. Thanks for your patience, Matt.

Comment 6 Trevor McKay 2011-03-21 13:07:51 UTC
Fixed in revision 4645.

Changed Max Allowance field to allow float in addition to integer.

Comment 7 Trevor McKay 2011-03-21 13:12:41 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause
    The Max Allowance limit input for a submission would not allow a floating point value even though a floating value is valid.

Consequence
    Cumin would reject a limit change if the value entered was a float with en error message "The Max Allowance field must be an integer".

Fix
    Modify the cumin input field to allow float or integer.

Result
    Users may now enter integer or floating point values for the Max Allowance limit on a submission.

Comment 8 Jan Sarenik 2011-03-22 11:34:25 UTC
Verified on cumin-0.1.4654-1.el5

Comment 9 errata-xmlrpc 2011-06-23 15:40:23 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHEA-2011-0889.html


Note You need to log in before you can comment on or make changes to this bug.