Bug 679692 - don't compute checksums of unsigned files which are not going to be uploaded
Summary: don't compute checksums of unsigned files which are not going to be uploaded
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Pulp
Classification: Retired
Component: z_other
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: Sprint 21
Assignee: Pradeep Kilambi
QA Contact: Preethi Thomas
URL:
Whiteboard:
Depends On:
Blocks: 563609 verified-to-close
TreeView+ depends on / blocked
 
Reported: 2011-02-23 08:57 UTC by Daniel Mach
Modified: 2011-08-16 12:20 UTC (History)
0 users

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2011-08-16 12:06:49 UTC
Embargoed:

Attachments (Terms of Use)

Description Daniel Mach 2011-02-23 08:57:01 UTC 
$ pulp-admin content upload <unsigned-rpm>
* Starting Package Upload operation. See /var/log/pulp/client.log for more verbose output

* Performing Package Uploads to Pulp server

* Content Upload complete.


package is not uploaded and /var/log/pulp/client.log contains:
2011-02-23 09:51:03,533 [ERROR][MainThread] @ content.py:95 - Package [<rpm>] is not signed. Please use --nosig. Skipping 

This takes about 15 seconds for a 600M RPM.
It could fail instantly by detecting if package is unsigned - before checksum is computed.
Comment 1 Pradeep Kilambi 2011-02-23 15:04:12 UTC 
fixed! We now check the signature before computing the metadata. Should be in next build.
Comment 2 Jeff Ortel 2011-02-23 17:59:59 UTC 
Build: 0.141
Comment 3 Preethi Thomas 2011-03-02 19:41:37 UTC 
verified
[root@preethi upload]# rpm -q pulp
pulp-0.0.143-1.fc14.noarch

[root@preethi upload]# pulp-admin content upload /root/upload/grinder-0.0.81-1.fc14.noarch.rpm 
* Starting Package Upload operation. See /var/log/pulp/client.log for more verbose output

* Performing Package Uploads to Pulp server

* Content Upload complete.

2011-03-02 14:47:18,435 [ERROR][MainThread] run() @ content.py:87 - Package [/root/upload/grinder-0.0.81-1.fc14.noarch.rpm] is not signed. Please use --nosig. Skipping
Comment 4 Preethi Thomas 2011-08-16 12:06:49 UTC 
Closing with Community Release 15

pulp-0.0.223-4.
Comment 5 Preethi Thomas 2011-08-16 12:20:46 UTC 
Closing with Community Release 15

pulp-0.0.223-4.
Note You need to log in before you can comment on or make changes to this bug.