Bug 679746 - Git doesn't ask for subject when it should
Summary: Git doesn't ask for subject when it should
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: git
Version: 14
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Chris Wright
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-02-23 12:20 UTC by Kamil Páral
Modified: 2013-01-10 10:50 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-02-23 12:34:15 UTC
Type: ---


Attachments (Terms of Use)

Description Kamil Páral 2011-02-23 12:20:08 UTC
Description of problem:
Citing from "git help send-email":

       --subject=<string>
           Specify the initial subject of the email thread. Only necessary if --compose is also set. If --compose is not set, this will be prompted for.

On the other hand:
$ git send-email autoqa.spec --dry-run
autoqa.spec
No subject line in autoqa.spec ? at /usr/libexec/git-core/git-send-email line 568.

Either man page is wrong (--subject must be set) or implementation is wrong (should ask for subject).

Version-Release number of selected component (if applicable):
git-1.7.4-1.fc14.x86_64

Comment 1 Kamil Páral 2011-02-23 12:25:54 UTC
I don't know if it is ok to give send-email a spec file as the attachment, but it doesn't work with regular patch (generated as "git diff branch1..branch2") either:

$ git send-email 1.patch --dry-run
1.patch
No subject line in 1.patch ? at /usr/libexec/git-core/git-send-email line 568.

Comment 2 Kamil Páral 2011-02-23 12:34:15 UTC
After careful reading, send-email only accepts patches in the git-format-patch format. That isn't the same to what git diff generates. Therefore this bug report it probably invalid, closing.

Comment 3 Todd Zullinger 2011-02-23 16:21:32 UTC
It may be worth noting that git send-email accepts revision lists as arguments, so you can use branch1..branch2, e.g.: git send-email branch1..branch2.  That eliminates the intermediate patch file creation.  If you want to use patches, you should use git format-patch to produce them, as it provides the format that send-email expects.


Note You need to log in before you can comment on or make changes to this bug.