Spec URL: http://akurtakov.fedorapeople.org/apache-mime4j.spec SRPM URL: http://akurtakov.fedorapeople.org/apache-mime4j-0.6.1-1.fc14.src.rpm Description: Java stream based MIME message parser
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Rpmlint output: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [x] Package is named according to the Package Naming Guidelines[1]. [x] Spec file name must match the base package name, in the format %{name}.spec. [x] Package meets the Packaging Guidelines[2]. [x] Package successfully compiles and builds into binary rpms. [x] Buildroot definition is not present [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4]. [x] License field in the package spec file matches the actual license. License type: [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] All independent sub-packages have license of their own [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package : 9dac4a5027d1dec0663f8d11d7e471e9 MD5SUM upstream package: 9dac4a5027d1dec0663f8d11d7e471e9 [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore) [x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing) [x] Package contains code, or permissable content. [-] Fully versioned dependency in subpackages, if present. [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [x] Javadoc documentation files are generated and included in -javadoc subpackage [x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks) [x] Packages have proper BuildRequires/Requires on jpackage-utils [x] Javadoc subpackages have Require: jpackage-utils [-] Package uses %global not %define [-] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [-] If source tarball includes bundled jar/class files these need to be removed prior to building [x] All filenames in rpm packages must be valid UTF-8. [x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details) [x] If package contains pom.xml files install it (including depmaps) even when building with ant [x] pom files has correct add_to_maven_depmap call which resolves to the pom file (use "JPP." and "JPP-" correctly) === Maven === [x] Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms [-] If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment [-] If package uses custom depmap "-Dmaven2.jpp.depmap.file=*" explain why it's needed in a comment [x] Package uses %update_maven_depmap in %post/%postun [x] Packages have Requires(post) and Requires(postun) on jpackage-utils (for %update_maven_depmap macro) === Other suggestions === [x] If possible use upstream build method (maven/ant/javac) [x] Avoid having BuildRequires on exact NVR unless necessary [x] Package has BuildArch: noarch (if possible) [x] Latest version is packaged. [?] Reviewer should test that the package builds in mock. Tested on: I tested with mock -r fedora-rawhide-x86_64 --rebuild ../SRPMS/apache-mime4j-0.6.1-1.fc14.src.rpm but got Error: No Package found for apache-james-project This is due to rawhide yum repository not being updated instantly. I was able to rebuild locally by grabbing the package directly from koji. I think that's OK. === Issues === 1. One small issue, please fix before building in koji. install -m 644 target/%{name}-%{version}.jar %{buildroot}%{_javadir}/%{name} which should be changed to install -m 644 target/%{name}-%{version}.jar %{buildroot}%{_javadir}/%{name}.jar ================ *** APPROVED *** ================
Nice catch. I will fix it on import.
New Package SCM Request ======================= Package Name: apache-mime4j Short Description: Java stream based MIME message parser Owners: akurtakov Branches: F-15 InitialCC:
Git done (by process-git-requests).
Build done. http://koji.fedoraproject.org/koji/buildinfo?buildID=230545