Bug 680368 - Review Request: decentxml - XML parser optimized for round-tripping and code reuse
Summary: Review Request: decentxml - XML parser optimized for round-tripping and code ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Alexander Kurtakov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-02-25 09:46 UTC by Stanislav Ochotnicky
Modified: 2011-03-01 14:16 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-03-01 14:16:39 UTC
Type: ---
Embargoed:
akurtako: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Stanislav Ochotnicky 2011-02-25 09:46:09 UTC
Spec URL: http://sochotni.fedorapeople.org/packages/decentxml.spec
SRPM URL: http://sochotni.fedorapeople.org/packages/decentxml-1.3-1.fc14.src.rpm

Description: 
XML parser optimized for round-tripping and code reuse with main
features being:
 * Allows 100% round-tripping, even for weird whitespace between
   attributes in the start tag or in the end tag
 * Suitable for building editors and filters which want/need to
   preserve the original file layout as much as possible
 * Error messages have line and column information
 * Easy to reuse individual components
 * XML 1.1 compatible

Comment 1 Alexander Kurtakov 2011-02-25 11:03:21 UTC
I'll do this one.

Comment 2 Alexander Kurtakov 2011-02-25 12:22:44 UTC
Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[x]  Rpmlint output:
decentxml.noarch: W: spelling-error %description -l en_US whitespace -> white space, white-space, whites pace
decentxml.noarch: W: non-conffile-in-etc /etc/maven/fragments/decentxml
Not a problem.
decentxml.src: W: invalid-url Source0: decentxml-1.3.tar.xz
Request to upstream to provide source tarball is made.
[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format %{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[x]  Package successfully compiles and builds into binary rpms.
[x]  Buildroot definition is not present
[x]  Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4].
[x]  License field in the package spec file matches the actual license.
License type: BSD
[x]  If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
[x]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[-]  Sources used to build the package matches the upstream source, as provided in the spec URL.
[x]  All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5].
[x]  Package must own all directories that it creates.
[x]  Package requires other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  Permissions on files are set properly.
[x]  Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore)
[x]  Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing)
[x]  Package contains code, or permissable content.
[x]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI application.
[x]  Package does not own files or directories owned by other packages.
[x]  Javadoc documentation files are generated and included in -javadoc subpackage
[x]  Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x]  Packages have proper BuildRequires/Requires on jpackage-utils
[x]  Javadoc subpackages have Require: jpackage-utils
[x]  Package uses %global not %define
[x]  If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...)
[x]  If source tarball includes bundled jar/class files these need to be removed prior to building
[x]  All filenames in rpm packages must be valid UTF-8.
[x]  Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x]  If package contains pom.xml files install it (including depmaps) even when building with ant
[x]  pom files has correct add_to_maven_depmap call which resolves to the pom file (use "JPP." and "JPP-" correctly)

=== Maven ===
[x]  Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms
[-]  If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment
[-]  If package uses custom depmap "-Dmaven2.jpp.depmap.file=*" explain why it's needed in a comment
[x]  Package uses %update_maven_depmap in %post/%postun
[x]  Packages have Requires(post) and Requires(postun) on jpackage-utils (for %update_maven_depmap macro)

=== Other suggestions ===
[x]  If possible use upstream build method (maven/ant/javac)
[x]  Avoid having BuildRequires on exact NVR unless necessary
[x]  Package has BuildArch: noarch (if possible)
[x]  Latest version is packaged.

=== Issues ===
1. Not a big issue but due to assembly plugin tied to the package stage there is no need to run javadoc:javadoc. The assembly plugin run is putting the javadoc in target/apidocs not in target/site/apidocs. Change if you like it but it reduces the build time significantly for me.

APPROVED

Comment 3 Stanislav Ochotnicky 2011-02-25 12:40:03 UTC
New Package SCM Request
=======================
Package Name: decentxml
Short Description: XML parser optimized for round-tripping and code reuse
Owners: sochotni
Branches: f15
InitialCC: java-sig

Comment 4 Jason Tibbitts 2011-02-25 14:34:24 UTC
Git done (by process-git-requests).

Comment 5 Stanislav Ochotnicky 2011-03-01 14:16:39 UTC
I fixed the javadoc generation.

Package built:
https://koji.fedoraproject.org/koji/buildinfo?buildID=230802

Thanks for review and repos.


Note You need to log in before you can comment on or make changes to this bug.