Bug 680578 - ifconfig down and up on vlan interface makes the link fcoe ctlr link remain down
Summary: ifconfig down and up on vlan interface makes the link fcoe ctlr link remain down
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: fcoe-utils
Version: 6.1
Hardware: Unspecified
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Petr Šabata
QA Contact: BaseOS QE Security Team
URL: http://www.open-fcoe.org/patchwork/pa...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-02-26 00:56 UTC by Nithin Nayak Sujir
Modified: 2011-05-19 14:20 UTC (History)
10 users (show)

Fixed In Version: fcoe-utils-1.0.17-6.el6
Doc Type: Bug Fix
Doc Text:
Cause Bring the FCoE VLAN interface down and then up again. Consequence The FCoE interface is not re-enabled after the VLAN interface is brought up again. Fix Enable the interface. Result The FCoE interface is enabled after the VLAN interface is brought up.
Clone Of:
Environment:
Last Closed: 2011-05-19 14:20:28 UTC
Target Upstream Version:


Attachments (Terms of Use)
Automatically enable FCoE interface after interface restart (424 bytes, patch)
2011-02-28 15:41 UTC, Petr Šabata
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2011:0743 0 normal SHIPPED_LIVE fcoe-utils bug fix update 2011-05-18 18:09:08 UTC

Description Nithin Nayak Sujir 2011-02-26 00:56:17 UTC
Description of problem:
When ifconfig down is performed on a vlan interface fcoe-utils calls
DISABLE on the fcoe port. However, when it comes back up, it does not
call ENABLE since it was an auto created port. It waits for vlan
discovery to complete. But since vlan discovery is disabled for vlan
interfaces, ENABLE never gets called and the link remains down.


How reproducible:
By bringing down and up the vlan interface with bnx2fc driver as fcoe lld
Note: The current fcoe driver registers a device notifier and calls
fcoe_ctlr_link_up on its own. This patch makes ENABLE/DISABLE symmetric
and avoids forcing the llds to register their own notifiers.


Steps to Reproduce:
1. ifconfig eth4.<vlan>-fcoe down
2. ifconfig eth4.<vlan>-fcoe up
3. fcoeadm -i
  
Actual results:
    State will show LinkDown


Expected results:
    State should be Online

Additional info:
    can't be reproduced with fcoe driver because it does link up on its own.


Patch for the Fix pending review at open-fcoe.org:
http://www.open-fcoe.org/patchwork/patch/1687/

Comment 2 Petr Šabata 2011-02-28 10:04:16 UTC
This seems reasonable.
Requesting devel ack.

Comment 3 Petr Šabata 2011-02-28 15:41:39 UTC
Created attachment 481401 [details]
Automatically enable FCoE interface after interface restart

Comment 6 Eduard Benes 2011-03-01 14:52:12 UTC
Hi Nithin, QE does not have a proper test environment to verify this bug and would like to ask for your commitment to help with testing this bug before scheduling the fix for a next minor update. Thanks

Comment 7 Michael Chan 2011-03-01 17:12:28 UTC
Adding Broadcom DVT to CC to help verify this.

Comment 9 Petr Šabata 2011-03-02 15:24:09 UTC
Fixed in CVS tag fcoe-utils-1.0.17-6.el6.

Comment 11 Chris Ward 2011-04-06 11:04:19 UTC
~~ Partners and Customers ~~

This bug was included in RHEL 6.1 Beta. Please confirm the status of this request as soon as possible.

If you're having problems accessing 6.1 bits, are delayed in your test execution or find in testing that the request was not addressed adequately, please let us know.

Thanks!

Comment 12 Miroslav Vadkerti 2011-04-06 11:22:20 UTC
Doing SanityOnly testing:
* Latest release of RHEL6.1 contains fcoe-utils-1.0.17-7.el6
* All available RHTS tests PASS:
/CoreOS/fcoe-utils/Regression/bz503165-running-fcoeadm-before-loading-fcoe-stack-tracebacks
/CoreOS/fcoe-utils/Regression/bz619604-fcoe-utils-enabled-in-2345-by-default
/CoreOS/fcoe-utils/Sanity/init-scripts-LSB
/CoreOS/fcoe-utils/Sanity/long-form-options

* rebuilding src.rpm without issues on all archs with the latest RHEL6.1
packages:
kernel-2.6.32-128.el6.x86_64
lldpad-0.9.41-3.el6.x86_64

The patch is applied:
+ echo 'Patch #15 (fcoe-utils-1.0.17-auto-enable.patch):'
Patch #15 (fcoe-utils-1.0.17-auto-enable.patch):
+ /bin/cat /root/rpmbuild/SOURCES/fcoe-utils-1.0.17-auto-enable.patch
+ /usr/bin/patch -s -p1 -b --suffix .auto-enable --fuzz=0

Comment 13 Eduard Benes 2011-04-20 11:58:28 UTC
@OtherQA feedback contact person, please update us with the latest available test results confirming the resolution of this request. Thank you.

Comment 14 Abe Demcho 2011-04-25 17:17:08 UTC
Fix verified by looping ifconfig ethX.<VLAN>-fcoe up/down 100 times, link always becomes online

Comment 15 Petr Šabata 2011-05-09 14:20:37 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause
    Bring the FCoE VLAN interface down and then up again.
Consequence
    The FCoE interface is not re-enabled after the VLAN interface is brought
    up again.
Fix
    Enable the interface.
Result
    The FCoE interface is enabled after the VLAN interface is brought up.

Comment 16 errata-xmlrpc 2011-05-19 14:20:28 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0743.html


Note You need to log in before you can comment on or make changes to this bug.