Spec URL: http://fedorapeople.org/~iarnell/review/perl-Browser-Open.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Browser-Open-0.03-1.fc16.src.rpm Description: The functions optionally exported by this module allows you to open URLs in the user browser. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2868892 *rt-0.10_01
Package: perl-Browser-Open Version: 0.03 Release: 1.fc16 Sources: Browser-Open-0.03.tar.gz Patches: ---------- Package successfully built locally. Package successfully built in mock, fedora-rawhide-x86_64. Package successfully built in mock, fedora-rawhide-i386. Package successfully built in koji, dist-rawhide. MUST items: [ OK ] Package does NOT include pre-built binaries or libraries [ OK ] Spec file is legible and written in American english [ OK ] Package successfully builds on at least one supported primary architecture [ -- ] All ExcludeArch tags valid, referencing proper bug reports [ OK ] Package obeys FHS (with _libexecdir and /srv exceptions) [ OK ] No errors reported by rpmlint [ OK ] Changelog present and properly formatted [ OK ] Package does NOT include Packager, Vendor, Copyright or PreReq tags [ OK ] Source tags are working URLs and sources match upstream or justified otherwise [ OK ] Requires correct or justified otherwise [ NOTE ] BuildRequires correct or justified otherwise [ OK ] All file names are in proper UTF-8 encoding [ OK ] All plain text failes are in proper UTF-8 encoding [ -- ] Large documentation files are located in doc subpackage [ OK ] All documentation prefixed with %doc [ OK ] Documentation is NOT executable [ OK ] No files in %doc are needed at run-time [ -- ] Compiler flags honor Fedora defaults or are justified [ -- ] Package generates useful debuginfo packages [ -- ] Header files are placed in devel subpackage [ -- ] Unversioned shared libraries are placed in devel subpackage [ -- ] Pkgconfig files are placed in devel subpackage [ -- ] Full-versioned Requires of the base package in subpackages [ -- ] Package calls ldconfig in post and postun sections for all subpackages, if applicable [ -- ] Static libraries are provided by static subpackage [ OK ] Package contains no static executables unless approved by FESCo [ OK ] Package does NOT bundle any system libraries [ -- ] RPath not used for anything besides internal libraries [ -- ] All config files are marked noreplace or justified otherwise [ OK ] No config files are located under /usr [ -- ] Package contains a SystemV-compatible initscript [ -- ] A GUI application installs a proper desktop file [ -- ] All desktop files are installed by desktop-file-install or justified otherwise [ OK ] Package consistently uses macros [ -- ] makeinstall macro is used only if make install DESTDIR=%{buildroot} does NOT work [ -- ] Macros in Summary and description are expandable at build-time [ -- ] globals used in place of defines [ -- ] Locales handled correctly -- package requires gettext and uses find_lang, if applicable [ -- ] Scriptlets are sane [ OK ] Package is not relocatable unless justified [ OK ] Package contains only acceptable code or content [ OK ] Package owns all the files and directories it creates, installs and/or uses unless those are already ow ned by another package [ OK ] files sections do NOT contain duplicate files except for licenses [ OK ] All files sections use defattr or justify otherwise [ OK ] Package does NOT cause any conflicts [ OK ] Package does NOT contain kernel modules [ OK ] Package does NOT bundle fonts or other general purpose data [ OK ] Final Requires and Provides are sane SHOULD items: [ OK ] The Summary does NOT end with a period [ OK ] Package does NOT include BuildRoot tag, clean section or buildroot removal in install section [ OK ] Package should preserve files timestamps [ OK ] Package does NOT explicitly BuildRequire bash, bzip2, coreutils, cpio, diffutils, fedora-release, findu tils, gawk, gcc, gcc-c++, grep, gzip, info, make, patch, redhat-rpm-config, rpm-build, sed, shadow-utils, tar, u nzip, util-linux-ng, which or xz [ OK ] Description does NOT consist of lines longer than 80 characters [ OK ] Package uses parallel make [ -- ] In case of a web application, package installs date into /usr/share instead of /var/www [ -- ] All patches have a comment or an upstream bug link [ -- ] Package installs manpages for all executables [ OK ] Package contains check section and all tests pass [ ?? ] Package works as expected NOTES: ------ 1. BuildRequire File::Spec::Functions 2. release-pod-syntax.t (optionally) requires Test::Pod 1.00; I'd suggest a versioned BuildRequires tag
I've updated the build requires. Spec URL: http://fedorapeople.org/~iarnell/review/perl-Browser-Open.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Browser-Open-0.03-2.fc16.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2980862
Looks okay to me now, approving.
Thanks for the review, Petr. New Package SCM Request ======================= Package Name: perl-Browser-Open Short Description: Open a browser in a given URL Owners: iarnell Branches: f13 f14 f15 InitialCC: perl-sig
Git done (by process-git-requests).
perl-Browser-Open-0.03-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-Browser-Open-0.03-2.fc14
perl-Browser-Open-0.03-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Browser-Open-0.03-2.fc15
perl-Browser-Open-0.03-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/perl-Browser-Open-0.03-2.fc13
perl-Browser-Open-0.03-2.fc13 has been pushed to the Fedora 13 testing repository.
perl-Browser-Open-0.03-2.fc15 has been pushed to the Fedora 15 stable repository.
perl-Browser-Open-0.03-2.fc13 has been pushed to the Fedora 13 stable repository.
perl-Browser-Open-0.03-2.fc14 has been pushed to the Fedora 14 stable repository.