Bug 680666 - Review Request: rssdler - A utility to automatically download enclosures and other objects linked to from various types of RSS feeds
Summary: Review Request: rssdler - A utility to automatically download enclosures and ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mario Blättermann
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-02-26 20:21 UTC by Ankur Sinha (FranciscoD)
Modified: 2011-09-07 00:22 UTC (History)
4 users (show)

Fixed In Version: rssdler-0.4.2-2.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-08-04 18:43:17 UTC
Type: ---
Embargoed:
mario.blaettermann: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Ankur Sinha (FranciscoD) 2011-02-26 20:21:08 UTC
Spec URL: http://ankursinha.fedorapeople.org/rssdler/rssdler.spec
SRPM URL: http://ankursinha.fedorapeople.org/rssdler/rssdler-0.4.2-2.fc16.src.rpm

Mock build logs etc at 
http://ankursinha.fedorapeople.org/rssdler/

Description: 
A utility to automatically download enclosures and other objects 
linked to from various types of RSS feeds. Works well on podcasts, 
videocasts, and torrents.

Features include:
- filtering using regular expressions and/or file size
- global, feed, and filter based download locations
- can run in the background (at least on GNU/Linux) like a daemon
- various logging and verbosity levels
- support for sites protected with cookies (LWP/MSIE/Mozilla/Safari/Firefox3)
- global and feed scan times
- respects 'ttl' tag in feeds that have them
- call custom functions after a download or after a scan of the feed (episode advancement!)
- generates an RSS feed of what it has downloaded.

Because it is written in Python, it is highly cross-platform compatible. 
It tries to be memory efficient, with reports of it functioning on 
consumer routers. Minimal external dependencies help keep that a reality. 
It became popular when people started using it in conjunction with 
rTorrent for torrent broadcatching.

Comment 1 Sergio Belkin 2011-02-28 15:30:47 UTC
Hi Ankur 
A note: Perhaps you don't need neither BuildRoot tag nor %clean section

Greetings

Comment 2 Ankur Sinha (FranciscoD) 2011-03-13 21:00:03 UTC
(In reply to comment #1)
> Hi Ankur 
> A note: Perhaps you don't need neither BuildRoot tag nor %clean section
> 
> Greetings

Ugh! I'll correct that. (The spec template that vim uses hasn't been updated apparently). Thanks Sergio.

Ankur

Comment 3 Ankur Sinha (FranciscoD) 2011-05-25 11:54:46 UTC
Corrected:


* Wed May 25 2011 Ankur Sinha <ankursinha AT fedoraproject DOT org> - 0.4.2-2
- Remove buildroot tag and clean section
- added an example config in docs

http://ankursinha.fedorapeople.org/rssdler/rssdler.spec

http://ankursinha.fedorapeople.org/rssdler/rssdler-0.4.2-2.fc15.src.rpm

Thanks,
Ankur

Comment 4 Mario Blättermann 2011-07-28 19:32:50 UTC
$ rpmlint -i -v *spec *rpm
rssdler.spec: I: checking-url http://rssdler.googlecode.com/files/rssdler-0.4.2.tar.gz (timeout 10 seconds)
rssdler.spec: W: invalid-url Source0: http://rssdler.googlecode.com/files/rssdler-0.4.2.tar.gz HTTP Error 404: Not Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.

rssdler.src: I: checking
rssdler.src: W: spelling-error %description -l en_US videocasts -> video casts, video-casts, videocassette
The value of this tag appears to be misspelled. Please double-check.

rssdler.src: W: spelling-error %description -l en_US ttl -> tel, til, Tl
The value of this tag appears to be misspelled. Please double-check.

rssdler.src: W: spelling-error %description -l en_US rTorrent -> r Torrent, torrent, Torrens
The value of this tag appears to be misspelled. Please double-check.

rssdler.src: W: spelling-error %description -l en_US broadcatching -> broad catching, broad-catching, broadcasting
The value of this tag appears to be misspelled. Please double-check.

rssdler.src: I: checking-url http://code.google.com/p/rssdler/ (timeout 10 seconds)
rssdler.src: I: checking-url http://rssdler.googlecode.com/files/rssdler-0.4.2.tar.gz (timeout 10 seconds)
rssdler.src: W: invalid-url Source0: http://rssdler.googlecode.com/files/rssdler-0.4.2.tar.gz HTTP Error 404: Not Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.

1 packages and 1 specfiles checked; 0 errors, 6 warnings.


The unavailable URLs are a common problem with Googlecode hosted software. I've tested it, the file is downloadable.

Spelling errors could be ignored.

Stay tuned for a full review.

Comment 5 Mario Blättermann 2011-07-28 19:46:34 UTC
Koji scratch build for f16:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3236360

---------------------------------
key:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
    GPLv2
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
    $ md5sum *
    2f0aef5611bc1231928b861f717953eb  rssdler-0.4.2.tar.gz
    2f0aef5611bc1231928b861f717953eb  rssdler-0.4.2.tar.gz.orig

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- See Koji build above.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates. 
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

[.] SHOULD: If the source package does not include license text(s) as a
    separate file from upstream, the packager SHOULD query upstream...

[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
    See Koji build above (which uses mock anyway)
[+] SHOULD: The reviewer should test that the package functions as described.
    Works properly, given the current development state.

[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[.] SHOULD: Your package should contain man pages for binaries/scripts.
    Currently no man page available.


----------------

PACKAGE APPROVED

----------------

Just some hints, no blockers:

- If you don't define BuildRoot, you also don't have to use any »rm -rf $RPM_BUILD_ROOT« calls explicitly. This is done automatically.

- To match the usual behaviour, rename gpl-2.0.txt to COPYING.

Comment 6 Ankur Sinha (FranciscoD) 2011-07-29 10:55:18 UTC
Thanks for the review :D

I'll make these minor tweaks when I push to scm.

Comment 7 Ankur Sinha (FranciscoD) 2011-07-29 10:56:17 UTC
New Package SCM Request
=======================
Package Name: rssdler
Short Description: A utility to automatically download enclosures and other objects linked to from various types of RSS feeds
Owners: ankursinha
Branches: f14 f15 f16
InitialCC:

Comment 8 Gwyn Ciesla 2011-07-29 12:29:13 UTC
Git done (by process-git-requests).

Comment 9 Fedora Update System 2011-07-30 10:12:59 UTC
rssdler-0.4.2-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rssdler-0.4.2-2.fc14

Comment 10 Fedora Update System 2011-07-30 10:13:07 UTC
rssdler-0.4.2-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/rssdler-0.4.2-2.fc15

Comment 11 Fedora Update System 2011-07-30 10:13:15 UTC
rssdler-0.4.2-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/rssdler-0.4.2-2.fc16

Comment 12 Fedora Update System 2011-08-01 20:16:09 UTC
rssdler-0.4.2-2.fc16 has been pushed to the Fedora 16 testing repository.

Comment 13 Fedora Update System 2011-08-28 05:28:31 UTC
rssdler-0.4.2-2.fc16 has been pushed to the Fedora 16 stable repository.

Comment 14 Fedora Update System 2011-09-07 00:10:09 UTC
rssdler-0.4.2-2.fc14 has been pushed to the Fedora 14 stable repository.

Comment 15 Fedora Update System 2011-09-07 00:22:21 UTC
rssdler-0.4.2-2.fc15 has been pushed to the Fedora 15 stable repository.


Note You need to log in before you can comment on or make changes to this bug.