Red Hat Bugzilla – Bug 680999
Eclipse copy-platform script shouldn't use wildcard for dropins
Last modified: 2011-07-05 15:41:04 EDT
Description of problem:
The copy-platform script uses wildcards when checking if the desired components exist in either /usr/lib/eclipse/dropins or /usr/share/eclipse/dropins. This causes problems when a name is a subset of a dropins folder. For example, the eclispe-cdt package needs to load rse plugins and so specifies rse in the list passed to copy-platform. There is a sub-package eclipse-cdt-parsers that installs into /usr/lib/eclispe/dropins/cdt-parsers. The rse is a subset of the name and so the plugins and features get copied over. This causes the eclipse-cdt build to not build some of those plugins/features.
The script should only be allowing the given names when searching in the dropins folders.
Version-Release number of selected component (if applicable):
This problem exists on f14, f15, and rawhide.
Attempt to build Fedora eclipse-cdt package on system where eclipse-cdt-parsers is already installed.
Build will fail.
Do you have a patch, Jeff?
Created attachment 481473 [details]
Adding a proposed patch.
Do you think I should include it in next eclipse-build?
Jeff's patch is reversed but if it fixes the issue for him (and I understand what he's trying to accomplish and it looks okay to me), yes, let's apply it upstream. Thanks.
I've been looking into making this change upstream but I'm first going to ensure that none of the Eclipse packages in Fedora rely on this globbing.
I rebuilt all eclipse-* packages with a locally-modified copy-platform and everything builds fine. I'll see about getting this change into eclipse-build upstream.
This was really an upstream eclipse-build bug and I've fixed it there in commit c5838267623ca6d5de4475227f3c70b977c6147e:
Watch for it in a future Eclipse build in rawhide.