SPEC: http://jstanley.fedorapeople.org/trace-cmd.spec SRPM: http://jstanley.fedorapeople.org/trace-cmd-1.0.5-1.fc13.src.rpm trace-cmd is a user interface to Ftrace. Instead of needing to use the debugfs directly, trace-cmd will handle of setting of options and tracers and will record into a data file.
rpmlint /var/lib/mock/fedora-15-x86_64/result trace-cmd.x86_64: W: summary-not-capitalized C trace-cmd is a user interface to Ftrace trace-cmd.x86_64: W: name-repeated-in-summary C trace-cmd trace-cmd.x86_64: W: spelling-error %description -l en_US debugfs -> debugs, debuggers trace-cmd.x86_64: W: invalid-license LGPLv2.1 trace-cmd.x86_64: W: invalid-url URL: http://www.kernel.org/pub/linux/analysis/trace-cmd/ <urlopen error timed out> trace-cmd.x86_64: E: arch-dependent-file-in-usr-share /usr/share/trace-cmd/plugins/plugin_sched_switch.so trace-cmd.x86_64: E: arch-dependent-file-in-usr-share /usr/share/trace-cmd/plugins/plugin_hrtimer.so trace-cmd.x86_64: E: arch-dependent-file-in-usr-share /usr/share/trace-cmd/plugins/plugin_kmem.so trace-cmd.x86_64: E: arch-dependent-file-in-usr-share /usr/share/trace-cmd/plugins/plugin_mac80211.so trace-cmd.x86_64: E: arch-dependent-file-in-usr-share /usr/share/trace-cmd/plugins/plugin_jbd2.so trace-cmd.x86_64: W: spurious-executable-perm /usr/share/man/man1/trace-cmd-stop.1.gz trace-cmd.x86_64: W: spurious-executable-perm /usr/share/man/man5/trace-cmd.dat.5.gz trace-cmd.x86_64: W: spurious-executable-perm /usr/share/man/man1/trace-cmd-split.1.gz trace-cmd.x86_64: W: spurious-executable-perm /usr/share/man/man1/trace-cmd.1.gz trace-cmd.x86_64: W: spurious-executable-perm /usr/share/man/man1/trace-cmd-reset.1.gz trace-cmd.x86_64: W: spurious-executable-perm /usr/share/man/man1/trace-cmd-start.1.gz trace-cmd.x86_64: W: spurious-executable-perm /usr/share/man/man1/trace-cmd-report.1.gz trace-cmd.x86_64: W: spurious-executable-perm /usr/share/man/man1/trace-cmd-listen.1.gz trace-cmd.x86_64: W: spurious-executable-perm /usr/share/man/man1/trace-cmd-list.1.gz trace-cmd.x86_64: W: spurious-executable-perm /usr/share/man/man1/trace-cmd-extract.1.gz trace-cmd.x86_64: W: spurious-executable-perm /usr/share/man/man1/trace-cmd-record.1.gz trace-cmd.src: W: summary-not-capitalized C trace-cmd is a user interface to Ftrace trace-cmd.src: W: name-repeated-in-summary C trace-cmd trace-cmd.src: W: spelling-error %description -l en_US debugfs -> debugs, debuggers trace-cmd.src: W: invalid-license LGPLv2.1 trace-cmd.src:65: E: files-attr-not-set trace-cmd.src:66: E: files-attr-not-set trace-cmd.src:67: E: files-attr-not-set trace-cmd.src:68: E: files-attr-not-set trace-cmd-debuginfo.x86_64: W: invalid-license LGPLv2.1 kernelshark.x86_64: W: spelling-error Summary(en_US) cmd -> cm, cad, cod kernelshark.x86_64: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end kernelshark.x86_64: W: spelling-error %description -l en_US cmd -> cm, cad, cod kernelshark.x86_64: W: invalid-license LGPLv2.1 kernelshark.x86_64: W: no-documentation kernelshark.x86_64: W: no-manual-page-for-binary trace-graph kernelshark.x86_64: W: no-manual-page-for-binary trace-view kernelshark.x86_64: W: no-manual-page-for-binary kernelshark 4 packages and 0 specfiles checked; 9 errors, 29 warnings. builds in mock spelling complaints can be ignored license needs fixed execute perms on man pages need fixed. the .so files are they some kind of plugin thats dlopened? they probably should go in %{_libdir}%{name} if thats the case
@Jon, your package needs to be updated according to Dennis' hints.
Now that this is on my front burner again, I was going to update to the latest upstream. However, it won't compile on a modern kernel, due to http://comments.gmane.org/gmane.linux.kernel/1236892 which was applied in git. I can certainly build from a git snapshot, which I've verified *does* build. Steve, when are you going to tag something in git that will actually build? :) Also, can you see the comments in the review from Dennis about the plugin dir? I can hack that up in the Fedora Makefile, but would rather see it fixed upstream.
BTW, latest upstream that I refer to is the tag 'trace-cmd-v1.2' in git, which is from Nov 2011.
OK, I updated per most of the review comments, and made a version that actually builds! Spec: http://jstanley.fedorapeople.org/trace-cmd.spec SRPM: http://jstanley.fedorapeople.org/trace-cmd-1.2-2.20120606git8266dff.fc16.src.rpm The only rpmlint warnings left are: [jstanley@crusher ~]$ rpmlint /home/jstanley/rpmbuild/RPMS/x86_64/trace-cmd-1.2-1.20120606git8266dff.fc16.x86_64.rpm trace-cmd.x86_64: W: summary-not-capitalized C trace-cmd is a user interface to Ftrace trace-cmd.x86_64: W: name-repeated-in-summary C trace-cmd trace-cmd.x86_64: W: spelling-error %description -l en_US debugfs -> debugs, debuggers trace-cmd.x86_64: E: incorrect-fsf-address /usr/share/doc/trace-cmd-1.2/COPYING.LIB 1 packages and 0 specfiles checked; 1 errors, 4 warnings. The spelling errors are OK, and the bad FSF address......I'm not sure what to do about. Include a different copy of the LGPLv2 than upstream does?
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4432560
(In reply to comment #5) > The spelling errors are OK, and the bad FSF address......I'm not sure what > to do about. Include a different copy of the LGPLv2 than upstream does? No, leave the file COPYING.LIB untouched and inform the upstream folks about that. That's all you have to do. In my own packages there are a lot of old FSF addresses, and in most cases upstream is dead. That's why the problem will never be solved. No matter, we speak about a snail address, which probably almost never will be used by someone to get a printed copy. I will have a deeper look in your package next days.
$ rpmlint -i -v * kernelshark.i686: I: checking kernelshark.i686: W: spelling-error Summary(en_US) cmd -> cm, cad, cod The value of this tag appears to be misspelled. Please double-check. kernelshark.i686: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end The value of this tag appears to be misspelled. Please double-check. kernelshark.i686: W: spelling-error %description -l en_US cmd -> cm, cad, cod The value of this tag appears to be misspelled. Please double-check. kernelshark.i686: I: checking-url http://git.kernel.org/?p=linux/kernel/git/rostedt/trace-cmd.git;a=summary (timeout 10 seconds) kernelshark.i686: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. kernelshark.i686: E: script-without-shebang /usr/share/kernelshark/html/index.html This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. kernelshark.i686: W: no-manual-page-for-binary trace-graph Each executable in standard binary directories should have a man page. kernelshark.i686: W: no-manual-page-for-binary kernelshark Each executable in standard binary directories should have a man page. kernelshark.i686: W: no-manual-page-for-binary trace-view Each executable in standard binary directories should have a man page. kernelshark.x86_64: I: checking kernelshark.x86_64: W: spelling-error Summary(en_US) cmd -> cm, cad, cod The value of this tag appears to be misspelled. Please double-check. kernelshark.x86_64: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end The value of this tag appears to be misspelled. Please double-check. kernelshark.x86_64: W: spelling-error %description -l en_US cmd -> cm, cad, cod The value of this tag appears to be misspelled. Please double-check. kernelshark.x86_64: I: checking-url http://git.kernel.org/?p=linux/kernel/git/rostedt/trace-cmd.git;a=summary (timeout 10 seconds) kernelshark.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. kernelshark.x86_64: E: script-without-shebang /usr/share/kernelshark/html/index.html This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. kernelshark.x86_64: W: no-manual-page-for-binary trace-graph Each executable in standard binary directories should have a man page. kernelshark.x86_64: W: no-manual-page-for-binary kernelshark Each executable in standard binary directories should have a man page. kernelshark.x86_64: W: no-manual-page-for-binary trace-view Each executable in standard binary directories should have a man page. trace-cmd.i686: I: checking trace-cmd.i686: W: summary-not-capitalized C trace-cmd is a user interface to Ftrace Summary doesn't begin with a capital letter. trace-cmd.i686: W: name-repeated-in-summary C trace-cmd The name of the package is repeated in its summary. This is often redundant information and looks silly in various programs' output. Make the summary brief and to the point without including redundant information in it. trace-cmd.i686: W: spelling-error %description -l en_US debugfs -> debugs, debuggers The value of this tag appears to be misspelled. Please double-check. trace-cmd.i686: W: incoherent-version-in-changelog 1.2-2.20120606git8266dff ['1.2-1.20120606git8266dff.fc17', '1.2-1.20120606git8266dff'] The latest entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. trace-cmd.i686: I: checking-url http://git.kernel.org/?p=linux/kernel/git/rostedt/trace-cmd.git;a=summary (timeout 10 seconds) trace-cmd.i686: E: incorrect-fsf-address /usr/share/doc/trace-cmd-1.2/COPYING.LIB The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. trace-cmd.x86_64: I: checking trace-cmd.x86_64: W: summary-not-capitalized C trace-cmd is a user interface to Ftrace Summary doesn't begin with a capital letter. trace-cmd.x86_64: W: name-repeated-in-summary C trace-cmd The name of the package is repeated in its summary. This is often redundant information and looks silly in various programs' output. Make the summary brief and to the point without including redundant information in it. trace-cmd.x86_64: W: spelling-error %description -l en_US debugfs -> debugs, debuggers The value of this tag appears to be misspelled. Please double-check. trace-cmd.x86_64: W: incoherent-version-in-changelog 1.2-2.20120606git8266dff ['1.2-1.20120606git8266dff.fc17', '1.2-1.20120606git8266dff'] The latest entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. trace-cmd.x86_64: I: checking-url http://git.kernel.org/?p=linux/kernel/git/rostedt/trace-cmd.git;a=summary (timeout 10 seconds) trace-cmd.x86_64: E: incorrect-fsf-address /usr/share/doc/trace-cmd-1.2/COPYING.LIB The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. trace-cmd.src: I: checking trace-cmd.src: W: summary-not-capitalized C trace-cmd is a user interface to Ftrace Summary doesn't begin with a capital letter. trace-cmd.src: W: name-repeated-in-summary C trace-cmd The name of the package is repeated in its summary. This is often redundant information and looks silly in various programs' output. Make the summary brief and to the point without including redundant information in it. trace-cmd.src: W: spelling-error %description -l en_US debugfs -> debugs, debuggers The value of this tag appears to be misspelled. Please double-check. trace-cmd.src: I: checking-url http://git.kernel.org/?p=linux/kernel/git/rostedt/trace-cmd.git;a=summary (timeout 10 seconds) trace-cmd.src:16: W: macro-in-comment %{version} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. trace-cmd.src:16: W: macro-in-comment %{checkout} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. trace-cmd.src:16: W: macro-in-comment %{version} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. trace-cmd.src:16: W: macro-in-comment %{checkout} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. trace-cmd.src:16: W: macro-in-comment %{git_commit} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. trace-cmd.src: W: invalid-url Source0: trace-cmd-1.2.20120606git8266dff.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL. trace-cmd-debuginfo.i686: I: checking trace-cmd-debuginfo.i686: I: checking-url http://git.kernel.org/?p=linux/kernel/git/rostedt/trace-cmd.git;a=summary (timeout 10 seconds) trace-cmd-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/trace-cmd-1.2.20120606git8266dff/trace-blk-hack.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. trace-cmd-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/trace-cmd-1.2.20120606git8266dff/trace-options.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. trace-cmd-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/trace-cmd-1.2.20120606git8266dff/trace-recorder.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. trace-cmd-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/trace-cmd-1.2.20120606git8266dff/plugin_blk.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. trace-cmd-debuginfo.x86_64: I: checking trace-cmd-debuginfo.x86_64: I: checking-url http://git.kernel.org/?p=linux/kernel/git/rostedt/trace-cmd.git;a=summary (timeout 10 seconds) trace-cmd-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/trace-cmd-1.2.20120606git8266dff/trace-blk-hack.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. trace-cmd-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/trace-cmd-1.2.20120606git8266dff/trace-options.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. trace-cmd-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/trace-cmd-1.2.20120606git8266dff/trace-recorder.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. trace-cmd-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/trace-cmd-1.2.20120606git8266dff/plugin_blk.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. trace-cmd.spec:16: W: macro-in-comment %{version} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. trace-cmd.spec:16: W: macro-in-comment %{checkout} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. trace-cmd.spec:16: W: macro-in-comment %{version} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. trace-cmd.spec:16: W: macro-in-comment %{checkout} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. trace-cmd.spec:16: W: macro-in-comment %{git_commit} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. trace-cmd.spec: W: invalid-url Source0: trace-cmd-1.2.20120606git8266dff.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL. 7 packages and 1 specfiles checked; 12 errors, 37 warnings. Remove the executable bit from /usr/share/kernelshark/html/index.html. The package name must not be repeated in the summary. Just write "User interface to Ftrace". The initial cleaning of buildroot in %install, the %clean section and the %defattr line are obsolete, unless you plan to provide your package for EPEL5. In this case, you have to add a BuildRoot definition. No worries about the incorrect FSF addresses. Just warn the upstream people about them. The macro-in-comment warnings could be avoided if you escape the macros with a double %%. Is kernelshark depending on the main package? If yes, add the appropriate line: Requires: trace-cmd%{?_isa} = %{version}-%{release} Even when it doesn't require it directly, you should add this line to make sure that users get a working trace-cmd stack when they install kernelshark. Current runtime dependencies are: $ rpm -qpR kernelshark-1.2-1.20120606git8266dff.fc17.x86_64.rpm ld-linux-x86-64.so.2()(64bit) ld-linux-x86-64.so.2(GLIBC_2.3)(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit) libc.so.6(GLIBC_2.15)(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libcairo.so.2()(64bit) libdl.so.2()(64bit) libdl.so.2(GLIBC_2.2.5)(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.2.5)(64bit) librt.so.1()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH) rpmlib(PayloadIsXz) <= 5.2-1
All of the above fixed. Spec location the same, new SRPM at http://jstanley.fedorapeople.org/trace-cmd-1.2-3.20120606git8266dff.fc16.src.rpm
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4465084 $ rpmlint -i -v * kernelshark.i686: I: checking kernelshark.i686: W: spelling-error Summary(en_US) cmd -> cm, cad, cod The value of this tag appears to be misspelled. Please double-check. kernelshark.i686: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end The value of this tag appears to be misspelled. Please double-check. kernelshark.i686: W: spelling-error %description -l en_US cmd -> cm, cad, cod The value of this tag appears to be misspelled. Please double-check. kernelshark.i686: I: checking-url http://git.kernel.org/?p=linux/kernel/git/rostedt/trace-cmd.git;a=summary (timeout 10 seconds) kernelshark.i686: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. kernelshark.i686: W: no-manual-page-for-binary trace-graph Each executable in standard binary directories should have a man page. kernelshark.i686: W: no-manual-page-for-binary kernelshark Each executable in standard binary directories should have a man page. kernelshark.i686: W: no-manual-page-for-binary trace-view Each executable in standard binary directories should have a man page. kernelshark.x86_64: I: checking kernelshark.x86_64: W: spelling-error Summary(en_US) cmd -> cm, cad, cod The value of this tag appears to be misspelled. Please double-check. kernelshark.x86_64: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end The value of this tag appears to be misspelled. Please double-check. kernelshark.x86_64: W: spelling-error %description -l en_US cmd -> cm, cad, cod The value of this tag appears to be misspelled. Please double-check. kernelshark.x86_64: I: checking-url http://git.kernel.org/?p=linux/kernel/git/rostedt/trace-cmd.git;a=summary (timeout 10 seconds) kernelshark.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. kernelshark.x86_64: W: no-manual-page-for-binary trace-graph Each executable in standard binary directories should have a man page. kernelshark.x86_64: W: no-manual-page-for-binary kernelshark Each executable in standard binary directories should have a man page. kernelshark.x86_64: W: no-manual-page-for-binary trace-view Each executable in standard binary directories should have a man page. trace-cmd.src: I: checking trace-cmd.src: W: spelling-error %description -l en_US debugfs -> debugs, debuggers The value of this tag appears to be misspelled. Please double-check. trace-cmd.src: I: checking-url http://git.kernel.org/?p=linux/kernel/git/rostedt/trace-cmd.git;a=summary (timeout 10 seconds) trace-cmd.src: W: invalid-url Source0: trace-cmd-1.2.20120606git8266dff.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL. trace-cmd.i686: I: checking trace-cmd.i686: W: spelling-error %description -l en_US debugfs -> debugs, debuggers The value of this tag appears to be misspelled. Please double-check. trace-cmd.i686: I: checking-url http://git.kernel.org/?p=linux/kernel/git/rostedt/trace-cmd.git;a=summary (timeout 10 seconds) trace-cmd.i686: E: incorrect-fsf-address /usr/share/doc/trace-cmd-1.2/COPYING.LIB The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. trace-cmd.x86_64: I: checking trace-cmd.x86_64: W: spelling-error %description -l en_US debugfs -> debugs, debuggers The value of this tag appears to be misspelled. Please double-check. trace-cmd.x86_64: I: checking-url http://git.kernel.org/?p=linux/kernel/git/rostedt/trace-cmd.git;a=summary (timeout 10 seconds) trace-cmd.x86_64: E: incorrect-fsf-address /usr/share/doc/trace-cmd-1.2/COPYING.LIB The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. trace-cmd-debuginfo.i686: I: checking trace-cmd-debuginfo.i686: I: checking-url http://git.kernel.org/?p=linux/kernel/git/rostedt/trace-cmd.git;a=summary (timeout 10 seconds) trace-cmd-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/trace-cmd-1.2.20120606git8266dff/trace-blk-hack.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. trace-cmd-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/trace-cmd-1.2.20120606git8266dff/trace-options.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. trace-cmd-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/trace-cmd-1.2.20120606git8266dff/trace-recorder.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. trace-cmd-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/trace-cmd-1.2.20120606git8266dff/plugin_blk.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. trace-cmd-debuginfo.x86_64: I: checking trace-cmd-debuginfo.x86_64: I: checking-url http://git.kernel.org/?p=linux/kernel/git/rostedt/trace-cmd.git;a=summary (timeout 10 seconds) trace-cmd-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/trace-cmd-1.2.20120606git8266dff/trace-blk-hack.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. trace-cmd-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/trace-cmd-1.2.20120606git8266dff/trace-options.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. trace-cmd-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/trace-cmd-1.2.20120606git8266dff/trace-recorder.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. trace-cmd-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/trace-cmd-1.2.20120606git8266dff/plugin_blk.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. trace-cmd.spec: W: invalid-url Source0: trace-cmd-1.2.20120606git8266dff.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL. 7 packages and 1 specfiles checked; 10 errors, 19 warnings. Nothing of interest so far. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. [+] MUST: The License field in the package spec file must match the actual license. GPLv2 and LGPLv2 [+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. $ sha256sum * c4a591538f717313b506b452168625413b968a147d015cb8d34c103d411e2a24 trace-cmd-1.2.20120606git8266dff.tar.gz c4a591538f717313b506b452168625413b968a147d015cb8d34c103d411e2a24 trace-cmd-1.2.20120606git8266dff.tar.gz.orig [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [.] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [+] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. [.] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. [.] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [+] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations) [.] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [.] MUST: Static libraries must be in a -static package. [.] MUST: Development files must be in a -devel package. [.] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} [.] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [+] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. [+] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [.] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses Mock anyway). [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [.] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. [+] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. [+] SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. ---------------- PACKAGE APPROVED ---------------- However, %defattr(-,root,root,-) is obsolete for ages. Please remove that line before you importing it to Git.
New Package SCM Request ======================= Package Name: trace-cmd Short Description: Interface to Ftrace Owners: jstanley Branches: f17 f18
Git done (by process-git-requests).
trace-cmd-1.2-4.20120606git8266dff.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/trace-cmd-1.2-4.20120606git8266dff.fc17
trace-cmd-1.2-4.20120606git8266dff.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/trace-cmd-1.2-4.20120606git8266dff.fc18
trace-cmd-1.2-4.20120606git8266dff.fc18 has been pushed to the Fedora 18 testing repository.
trace-cmd-1.2-4.20120606git8266dff.fc17 has been pushed to the Fedora 17 stable repository.