Bug 681877 - VDSM - Storage: No rollback from "MkfsError: Cannot create filesystem on device"
Summary: VDSM - Storage: No rollback from "MkfsError: Cannot create filesystem on device"
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: vdsm
Version: 6.1
Hardware: Unspecified
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Erez Shinan
QA Contact: yeylon@redhat.com
URL:
Whiteboard: storage
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-03 13:57 UTC by Daniel Paikov
Modified: 2016-04-18 06:38 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-05-22 08:10:31 UTC
Target Upstream Version:


Attachments (Terms of Use)
vdsm.log (135.71 KB, application/x-gzip)
2011-03-03 13:57 UTC, Daniel Paikov
no flags Details

Description Daniel Paikov 2011-03-03 13:57:27 UTC
Created attachment 482085 [details]
vdsm.log

* Domain creation failed for "MkfsError: Cannot create filesystem on device".
* Devices were left dirty, even though they are not used.
* Devices should be cleaned, so they could be re-used for future domains.

Comment 2 Ayal Baron 2011-03-08 11:07:03 UTC
Paikov, what's the difference between this bug and "682513 - VDSM - Storage: VDSM should work with new mke2fs default of discard=enabled" ???

Comment 4 Erez Shinan 2011-03-29 14:49:20 UTC
How do I reproduce this bug?

Comment 5 Daniel Paikov 2011-03-29 14:54:32 UTC
(In reply to comment #4)
> How do I reproduce this bug?

It happens every time when using the storage at Westford: http://10.16.45.61

Comment 6 Erez Shinan 2011-03-29 15:08:44 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > How do I reproduce this bug?
> 
> It happens every time when using the storage at Westford: http://10.16.45.61

Can you specify which actions produced this error?

Comment 7 Erez Shinan 2011-05-22 08:10:31 UTC
While some errors are susceptible to rollback, reliably rollbacking from any error that might arise in blockSD.create is unfortunately impossible. Hence, I claim it's a futile task in the first place.

There is, however, a mechanism for handling errors exactly such as this: VDSM uses the domain tags to communicate whether the domain is ready or not (RHAT_storage_domain_UNREADY). While that tag is set the VG should not be used, and should be considered as marked for deletion.

This tagging mechanism seems to work reliably for failures in mkfs, therefor this doesn't appear to be a bug.

Comment 8 Yaniv Kaul 2011-05-22 08:53:57 UTC
Is a normal, usable error propagated back to the user about that VG? With some identifier of it?

Comment 9 Erez Shinan 2011-05-22 09:04:50 UTC
Yes, the function raises a VolumeGroupUninitialized exception with the name of the VG.


Note You need to log in before you can comment on or make changes to this bug.