Bug 682949 - Review Request: perl-Test-Fixme - Check code for FIXMEs
Summary: Review Request: perl-Test-Fixme - Check code for FIXMEs
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Iain Arnell
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-08 05:09 UTC by Ruediger Landmann
Modified: 2011-03-14 06:46 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-03-14 06:46:38 UTC
Type: ---
Embargoed:
iarnell: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Ruediger Landmann 2011-03-08 05:09:55 UTC
Spec URL: 
http://rlandmann.fedorapeople.org/packages/perl-Test-Fixme.spec

SRPM URL:
http://rlandmann.fedorapeople.org/packages/perl-Test-Fixme-0.04-1.fc14.src.rpm

Description:
When coding it is common to come up against problems that need to be
addressed but that are not a big deal at the moment. What generally happens
is that the coder adds comments and marks them FIXME.

Test::Fixme allows you to add a test file that ensures that none of these 
get forgotten in the module.

rpmlint output:
$ rpmlint SPECS/perl-Test-Fixme.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint SRPMS/perl-Test-Fixme-0.04-1.fc14.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint RPMS/noarch/perl-Test-Fixme-0.04-1.fc14.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

scratchbuild in Koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2892937

Comment 1 Iain Arnell 2011-03-12 10:20:08 UTC
A nice clean package with no problems.

APPROVED.


koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2892937

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
49bd4e4dbcdd128246a4b1ced4cf0d8422316f07 Test-Fixme-0.04.tar.gz
49bd4e4dbcdd128246a4b1ced4cf0d8422316f07 Test-Fixme-0.04.tar.gz.srpm

Final provides / requires are sane:

======> perl-Test-Fixme-0.04-1.fc16.noarch.rpm <======
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides
perl(Test::Fixme) = 0.04
perl-Test-Fixme = 0.04-1.fc16
====> requires
perl(Carp)  
perl(Exporter)  
perl(ExtUtils::MakeMaker)  
perl(File::Finder)  
perl(File::Slurp)  
perl(:MODULE_COMPAT_5.12.3)  
perl(strict)  
perl(Test::Builder)  
perl(Test::More)  
perl(vars)  
perl(warnings)  
====> obsoletes
====> conflicts

======> perl-Test-Fixme-0.04-1.fc16.src.rpm <======
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides
====> requires
perl(ExtUtils::MakeMaker)  
perl(File::Finder)  
perl(File::Slurp)  
perl(Test::Builder)  
perl(Test::More)  
====> obsoletes
====> conflicts


====> mock install
INFO: mock.py version 1.1.9 starting...
State Changed: init plugins
INFO: selinux enabled
State Changed: start
Mock Version: 1.1.9
INFO: Mock Version: 1.1.9
State Changed: lock buildroot
INFO: installing package(s): perl-Test-Fixme-0.04-1.fc16.noarch.rpm
INFO: 
================================================================================
 Package                 Arch   Version           Repository               Size
================================================================================
Installing:
 perl-Test-Fixme         noarch 0.04-1.fc16       /perl-Test-Fixme-0.04-1.fc16.noarch
                                                                           12 k
Installing for dependencies:
 perl-CPAN               noarch 1.9402-154.fc16   fedora                  246 k
 perl-Digest-SHA         x86_64 1:5.47-154.fc16   fedora                   62 k
 perl-ExtUtils-MakeMaker noarch 6.56-154.fc16     fedora                  289 k
 perl-ExtUtils-ParseXS   noarch 1:2.2206-154.fc16 fedora                   44 k
 perl-File-Finder        noarch 0.53-3.fc16       fedora                   26 k
 perl-File-Slurp         noarch 9999.13-10.fc15   fedora                   32 k
 perl-Test-Harness       noarch 3.17-154.fc16     fedora                  239 k
 perl-Test-Simple        noarch 0.98-1.fc16       fedora                  117 k
 perl-Text-Glob          noarch 0.09-1.fc16       fedora                  9.8 k
 perl-devel              x86_64 4:5.12.3-154.fc16 fedora                  448 k
 python                  x86_64 2.7.1-6.fc15      fedora                   73 k
 systemtap-sdt-devel     x86_64 1.4-5.fc16        fedora                   41 k

Transaction Summary
================================================================================
Install      13 Package(s)

Total size: 1.6 M
Total download size: 26 k
Installed size: 4.2 M

Installed:
  perl-Test-Fixme.noarch 0:0.04-1.fc16                                          

Dependency Installed:
  perl-CPAN.noarch 0:1.9402-154.fc16                                            
  perl-Digest-SHA.x86_64 1:5.47-154.fc16                                        
  perl-ExtUtils-MakeMaker.noarch 0:6.56-154.fc16                                
  perl-ExtUtils-ParseXS.noarch 1:2.2206-154.fc16                                
  perl-File-Finder.noarch 0:0.53-3.fc16                                         
  perl-File-Slurp.noarch 0:9999.13-10.fc15                                      
  perl-Test-Harness.noarch 0:3.17-154.fc16                                      
  perl-Test-Simple.noarch 0:0.98-1.fc16                                         
  perl-Text-Glob.noarch 0:0.09-1.fc16                                           
  perl-devel.x86_64 4:5.12.3-154.fc16                                           
  python.x86_64 0:2.7.1-6.fc15                                                  
  systemtap-sdt-devel.x86_64 0:1.4-5.fc16                                       


State Changed: unlock buildroot

Comment 2 Ruediger Landmann 2011-03-13 23:17:13 UTC
Thanks Iain!

New Package SCM Request
=======================
Package Name: perl-Test-Fixme
Short Description: Check code for FIXMEs
Owners: rlandmann
Branches: f14 f15 el6
InitialCC: perl-sig

Comment 3 Jason Tibbitts 2011-03-14 01:05:05 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.