Bug 682963 - Review Request: perl-JSON-Util - Easy and portable encode/decode of JSON
Summary: Review Request: perl-JSON-Util - Easy and portable encode/decode of JSON
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Iain Arnell
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-08 06:17 UTC by Ruediger Landmann
Modified: 2011-03-14 06:46 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-03-14 06:46:46 UTC
Type: ---
Embargoed:
iarnell: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Ruediger Landmann 2011-03-08 06:17:49 UTC
Spec URL:
http://rlandmann.fedorapeople.org/packages/perl-JSON-Util.spec

SRPM URL:
http://rlandmann.fedorapeople.org/packages/perl-JSON-Util-0.05-1.fc14.src.rpm

Description:
Provides methods to encode and decode JSON.

rpmlint output:
$ rpmlint SPECS/perl-JSON-Util.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint SRPMS/perl-JSON-Util-0.05-1.fc14.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint RPMS/noarch/perl-JSON-Util-0.05-1.fc14.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

scratchbuild in Koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2893159

Comment 1 Iain Arnell 2011-03-12 10:14:56 UTC
You should BuildRequire perl(Test::Distribution) to enable more tests, and it's
good to see that you've already submitted perl-Test-Fixme for review.

APPROVED.


koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2893159

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
79e3eeebf150cbad64249ba99646e11674b9edfd JSON-Util-0.05.tar.gz
79e3eeebf150cbad64249ba99646e11674b9edfd JSON-Util-0.05.tar.gz.srpm

Final provides / requires are sane:

======> perl-JSON-Util-0.05-1.fc16.noarch.rpm <======
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides
perl(JSON::Util) = 0.05
perl-JSON-Util = 0.05-1.fc16
====> requires
perl >= 1:5.010
perl(Carp)  
perl(feature)  
perl(IO::Any)  
perl(JSON::XS)  
perl(:MODULE_COMPAT_5.12.3)  
perl(Scalar::Util)  
perl(strict)  
perl(warnings)  
====> obsoletes
====> conflicts

======> perl-JSON-Util-0.05-1.fc16.src.rpm <======
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides
====> requires
perl(IO::Any)  
perl(JSON::XS)  
perl(Module::Build)  
perl(Test::Differences)  
perl(Test::Exception)  
perl(Test::More)  
====> obsoletes
====> conflicts


====> mock install
INFO: mock.py version 1.1.9 starting...
State Changed: init plugins
INFO: selinux enabled
State Changed: start
Mock Version: 1.1.9
INFO: Mock Version: 1.1.9
State Changed: lock buildroot
INFO: installing package(s): perl-JSON-Util-0.05-1.fc16.noarch.rpm
INFO: 
================================================================================
 Package          Arch   Version       Repository                          Size
================================================================================
Installing:
 perl-JSON-Util   noarch 0.05-1.fc16   /perl-JSON-Util-0.05-1.fc16.noarch  10 k
Installing for dependencies:
 perl-IO-Any      noarch 0.04-2.fc16   fedora                              12 k
 perl-IO-String   noarch 1.08-12.fc15  fedora                              15 k
 perl-IO-stringy  noarch 2.110-15.fc15 fedora                              69 k
 perl-JSON-XS     x86_64 1:2.30-2.fc15 fedora                              94 k
 perl-common-sense
                  noarch 3.3-2.fc15    fedora                              23 k

Transaction Summary
================================================================================
Install       6 Package(s)

Total size: 223 k
Total download size: 12 k
Installed size: 451 k

Installed:
  perl-JSON-Util.noarch 0:0.05-1.fc16                                           

Dependency Installed:
  perl-IO-Any.noarch 0:0.04-2.fc16        perl-IO-String.noarch 0:1.08-12.fc15 
  perl-IO-stringy.noarch 0:2.110-15.fc15  perl-JSON-XS.x86_64 1:2.30-2.fc15    
  perl-common-sense.noarch 0:3.3-2.fc15  


State Changed: unlock buildroot

Comment 2 Ruediger Landmann 2011-03-13 23:16:07 UTC
Thanks Iain!

New Package SCM Request
=======================
Package Name: perl-JSON-Util
Short Description: Easy and portable encode/decode of JSON
Owners: rlandmann
Branches: f14 f15 el6
InitialCC: perl-sig

Comment 3 Jason Tibbitts 2011-03-14 01:05:22 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.