Bug 683182 - virtinst volume creation doesn't raise an error if it fails
Summary: virtinst volume creation doesn't raise an error if it fails
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: python-virtinst
Version: 6.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Cole Robinson
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-08 19:00 UTC by Cole Robinson
Modified: 2011-06-10 02:33 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
When specifying a wrong volume format type an error message would not display. This change informs the user by raising the appropriate error message when the storage pool cannot find the appropriate volume.
Clone Of:
Environment:
Last Closed: 2011-05-19 13:43:33 UTC
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2011:0636 0 normal SHIPPED_LIVE python-virtinst bug fix and enhancement update 2011-05-18 17:55:48 UTC

Description Cole Robinson 2011-03-08 19:00:19 UTC
We aren't properly raising error messages if volume creation fails.

See https://bugzilla.redhat.com/show_bug.cgi?id=673028 as an example.

Fixed upstream:

http://hg.fedorahosted.org/hg/python-virtinst/rev/6927884e174e

Comment 1 Cole Robinson 2011-03-10 16:38:54 UTC
Fixed in python-virtinst-0.500.5-2.el6

Comment 3 Nan Zhang 2011-03-18 08:58:21 UTC
Verified with python-virtinst-0.500.5-2.el6.noarch, it now can raise the error messages if specifying a wrong volume format type. Move to VERIFIED.

# virt-install -n test1 -r 512 --cdrom /var/lib/libvirt/boot/Fedora-14-i686-Live-Desktop.iso --vcpus=2 --disk path=/var/lib/libvirt/images/test1.img,size=5,format=asdf --hvm --accelerate --os-variant=virtio26 --network network:default --noreboot --vnc

Starting install...
ERROR    internal error unknown disk format 'asdf' for /var/lib/libvirt/images/test1.img
Domain installation does not appear to have been successful.
If it was, you can restart your domain by running:
  virsh --connect qemu:///system start test1
otherwise, please restart your installation.

Comment 4 zhe peng 2011-04-18 06:40:07 UTC
verified this bug with:
Linux localhost.localdomain 2.6.32-130.el6.x86_64 #1 SMP Tue Apr 5 19:58:31 EDT
2011 x86_64 x86_64 x86_64 GNU/Linux

python-virtinst-0.500.5-3.el6.noarch
libvirt-0.8.7-17.el6.x86_64

passed.

Comment 6 Michael Hideo 2011-05-12 23:23:15 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
* When specifying a wrong volume format type an error message would not display. This change informs the user by raising the appropriate error message when the storage pool cannot find the appropriate volume. (BZ#683182)

Comment 7 Michael Hideo 2011-05-16 21:39:15 UTC
    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1 +1 @@
-* When specifying a wrong volume format type an error message would not display. This change informs the user by raising the appropriate error message when the storage pool cannot find the appropriate volume. (BZ#683182)+When specifying a wrong volume format type an error message would not display. This change informs the user by raising the appropriate error message when the storage pool cannot find the appropriate volume.

Comment 8 errata-xmlrpc 2011-05-19 13:43:33 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0636.html


Note You need to log in before you can comment on or make changes to this bug.