Bug 683554 - Confusing `-r' option at setquota/edquota grace/period setting
Summary: Confusing `-r' option at setquota/edquota grace/period setting
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: quota
Version: 6.1
Hardware: All
OS: Linux
low
medium
Target Milestone: rc
: ---
Assignee: Petr Pisar
QA Contact: Branislav Blaškovič
URL: http://sourceforge.net/tracker/?func=...
Whiteboard:
Depends On:
Blocks: 836160
TreeView+ depends on / blocked
 
Reported: 2011-03-09 17:20 UTC by Petr Pisar
Modified: 2012-11-19 13:31 UTC (History)
4 users (show)

Fixed In Version: quota-3.17-18.el6
Doc Type: Bug Fix
Doc Text:
Cause: Using `-r' option at setquota or edquota command when setting grace times for NFS-mounted file system. Consequence: The grace times are not set despite no error is reported by the command. Fix: Setting grace times over network has been disable because underlying remote procedure call protocol does not support it. Manual pages and usage message have been corrected not to promote `-r' option in `-T' and '-t' synopsis variants. setquota and edquota will report error if `-r' option is used with '-t' or `-T' option now. Result: It's not possible to call edquota or setquota with `-r' option when setting grace times. An error is raised in that case.
Clone Of: 638578
Environment:
Last Closed: 2012-11-19 13:31:49 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2012:1472 0 normal SHIPPED_LIVE quota bug fix update 2012-11-19 18:31:11 UTC

Description Petr Pisar 2011-03-09 17:20:50 UTC 
+++ This bug was initially created as a clone of Bug #638578 +++

[...]
There is no `-r' option described in contrast to setquota(8) manual page and that RPC quota manipulation has been enabled as fix of bug #469753.
[...]

--- Additional comment from ppisar on 2011-03-09 17:08:02 GMT ---

It turned out the bug is not only misleading manual or usage output.

The problem is setting grace time over RPC is not supported by quota RPC protocol and setting grace period over RPC is not reliable (because of poor RPC protocol).

Upstream removed `-r' and `-m' options from setquota/edquota usage and manual at `-t' and `-T' invocations and disallowed those tools to set the grace values over RPC completely. Commits:

8d4c4a761c27a81d96ae8c49e1b8d32d66b6751e
  (Fix synopsis and properly report errors during remote grace period setting)
418a9f20ee870953790b4331327ccb24ca8f1e47
 (Forbid grace time setting over RPC)

Small bug has been introduced which can be solved by on-liner:

--- a/setquota.c
+++ b/setquota.c
@@ -379,7 +379,7 @@ static int setgraces(struct quota_handle **handles)
        int i, ret = 0;
 
        for (i = 0; handles[i]; i++) {
-               if (handles[i]->qh_ops->write_info) {
+               if (!handles[i]->qh_ops->write_info) {
                        errstr(_("Setting grace period on %s is not supported.\n
                        ret = -1;
                        continue;

Because setting grace period/times remotely has never worked, I'm going to back-port these patches.
Comment 1 Petr Pisar 2011-04-13 07:54:09 UTC 
The on-liner has been accepted by upstream as commit bfb0f6643325937698e5b185cd1a0da1923e385f.
Comment 3 RHEL Program Management 2011-07-05 23:41:50 UTC 
This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unfortunately unable to
address this request at this time. Red Hat invites you to
ask your support representative to propose this request, if
appropriate and relevant, in the next release of Red Hat
Enterprise Linux. If you would like it considered as an
exception in the current release, please ask your support
representative.
Comment 5 Suzanne Logcher 2012-02-14 23:07:52 UTC 
This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unfortunately unable to
address this request at this time. Red Hat invites you to
ask your support representative to propose this request, if
appropriate and relevant, in the next release of Red Hat
Enterprise Linux. If you would like it considered as an
exception in the current release, please ask your support
representative.
Comment 14 errata-xmlrpc 2012-11-19 13:31:49 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-1472.html
Note You need to log in before you can comment on or make changes to this bug.