Spec URL: http://toshio.fedorapeople.org/packages/python-unicodenazi.spec SRPM URL: http://toshio.fedorapeople.org/packages/python-unicodenazi-1.1-1.fc14.src.rpm Description: A common source of unicode issues in python2 is that code mixes str and unicode and is valid for the cases the author tests for (because they only test with ASCII) but then throws an error when the code is used with non-ASCII strings. If enabled unicodenazi will complain when this mixing of unicode and byte str occurs. It's annoying as hell, has a huge runtime impact on performance, and will also complain about most of the stuff in the Python standard library. But it will point out some areas of your code that may traceback in python2 when given different data and make it easier to migrate to python3 where unicode and bytes no longer interoperate.
I will review this package
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated [x] : MUST - Package successfully compiles and builds into binary rpms on at least one supported architecture. [x] : MUST - Each %files section contains %defattr [x] : MUST - Spec file lacks Packager, Vendor, PreReq tags. [x] : MUST - Package does not contain any libtool archives (.la) [x] : MUST - Package use %makeinstall only when make install DESTDIR=... doesn't work. [x] : MUST - Package is named according to the Package Naming Guidelines. [x] : MUST - Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package : f9b3d2c25c7887df643e67e2c8d99c45 MD5SUM upstream package : f9b3d2c25c7887df643e67e2c8d99c45 [x] : MUST - Spec file name must match the spec package %{name}, in the format %{name}.spec. [-] : MUST - %config files are marked noreplace or the reason is justified. [-] : MUST - Package contains a properly installed %{name}.desktop using desktop-file-install file if it is a GUI application. [-] : MUST - Fully versioned dependency in subpackages, if present. [-] : MUST - Header files in -devel subpackage, if present. [-] : MUST - ldconfig called in %post and %postun if required. [-] : MUST - License file installed when any subpackage combination is installed. [-] : MUST - The spec file handles locales properly. [-] : MUST - No %config files under /usr. [-] : MUST - Development .so files in -devel subpackage, if present. [-] : MUST - Static libraries in -static subpackage, if present. [!] : MUST - Rpmlint output is silent. rpmlint python-unicodenazi-1.1-1.fc16.noarch.rpm ================================================================================ python-unicodenazi.noarch: W: spelling-error Summary(en_US) unicode -> Unicode, uni code, uni-code python-unicodenazi.noarch: W: spelling-error Summary(en_US) bytestring -> byte string, byte-string, lutestring python-unicodenazi.noarch: W: spelling-error Summary(en_US) comparisions -> comparisons, comparison, comparatives python-unicodenazi.noarch: W: spelling-error %description -l en_US unicode -> Unicode, uni code, uni-code python-unicodenazi.noarch: W: spelling-error %description -l en_US runtime -> run time, run-time, runtish python-unicodenazi.noarch: W: spelling-error %description -l en_US traceback -> trace back, trace-back, traceable python-unicodenazi.noarch: W: spelling-error %description -l en_US interoperate -> inter operate, inter-operate, interoperable 1 packages and 0 specfiles checked; 0 errors, 7 warnings. ================================================================================ rpmlint python-unicodenazi-1.1-1.fc16.src.rpm ================================================================================ python-unicodenazi.src: W: spelling-error Summary(en_US) unicode -> Unicode, uni code, uni-code python-unicodenazi.src: W: spelling-error Summary(en_US) bytestring -> byte string, byte-string, lutestring python-unicodenazi.src: W: spelling-error Summary(en_US) comparisions -> comparisons, comparison, comparatives python-unicodenazi.src: W: spelling-error %description -l en_US unicode -> Unicode, uni code, uni-code python-unicodenazi.src: W: spelling-error %description -l en_US runtime -> run time, run-time, runtish python-unicodenazi.src: W: spelling-error %description -l en_US traceback -> trace back, trace-back, traceable python-unicodenazi.src: W: spelling-error %description -l en_US interoperate -> inter operate, inter-operate, interoperable 1 packages and 0 specfiles checked; 0 errors, 7 warnings. ================================================================================ [x] : MUST - Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-] : MUST - %build honors applicable compiler flags or justifies otherwise. [x] : MUST - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x] : MUST - Package contains no bundled libraries. [x] : MUST - Changelog in prescribed format. [x] : MUST - Sources contain only permissible code or content. [-] : MUST - Macros in Summary, %description expandable at SRPM build time. [x] : MUST - Package requires other packages for directories it uses. [x] : MUST - Package uses nothing in %doc for runtime. [x] : MUST - Package is not known to require ExcludeArch. [x] : MUST - Permissions on files are set properly. [x] : MUST - Package does not contain duplicates in %files. [-] : MUST - Large documentation files are in a -doc subpackage, if required. [-] : MUST - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] : MUST - License field in the package spec file matches the actual license. [x] : MUST - Package consistently uses macros. instead of hard-coded directory names. [x] : MUST - Package meets the Packaging Guidelines. [x] : MUST - Package does not genrate any conflict. [x] : MUST - Package does not contains kernel modules. [x] : MUST - Package contains no static executables. [x] : MUST - Package obeys FHS, except libexecdir and /usr/target. [x] : MUST - Package must own all directories that it creates. [x] : MUST - Package does not own files or directories owned by other packages. [x] : MUST - Package installs properly. [x] : MUST - Rpath absent or only used for internal libs. [x] : MUST - Package is not relocatable. [x] : MUST - Requires correct, justified where necessary. [x] : MUST - Spec file is legible and written in American English. [-] : MUST - Package contains a SysV-style init script if in need of one. [x] : MUST - File names are valid UTF-8. [-] : MUST - Useful -debuginfo package or justification otherwise. [x] : SHOULD - Reviewer should test that the package builds in mock. [x] : SHOULD - Dist tag is present. [x] : SHOULD - SourceX / PatchY prefixed with %{name}. [x] : SHOULD - SourceX is a working URL. [x] : SHOULD - Spec use %global instead of %define. [-] : SHOULD - Uses parallel make. [-] : SHOULD - The placement of pkgconfig(.pc) files are correct. [!] : SHOULD - If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x] : SHOULD - No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x] : SHOULD - Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [?] : SHOULD - Package functions as described. [x] : SHOULD - Latest version is packaged. [x] : SHOULD - Package does not include license text files separate from upstream. [-] : SHOULD - Man pages included for all executables. [-] : SHOULD - Patches link to upstream bugs/comments/lists or are otherwise justified. [-] : SHOULD - Scriptlets must be sane, if used. [!] : SHOULD - Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?] : SHOULD - Package should compile and build into binary rpms on all supported architectures. [x] : SHOULD - %check is present and all tests pass. [x] : SHOULD - Packages should try to preserve timestamps of original installed files. Issues: None APPROVED
Thanks Tim! New Package SCM Request ======================= Package Name: python-unicodenazi Short Description: Module that finds unicode/bytestring comparisons and other problems Owners: toshio dmalcolm Branches: f14 f15 el5 el6 InitialCC:
Git done (by process-git-requests).
python-unicodenazi-1.1-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/python-unicodenazi-1.1-1.fc14
python-unicodenazi-1.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-unicodenazi-1.1-1.el6
python-unicodenazi-1.1-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/python-unicodenazi-1.1-1.fc15
python-unicodenazi-1.1-1.fc15 has been pushed to the Fedora 15 testing repository.
python-unicodenazi-1.1-1.fc15 has been pushed to the Fedora 15 stable repository.