RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 684227 - Update RHEL 6 System Tap Beginners Guide futexes.stp example script to account for FUTEX_PRIVATE_FLAG
Summary: Update RHEL 6 System Tap Beginners Guide futexes.stp example script to accoun...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: systemtap
Version: 6.3
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: rc
: ---
Assignee: Frank Ch. Eigler
QA Contact: qe-baseos-tools-bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-11 14:31 UTC by Kim van der Riet
Modified: 2011-12-06 15:17 UTC (History)
3 users (show)

Fixed In Version: systemtap-1.6-1.el6
Doc Type: Bug Fix
Doc Text:
Cause RHEL6 kernels have additional futex flags, FUTEX_PRIVATE_FLAG and FUTEX_CLOCK_REALTIME in the syscall.futex $op argument. Consequence Without filtering out FUTEX_PRIVATE_FLAG and FUTEX_CLOCK_REALTIME the script does not record data on RHEL6. Fix The futexes.stp added filtering for FUTEX_PRIVATE_FLAG and FUTEX_CLOCK_REALTIME. Result The futexes.stp example now runs correctly on RHEL6.
Clone Of:
Environment:
Last Closed: 2011-12-06 15:17:42 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Modified script (1.13 KB, text/plain)
2011-03-11 14:35 UTC, Kim van der Riet
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2011:1517 0 normal SHIPPED_LIVE systemtap bug fix and enhancement update 2011-12-06 00:50:46 UTC

Description Kim van der Riet 2011-03-11 14:31:14 UTC
The RHEL 6 System Tap Beginners Guide in section 4.4 "Identifying Contended User-Space Locks" includes an example script futexes.stp. However, this script will not return any results as written when run on RHEL 6, as it has not accounted for the FUTEX_PRIVATE_FLAG which newer kernels now use.

The update is fairly trivial, but the examples in our current documentation should work out-of-the-box.

Perhaps there are other example scripts that need updating too.

Comment 2 Kim van der Riet 2011-03-11 14:35:15 UTC
Created attachment 483740 [details]
Modified script

The attached script works ok on RHEL 6 (although it is likely not very elegantly written and can be cleaned up).

Comment 4 Frank Ch. Eigler 2011-03-11 15:45:24 UTC
Kim, Are you sure that the example shouldn't mask off the PRIVATE flag, as in

   if ((op & ~FUTEX_PRIVATE_FLAG) != FUTEX_WAIT) next;

Comment 5 Kim van der Riet 2011-03-11 16:05:30 UTC
I agree, that is probably a more correct implementation.

Comment 6 Frank Ch. Eigler 2011-03-24 17:35:11 UTC
upstream commits c085f1feb2 and 148d3a367 should correct this.

Comment 11 William Cohen 2011-11-09 16:29:23 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause
    RHEL6 kernels have additional futex flags, FUTEX_PRIVATE_FLAG and
    FUTEX_CLOCK_REALTIME in the syscall.futex $op argument.
Consequence
    Without filtering out FUTEX_PRIVATE_FLAG and
    FUTEX_CLOCK_REALTIME the script does not record data on RHEL6.
Fix
    The futexes.stp added filtering for FUTEX_PRIVATE_FLAG and
    FUTEX_CLOCK_REALTIME.
Result
    The futexes.stp example now runs correctly on RHEL6.

Comment 12 errata-xmlrpc 2011-12-06 15:17:42 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1517.html


Note You need to log in before you can comment on or make changes to this bug.