Bug 684464 - packagekitd crash
Summary: packagekitd crash
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: PackageKit
Version: 14
Hardware: i686
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Richard Hughes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 700929 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-12 20:13 UTC by Brandon Bensel
Modified: 2011-09-05 08:45 UTC (History)
5 users (show)

Fixed In Version: PackageKit-0.6.12-4.fc14
Clone Of:
Environment:
Last Closed: 2011-09-02 05:30:52 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
The final messages of packagekitd --verbose before a crash, and the backtrace. (3.88 KB, text/plain)
2011-03-12 20:13 UTC, Brandon Bensel
no flags Details

Description Brandon Bensel 2011-03-12 20:13:24 UTC
Created attachment 483925 [details]
The final messages of packagekitd --verbose before a crash, and the backtrace.

Description of problem:
Yet another update-while-running-Firefox packagekitd crash.

Version-Release number of selected component (if applicable):
benselb@kartli:~$ /usr/libexec/packagekitd --version                           
Version 0.6.12

How reproducible:
It will happen about 80% of the time, and different problems will occur occasionally with the same steps another 10% of the time.

Steps to Reproduce:
1. Run Firefox and leave it open.
2. Try to update from gpk-update-viewer.
3. Go to step 2 if packagekitd hasn't crashed yet.
  
Actual results:
packagekitd crashes, gpk-update-viewer shows that updates cannot proceed because something is running (but just gives garbage for details), and any future invocation of gpk-update-viewer appears to hang checking for running processes because packagekitd is not running.

Expected results:
To simply be notified that Firefox is running and updates cannot proceed. It would also be nice if gpk-update-viewer would clearly let the user know when packagekitd isn't running; hanging on an arbitrary step of the process is not a good indication of what went wrong, nor is it clear that it's not actually checking for applications in use. In other words, gpk-update-viewer should not assume packagekitd is flawless and always running.

Additional info:
The details given for the "updates cannot proceed" message are usually three characters of garbage, but sometimes it gives the correct error message. The backtrace does not match up with that in other similar bug reports, and this is occurring on every machine I have Fedora on today, so I'm filing this as a new bug.

Comment 1 Richard Hughes 2011-03-15 11:10:02 UTC
Fixed, thanks for the great backtrace:

commit 11872c12358cb3ec1491c5309280f548d04aa00e
Author: Richard Hughes <richard>
Date:   Tue Mar 15 11:08:58 2011 +0000

    Fix a crash where the error code was pointing to freed memory. Fixes rh#684464

diff --git a/src/pk-transaction.c b/src/pk-transaction.c
index 5dd4577..34ded99 100644
--- a/src/pk-transaction.c
+++ b/src/pk-transaction.c
@@ -1874,8 +1874,9 @@ pk_transaction_set_running (PkTransaction *transaction)
        /* set proxy */
        ret = pk_transaction_set_session_state (transaction, &error);
        if (!ret) {
-               g_debug ("failed to set the session state (non-fatal): %s", error->message);
-               g_error_free (error);
+               g_debug ("failed to set the session state (non-fatal): %s",
+                        error->message);
+               g_clear_error (&error);
        }
 
        /* we are no longer waiting, we are setting up */

Comment 2 Richard Hughes 2011-08-04 10:43:44 UTC
*** Bug 700929 has been marked as a duplicate of this bug. ***

Comment 3 Fedora Update System 2011-08-04 11:15:05 UTC
PackageKit-0.6.12-4.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/PackageKit-0.6.12-4.fc14

Comment 4 Fedora Update System 2011-08-05 03:50:47 UTC
Package PackageKit-0.6.12-4.fc14:
* should fix your issue,
* was pushed to the Fedora 14 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing PackageKit-0.6.12-4.fc14'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/PackageKit-0.6.12-4.fc14
then log in and leave karma (feedback).

Comment 5 Fedora Update System 2011-09-02 05:30:43 UTC
PackageKit-0.6.12-4.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 6 Atul Modi 2011-09-05 08:45:24 UTC
(In reply to comment #1)
> Fixed, thanks for the great backtrace:
> 
> commit 11872c12358cb3ec1491c5309280f548d04aa00e
> Author: Richard Hughes <richard>
> Date:   Tue Mar 15 11:08:58 2011 +0000
> 
>     Fix a crash where the error code was pointing to freed memory. Fixes
> rh#684464
> 
> diff --git a/src/pk-transaction.c b/src/pk-transaction.c
> index 5dd4577..34ded99 100644
> --- a/src/pk-transaction.c
> +++ b/src/pk-transaction.c
> @@ -1874,8 +1874,9 @@ pk_transaction_set_running (PkTransaction *transaction)
>         /* set proxy */
>         ret = pk_transaction_set_session_state (transaction, &error);
>         if (!ret) {
> -               g_debug ("failed to set the session state (non-fatal): %s",
> error->message);
> -               g_error_free (error);
> +               g_debug ("failed to set the session state (non-fatal): %s",
> +                        error->message);
> +               g_clear_error (&error);
>         }
> 
>         /* we are no longer waiting, we are setting up */

Hello Richard,

How can I remove this bug?

What procedure should I follow.

Can you please send me some reply to atulmodi{at}hotmail.com

Regards,

Atul


Note You need to log in before you can comment on or make changes to this bug.