RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 684705 - missed unlock_page() in gfs2_write_begin()
Summary: missed unlock_page() in gfs2_write_begin()
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: kernel
Version: 6.0
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: rc
: ---
Assignee: Steve Whitehouse
QA Contact: Cluster QE
URL:
Whiteboard:
Depends On:
Blocks: 684795
TreeView+ depends on / blocked
 
Reported: 2011-03-14 09:49 UTC by Maxim
Modified: 2011-05-19 12:44 UTC (History)
5 users (show)

Fixed In Version: kernel-2.6.32-125.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 684795 (view as bug list)
Environment:
Last Closed: 2011-05-19 12:44:02 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
adding missed unlock_page() (312 bytes, patch)
2011-03-14 09:49 UTC, Maxim
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2011:0542 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 6.1 kernel security, bug fix and enhancement update 2011-05-19 11:58:07 UTC

Description Maxim 2011-03-14 09:49:44 UTC
Created attachment 484118 [details]
adding missed unlock_page()

Description of problem:

gfs2_write_begin() calls grab_cache_page_write_begin() that returns *locked* page. Correspondent error-handling path lacks for unlock_page() call:

> out:
> 	if (error == 0)
> 		return 0;
> 
> 	page_cache_release(page);

Version-Release number of selected component (if applicable):

2.6.32-71.18.2.el6

How reproducible:

The whole system hangs if gfs2_unstuff_dinode() called from gfs2_write_begin() failed for some reason.

Additional info:

Attached trivial patch solving the problem.

Comment 2 RHEL Program Management 2011-03-14 14:20:07 UTC
This request was evaluated by Red Hat Product Management for inclusion
in a Red Hat Enterprise Linux maintenance release. Product Management has 
requested further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed 
products. This request is not yet committed for inclusion in an Update release.

Comment 3 Steve Whitehouse 2011-03-14 14:33:18 UTC
Maxim, many thanks for the patch. I've got it queued up for all upstream and RHEL now.

If you are a customer and require the fix before the next scheduled release, please contact our support team and give them the bz number and they should be able to help you.

Comment 4 Aristeu Rozanski 2011-03-22 14:50:54 UTC
Patch(es) available on kernel-2.6.32-125.el6

Comment 7 Nate Straz 2011-04-11 19:28:51 UTC
Verified patch is applied to kernel-2.6.32-130.el6.

Comment 8 errata-xmlrpc 2011-05-19 12:44:02 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0542.html


Note You need to log in before you can comment on or make changes to this bug.