Bug 68788 - really big playlists eventually exhaust available process filehandles
really big playlists eventually exhaust available process filehandles
Product: Red Hat Linux
Classification: Retired
Component: mpg321 (Show other bugs)
i686 Linux
medium Severity medium
: ---
: ---
Assigned To: Bill Nottingham
Depends On:
  Show dependency treegraph
Reported: 2002-07-14 03:11 EDT by James Cook
Modified: 2014-03-16 22:28 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2003-01-24 18:10:22 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
Patch that cures the leak for me (490 bytes, patch)
2002-07-14 03:43 EDT, James Cook
no flags Details | Diff
A (possibly) more correct patch (279 bytes, patch)
2002-07-14 04:04 EDT, James Cook
no flags Details | Diff

  None (edit)
Description James Cook 2002-07-14 03:11:26 EDT
I have a primitive mp3 jukebox that runs 'mpg321 -o oss -z -@ big_honkin.m3u'
everything puts along just fine (for over two days actually) before I get a
message that there are no more filehandles available and it dumps out.

In the process of looking at that, I discovered the joys of the remote mode
which makes it even easier to find the problem.  'mpg321 -R -o oss dummy_param'
and then 'load'ing a couple of songs results in the following lsof snippet:

[reddirt@kiran reddirt]$ /usr/sbin/lsof | grep music
sh       1137 reddirt  255r   REG    3,2      49    32073
mpg123   1138 reddirt    3r   REG    3,9 7273485  2179082
mpg123   1138 reddirt    5r   REG    3,9 9556953  3604483

While the music is playing, there is an additional copy of the mp3 open but
instead of 3r or 5r, it's tagged as mem (memory-mapped access I assume). 
Anyhow, I've worked around it by 'quit'ting out and restarting the process, but
I'd rather spawn the background process once and not have to do that.
Comment 1 James Cook 2002-07-14 03:43:19 EDT
Created attachment 65285 [details]
Patch that cures the leak for me
Comment 2 James Cook 2002-07-14 03:46:39 EDT
Just a comment about the above patch.  Works for me, but since I know nothing
about the subtleties of mmaping files it may be all kinds of b0rken.
Comment 3 James Cook 2002-07-14 04:04:49 EDT
Created attachment 65286 [details]
A (possibly) more correct patch
Comment 4 James Cook 2002-07-14 04:15:45 EDT
The second patch appears to be correct.  It behaves as I would expect it to
according to lsof and it is, to my mind at least, a less invasive patch.
Comment 5 Bill Nottingham 2003-01-24 18:10:22 EST
At this point, we probably won't fix mpg321 bugs.

Note You need to log in before you can comment on or make changes to this bug.