Description of problem:
Yes, I am aware that Cobbler is not supported in this fashion.  However, many people do use the Cobbler instance provided by Satellite beyond the supported purpose.

When Cobbler has "manage_dhcp" enabled and it is managing ISC DHCP, it fails to restart because there are still open file descriptors.  This was addressed in upstream Cobbler, but the version within Satellite seems to be at an odd patch level and this fix was not included.  The upstream commit that fixed it was 1a7c17cdd5325008b2f5337f0066a242a406bfa3.

Since that patch doesn't apply to Satellite's version of Cobbler, the attached patch resolves Cobbler not being able to restart when it is managing DHCP.


Version-Release number of selected component (if applicable):
cobbler-2.0.7-5.el5sat

How reproducible:
always

Steps to Reproduce:
1. enable 'manage_dhcp' in /etc/cobbler/settings
2. service cobblerd start
3. service dhcpd start
4. cobbler sync
5. service cobblerd restart
  
Actual results:
[root@satellite cobbler]# service cobblerd restart
Stopping cobbler daemon:                                   [  OK  ]
Starting cobbler daemon:                                   [  OK  ]
[root@satellite cobbler]# Traceback (most recent call last):
  File "/usr/bin/cobblerd", line 91, in main
    app.core(api)
  File "/usr/lib/python2.4/site-packages/cobbler/cobblerd.py", line 50, in core
    do_xmlrpc_tasks(bootapi, settings, xmlrpc_port)
  File "/usr/lib/python2.4/site-packages/cobbler/cobblerd.py", line 68, in do_xmlrpc_tasks
    do_xmlrpc_rw(bootapi, settings, xmlrpc_port)
  File "/usr/lib/python2.4/site-packages/cobbler/cobblerd.py", line 107, in do_xmlrpc_rw
    server = remote.CobblerXMLRPCServer(('127.0.0.1', port))
  File "/usr/lib/python2.4/site-packages/cobbler/remote.py", line 1738, in __init__
    SimpleXMLRPCServer.SimpleXMLRPCServer.__init__(self,args)
  File "/usr/lib64/python2.4/SimpleXMLRPCServer.py", line 473, in __init__
    SocketServer.TCPServer.__init__(self, addr, requestHandler)
  File "/usr/lib64/python2.4/SocketServer.py", line 330, in __init__
    self.server_bind()
  File "/usr/lib64/python2.4/SocketServer.py", line 341, in server_bind
    self.socket.bind(self.server_address)
  File "<string>", line 1, in bind
error: (98, 'Address already in use')

[root@satellite cobbler]# service cobblerd status
cobblerd dead but subsys locked
[root@satellite cobbler]# 


Expected results:
[root@satellite cobbler]# service cobblerd restart
Stopping cobbler daemon:                                   [  OK  ]
Starting cobbler daemon:                                   [  OK  ]
[root@satellite cobbler]# SERVING!


Additional info:
http://git.fedorahosted.org/git/?p=cobbler;a=commit;h=1a7c17cdd5325008b2f5337f0066a242a406bfa3