Spec URL: http://labs.linuxnetz.de/bugzilla/mod_flvx.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/mod_flvx-0-0.1.20100525git.src.rpm Description: FLV streaming means it can be sought to any position during video, and browser (Flash player) will buffer only from this position to the end. Thus streaming allows to skip boring parts or see video ending without loading the whole file, which simply saves bandwidth. Even H264 is more efficient, FLV is still a common container format for videos, because H264 is supported by Flash since version 9.115. For using FLV streaming on the web, a pseudo-streaming compliant Flash player, such as Flowplayer, is needed. Streaming requires that the FLV has embedded key-frame markers (meta-data), that can be injected by any supported tool, e.g. flvtool2.
Tom, as already talked with you on IRC, mod_flvx is not being a legal issue from your point of view, because there's nothing FLV-related itself inside. May you just state here that officially and lift FE-Legal afterwards? Thanks.
Yep. This code makes no attempt to do anything with the FLV format, not even parsing it, so there are no legal concerns that I am aware of at this time. Lifting FE-Legal.
I'll review it.
+ = OK - = NA ? = issue + Package meets naming and packaging guidelines ? Spec file matches base package name. + Spec has consistent macro usage. + Meets Packaging Guidelines. + License + License field in spec matches ? License file included in package + Spec in American English + Spec is legible. + Sources match upstream md5sum: - Package needs ExcludeArch + BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. + Package has a correct %clean section. + Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) + Package is code or permissible content. - Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. - Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. + No rpmlint output. (Just a warning about an invalid URL, but github is strange, I know.) - final provides and requires are sane: SHOULD Items: - Should build in mock. - Should build on all supported archs - Should function as described. - Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version I'm not entirely familiar with your Requires line. Can you explain to me why you're executing a command to determine build requirements? No other apache module package I know of requires this.
Other Apache modules are doing that as well, some examples: - http://pkgs.fedoraproject.org/gitweb/?p=mod_perl.git;a=blob;f=mod_perl.spec - http://pkgs.fedoraproject.org/gitweb/?p=mod_suphp.git;a=blob;f=mod_suphp.spec - http://pkgs.fedoraproject.org/gitweb/?p=mod_fcgid.git;a=blob;f=mod_fcgid.spec - http://pkgs.fedoraproject.org/gitweb/?p=mod_cband.git;a=blob;f=mod_cband.spec - http://pkgs.fedoraproject.org/gitweb/?p=mod_evasive.git;a=blob;f=mod_evasive.spec The goal is to ensure ABI compatibility between the httpd the mod_* package has been built for and the combination it is currently running with. Unfortunately, this requirement doesn't seem to be forced by the Guidelines as it IMHO should. Please note that the command is executed on build-time, not at run-time. That means that the package gets a runtime requirement like "httpd-mmn = 20051115", which is satisfied by the httpd package.
I suppose that since other packages (especially the critical fcgid) are doing it, that sets a precedent. Approved!
Trever, thank you very much for the review. New Package SCM Request ======================= Package Name: mod_flvx Short Description: FLV progressive download streaming for the Apache HTTP Server Owners: robert Branches: el4 el5 el6 f13 f14 f15 InitialCC:
Git done (by process-git-requests).
mod_flvx-0-0.1.20100525git.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/mod_flvx-0-0.1.20100525git.fc15
mod_flvx-0-0.1.20100525git.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/mod_flvx-0-0.1.20100525git.fc14
mod_flvx-0-0.1.20100525git.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/mod_flvx-0-0.1.20100525git.fc13
mod_flvx-0-0.1.20100525git.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/mod_flvx-0-0.1.20100525git.el6
mod_flvx-0-0.1.20100525git.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/mod_flvx-0-0.1.20100525git.el5
mod_flvx-0-0.1.20100525git.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/mod_flvx-0-0.1.20100525git.el4
mod_flvx-0-0.1.20100525git.fc13 has been pushed to the Fedora 13 testing repository.
mod_flvx-0-0.1.20100525git.fc15 has been pushed to the Fedora 15 stable repository.
mod_flvx-0-0.1.20100525git.fc14 has been pushed to the Fedora 14 stable repository.
mod_flvx-0-0.1.20100525git.fc13 has been pushed to the Fedora 13 stable repository.
mod_flvx-0-0.1.20100525git.el6 has been pushed to the Fedora EPEL 6 stable repository.
mod_flvx-0-0.1.20100525git.el5 has been pushed to the Fedora EPEL 5 stable repository.
mod_flvx-0-0.1.20100525git.el4 has been pushed to the Fedora EPEL 4 stable repository.