A recent run of Coverity identified a few issues with code maintainability. We need to address these issues.
Created attachment 485829 [details] Patch for cov#10709
Created attachment 485851 [details] Patch for cov#10708
Created attachment 486041 [details] Patch for cov#10707
Created attachment 486043 [details] Patch for cov#10706 & 10707
Created attachment 486053 [details] Patch for cov#10704 & 10705
Created attachment 486057 [details] Patch for cov#10703
Created attachment 486059 [details] Patch for cov#10702
Pushed patches to master. Thanks to Noriko for her reviews! Counting objects: 44, done. Delta compression using up to 2 threads. Compressing objects: 100% (36/36), done. Writing objects: 100% (36/36), 3.29 KiB, done. Total 36 (delta 27), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git bd148df..9d5d73c master -> master
Created attachment 486862 [details] Additional patch for cov#10709 A re-run of Coverity uncovered another issue around cov#10709. This fixes the issue.
Pushed additional patch from comment#9 to master. Thanks to Noriko for her review! Counting objects: 11, done. Delta compression using up to 2 threads. Compressing objects: 100% (6/6), done. Writing objects: 100% (6/6), 658 bytes, done. Total 6 (delta 4), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git 6ada149..0498723 master -> master
Do we want to target any of these for 389 1.2.8?
(In reply to comment #11) > Do we want to target any of these for 389 1.2.8? No, I don't think so. None of them look critical.