Spec URL: http://mmahut.fedorapeople.org/reviews/python-cli/python-cli.spec SRPM URL: http://mmahut.fedorapeople.org/reviews/python-cli/python-cli-1.1-1.el6.src.rpm Description: This is Python-CLI, a CLI construction toolit for Python. It is similar in scope to Python's "cmd", "cmd2", and pyCLI.
Scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=2923425
- = N/A / = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [/] Package is named according to the Package Naming Guidelines. [/] Spec file name must match the base package %{name}, in the format %{name}.spec. [/] Package meets the Packaging Guidelines including the Language specific items [/] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested: http://koji.fedoraproject.org/koji/taskinfo?taskID=925884 [!] Rpmlint output: python-cli.noarch: W: spelling-error %description -l en_US toolit -> toolkit, too lit, too-lit python-cli.noarch: W: spelling-error %description -l en_US cmd -> cm, cad, cod python-cli.noarch: W: spelling-error %description -l en_US pyCLI -> cyclic, cyclist, pyloric python-cli.src: W: spelling-error %description -l en_US toolit -> toolkit, too lit, too-lit python-cli.src: W: spelling-error %description -l en_US cmd -> cm, cad, cod python-cli.src: W: spelling-error %description -l en_US pyCLI -> cyclic, cyclist, pyloric 2 packages and 1 specfiles checked; 0 errors, 6 warnings. [/] Package is not relocatable. [/] Buildroot is correct ( Not needed if >= EL6 and >= F13 ) Buildroot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) [/] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [/] License field in the package spec file matches the actual license. License type: MIT [/] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [/] With any Subpackage installed the license must also be installed (this may belong to another subpackage) [/] Spec file is legible and written in American English. [!] Sources used to build the package matches the upstream source, as provided in the spec URL. d88b18926c4559df189b0b3aaafa029b python-cli-1.1.tar.gz 2ae33196db771ca44f09b092d1430696 SOURCES/python-cli-1.1.tar.gz [/] Package is not known to require ExcludeArch [/] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [/] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [/] Package must own all directories that it creates. [/] Package requires other packages for directories it uses. [/] Package does not contain duplicates in %files. [/] Permissions on files are set properly. [/] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT. ( Not needed if >= EL6 and >= F13 ) [/] Package consistently uses macros. [/] Package contains code, or permissible content. [-] Large documentation files are in a -doc subpackage, if required. [/] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -static subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [/] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [/] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [/] Latest version is packaged. [/] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [/] Reviewer should test that the package builds in mock. Tested through koji [/] Package should compile and build into binary rpms on all supported architectures. Tested on: fedora-6E-epel-testing-candidate [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [-] %check is present and the tests pass === Comments === Minor typo in description toolit -> toolkit (can be fixed after initial commit) tarball doesn't match upstream (blocker)
tarball now matches. typo still needs fixing APPROVED Please fix the typo on commit.
Thank you Mark. New Package SCM Request ======================= Package Name: python-cli Short Description: A CLI construction toolkit for Python Branches: f14 f15 el6 el5 Owners: mmahut
This ticket is not assigned to anyone. It should be assigned to the reviewer. Please fix and re-raise the fedora-cvs flag.
Sorry about that. Taken, and re-raised.
Git done (by process-git-requests).
python-cli-1.1-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/python-cli-1.1-1.fc15
python-cli-1.1-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/python-cli-1.1-1.fc14
python-cli-1.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-cli-1.1-1.el6
python-cli-1.1-1.fc14 has been pushed to the Fedora 14 stable repository.
python-cli-1.1-1.fc15 has been pushed to the Fedora 15 stable repository.
python-cli-1.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
Since the package has been built for quite some time now, the review request bugzilla should be closed.