Bug 689627 - Review Request: python-MyProxyClient - Python implementation of the myproxy client
Summary: Review Request: python-MyProxyClient - Python implementation of the myproxy c...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-21 22:32 UTC by Steve Traylen
Modified: 2014-06-03 13:16 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-03 13:16:35 UTC
Type: ---
i: fedora-review?


Attachments (Terms of Use)

Description Steve Traylen 2011-03-21 22:32:13 UTC
Spec URL: http://cern.ch/straylen/rpms/python-MyProxyClient/python-MyProxyClient.spec
SRPM URL:http://cern.ch/straylen/rpms/python-MyProxyClient/python-MyProxyClient-1.2.2-1.fc14.src.rpm 
Description:
Python implementation of the client interface to the MyProxy
credential management service (http://grid.ncsa.illinois.edu/myproxy/)

This package contains API documentation.

Comment 1 Mattias Ellert 2012-02-08 20:58:39 UTC
rpmbuild --rebuild of the srpm fails with:

/usr/bin/python ./test_myproxyclient.py MyProxyClientInterfaceTestCase
..ERROR:myproxy.client:Certificate <X509Name object '/O=NDG/OU=Security/CN=localhost'> in peer certificate chain has expired
F
======================================================================
FAIL: test03SSLVerification (__main__.MyProxyClientInterfaceTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./test_myproxyclient.py", line 325, in test03SSLVerification
    self.assert_(status == successStatus)
AssertionError: False is not true

----------------------------------------------------------------------
Ran 3 tests in 0.002s

FAILED (failures=1)

Comment 2 Mattias Ellert 2013-08-30 06:26:58 UTC
Hi Steve!

Any progress on this one, or have you dropped it?

    Mattias

Comment 3 Steve Traylen 2013-08-30 08:00:30 UTC
I'll close unless you want to take it.

Comment 4 Christopher Meng 2013-12-12 02:55:01 UTC
I will take it.

First question, will you push this to EPEL5?

Comment 5 Steve Traylen 2013-12-12 08:07:54 UTC
If you are taking it then it's you choice if to do EPEL5 or not?
Steve.

Comment 6 Christopher Meng 2013-12-12 08:11:53 UTC
I'd say NOT. But you CERN guys prefer EL a lot, I should listen to the opinion from you at least.

Please package 1.3.1 first.

Comment 7 Christopher Meng 2013-12-12 08:13:15 UTC
BTW tell me your FAS name, I need to verify if you've been sponsored or not.

Comment 8 Matthias Runge 2013-12-12 08:18:38 UTC
Christopher,

Steve is a long time Fedora packager, the FAS name is stevetraylen.
Everything's fine here.

Comment 9 Christopher Meng 2013-12-12 08:52:47 UTC
(In reply to Matthias Runge from comment #8)
> Christopher,
> 
> Steve is a long time Fedora packager, the FAS name is stevetraylen.
> Everything's fine here.

Thanks, but I think he should put such info in the initial comment, why not help us?

I still need to await the anwser of targeting EL5 or not, because this will affect the macros will be used.

If Steven think it's inappreciable to answer such questions, please reassign.

Comment 10 Matthias Runge 2013-12-12 09:30:16 UTC
(In reply to Christopher Meng from comment #9)

> Thanks, but I think he should put such info in the initial comment, why not
> help us?

Christopher, since you're very new here, you can not know that this has changed in the past. This ticket is 2.5 years old, and at this time, it was not required.

Comment 11 Björn 'besser82' Esser 2013-12-12 09:42:55 UTC
(In reply to Christopher Meng from comment #9)
> (In reply to Matthias Runge from comment #8)
> > Christopher,
> > 
> > Steve is a long time Fedora packager, the FAS name is stevetraylen.
> > Everything's fine here.
> 
> Thanks, but I think he should put such info in the initial comment, why not
> help us?

Using IRC `.fas $EMAIL_ADDRESS` and `.fasinfo $FOUND_USERNAME` should give you some answer on this, too.  ;)

> I still need to await the anwser of targeting EL5 or not, because this will
> affect the macros will be used.

That is not a matter of el5...

One always can use conditionals in a spec-file for those macros like:

%{!?__python2 %global __python2 %{__python}}

and so on.  But I think supporting el5 would be a good idea for this.

> If Steven think it's inappreciable to answer such questions, please reassign.

You didn't even give him some time for response... You asked him today during midnight in CET (UTC +0100) and demand an answer until the morning hours.

Comment 12 Christopher Meng 2013-12-12 10:22:17 UTC
(In reply to Björn "besser82" Esser from comment #11)
> That is not a matter of el5...
> 
> One always can use conditionals in a spec-file for those macros like:
> 
> %{!?__python2 %global __python2 %{__python}}
> 
> and so on.  But I think supporting el5 would be a good idea for this.

Why should we make spec like a mess? Don't you think they are eyesores?

Also I need a latest RPM to test if can be built on EL5 as EL5 ships a very old python version.

Comment 13 Steve Traylen 2014-06-03 13:16:35 UTC
Hi,

Thanks for the comments, I'm closing, no longer interested in it basically.


Note You need to log in before you can comment on or make changes to this bug.