Spec URL: http://tdfischer.fedorapeople.org/anchorman.spec SRPM URL: http://tdfischer.fedorapeople.org/anchorman-0.0.1-1.fc14.src.rpm Description, from my spec file: > Ever wanted to run your own recording studio? Need to handle multiple streams of > audio, video, and possibly even subtitles? Anchorman can't do that. Yet. > However, it can stream a webcam to an icecast server. Included is support for > suspending/resuming the stream when the device is inserted/removed. Anchorman is a small program that waits for a webcam to be attached. Once attached, the camera stream is sent off to an icecast or shoutcast server for broadcasting. The stream stops once the camera is removed. This is my first package (and first release of anchorman), so I need a sponsor. More features will be coming to anchorman when I have the time to write them. In case it isn't clear, I am upstream for anchorman.
I'll do an unofficial review.
+ Package meets naming and packaging guidelines + Spec file matches base package name. ? Spec has consistent macro usage. ? Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. ? Sources match upstream md5sum: - Package needs ExcludeArch ? BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. + Package has a correct %clean section. + Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) + Package is code or permissible content. - Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. - Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. + No rpmlint output. (Only spelling warnings, which are wrong) - final provides and requires are sane: SHOULD Items: - Should build in mock. - Should build on all supported archs - Should function as described. - Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version Issues: 1.Replace every instance of anchorman with %{name} 2.Replace the version in the source URL to %{version} 3.Use %{_bindir} instead of /usr/bin 4.BuildRequires missing: gcc-c++ (cmake didn't want to configure without this package installed) 4.Please provide md5 sum for released tarball. Warnings: 1.Clean section is not required for Fedora 13 or above 2.I think you should change the summary, it does not matching the description (it's a webcam streaming application, not a recording studio) 3.Your test section is broken, It outputs ********************************* No test configuration file found! ********************************* and then the usage information. 4.(Not directly related to the review): Your project's fedorahosted page lists the wrong link for anonymous git access. Please fix these errors and warnings, and update the spec and SRPM accordingly.
Forgot to mention: + = OK - = NA ? = issue
Issues fixed. Updated SRPM and .spec file uploaded.
(In reply to comment #4) > Issues fixed. Updated SRPM and .spec file uploaded. Uploaded to where exactly? Please update the spec (use the same link you used before) and upload a new SRPM. Don't forget to bump the release and add a changelog entry for every change you make.
You don't need gcc-c++ as a BR: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
I can review/sponsor here, as promised.
1. As mentioned in comment #6, BR: gcc-c++ should be dropped. Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3009270 sources ok ba211b882225cec7a85923b0d626ef57 anchorman-0.0.1.tar.gz rpmlint *.rpm x86_64/*.rpm anchorman.src: W: spelling-error %description -l en_US webcam -> web cam, web-cam, webcast anchorman.src: W: spelling-error %description -l en_US icecast -> ice cast, ice-cast, icecap anchorman.x86_64: W: spelling-error %description -l en_US webcam -> web cam, web-cam, webcast anchorman.x86_64: W: spelling-error %description -l en_US icecast -> ice cast, ice-cast, icecap anchorman.x86_64: W: no-manual-page-for-binary anchorman 3 packages and 0 specfiles checked; 0 errors, 5 warnings. mostly harmless here. licensing: ok naming: ok scriptlets: n/a runtime: naively running the binary (without option or webcam hardware present), gives me a segfault, but we can let that slide being a very new project. otherwise, nice-n-simple source and packaging all around. I won't block on item 1 above, but would appreciate it being fixed prior to doing any official builds. APPROVED (lifting NEEDSPONSOR)
New Package SCM Request ======================= Package Name: anchorman Short Description: The recording studio in-a-box Owners: tdfischer Branches: f14 f15 InitialCC: tdfischer
The requested package name does not match the name in the ticket summary. Please correct whichever is wrong and re-raise the fedora-cvs flag.
(In reply to comment #10) > The requested package name does not match the name in the ticket summary. > Please correct whichever is wrong and re-raise the fedora-cvs flag. I'm not sure what you mean. The package name should be 'anchorman', which is the same name that the project uses internally, and in the spec file. Are you referring to the capital "A" in the ticket title?
Git done (by process-git-requests).
anchorman-0.0.1-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/anchorman-0.0.1-1.fc14
anchorman-0.0.1-1.fc14 has been pushed to the Fedora 14 testing repository.
Did you ever build/release this for f15+ too? If not, why not?
anchorman-0.0.1-1.fc14 has been pushed to the Fedora 14 stable repository.