Bug 690328 - Review Request: be - Bugs Everywhere, a distributed bug tracker
Summary: Review Request: be - Bugs Everywhere, a distributed bug tracker
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Peter Lemenkov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-23 23:03 UTC by Michel Lind
Modified: 2011-04-11 18:21 UTC (History)
4 users (show)

Fixed In Version: be-1.0.0-2.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-03-30 05:40:02 UTC
Type: ---
Embargoed:
lemenkov: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Michel Lind 2011-03-23 23:03:32 UTC
Spec URL: http://salimma.fedorapeople.org/specs/devtools/be.spec
SRPM URL: http://salimma.fedorapeople.org/specs/devtools/be-1.0.0-1.fc15.src.rpm
Description:
This is Bugs Everywhere (BE), a bug tracker built on distributed
version control.  It works with Arch, Bazaar, Darcs, Git, Mercurial,
and Monotone at the moment, but is easily extensible.  It can also
function with no VCS at all.

The idea is to package the bug information with the source code, so
that bugs can be marked "fixed" in the branches that fix them.  So,
instead of numbers, bugs have globally unique ids.

Comment 1 Peter Lemenkov 2011-03-24 04:29:44 UTC
I'll review it.

Comment 2 Peter Lemenkov 2011-03-24 09:11:21 UTC
Koji scratchbuild for F-15:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2940018

Comment 3 Peter Lemenkov 2011-03-24 09:25:12 UTC
REVIEW:

Legend: + = PASSED, - = FAILED, 0 = Not Applicable

- rpmlint is not silent

work ~: rpmlint Desktop/be-1.0.0-1.fc15.*
be.noarch: W: non-standard-group Unspecified
be.src: W: non-standard-group Unspecified
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
work ~: 

Please, add Group tag to make rpmlint silent.

+ The package is named according to the  Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format %{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the Licensing Guidelines.
+ The License field in the package spec file matches the actual license (GPLv2 or later).
+ The file, containing the text of the license(s) for the package, is included in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided in the spec URL.

sulaco ~/rpmbuild/SOURCES: sha256sum be-1.0.0.tar.gz*
f63bf64d058505f192c5b64a40fcb2cca6da24979eae0d5b08ab1c5e5dbcc700  be-1.0.0.tar.gz
f63bf64d058505f192c5b64a40fcb2cca6da24979eae0d5b08ab1c5e5dbcc700  be-1.0.0.tar.gz.1
sulaco ~/rpmbuild/SOURCES: 

+ The package successfully compiles and builds into binary rpms on at least one primary architecture. See koji link above.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files.
+ The package does NOT bundle copies of system libraries.
+ The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files listings.
+ Permissions on files are set properly.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the application.
0 No header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1).
0 No devel sub-package.
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.

+ The package does own files or directories already owned by other packages, namely /etc/bash_completion.d. Co-ownership of this particular directory is de-facto acceptable.

+ At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.

Please, suppress the only rpmlint message and I'll continue.

Comment 4 Michel Lind 2011-03-24 20:09:42 UTC
rpmlint really needs to be updated -- Group and %defattr are both deprecated (as you can see I added a comment marking that it's only there to appease rpmlint). But yes, adding those does not hurt.

RPMlint is silent on F-15. what version do you have?


[salim@fauix11 gnome]$ rpmlint ./be-1.0.0-1.fc15.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[salim@fauix11 gnome]$ rpmlint ~/Downloads/be-1.0.0-1.fc15.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[salim@fauix11 gnome]$ rpm -q rpmlint
rpmlint-1.1-3.fc15.noarch

Comment 6 Peter Lemenkov 2011-03-25 04:36:06 UTC
Ok, good. I can't see any other issues (and my old rpmlint 1.0.2 is happy now) so this package is

APPROVED.

Comment 7 Michel Lind 2011-03-25 08:07:31 UTC
Thanks, Peter.

New Package SCM Request
=======================
Package Name: be
Short Description: Bugs Everywhere, a distributed bug tracker
Owners: salimma
Branches: el5 el6 f14 f15
InitialCC:

Comment 8 Jason Tibbitts 2011-03-25 19:06:42 UTC
Git done (by process-git-requests).

Comment 9 Fedora Update System 2011-03-25 22:37:58 UTC
be-1.0.0-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/be-1.0.0-2.el6

Comment 10 Fedora Update System 2011-03-25 22:38:05 UTC
be-1.0.0-2.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/be-1.0.0-2.el5

Comment 11 Fedora Update System 2011-03-25 22:38:12 UTC
be-1.0.0-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/be-1.0.0-2.fc14

Comment 12 Fedora Update System 2011-03-25 22:38:19 UTC
be-1.0.0-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/be-1.0.0-2.fc15

Comment 13 Fedora Update System 2011-03-26 04:50:34 UTC
be-1.0.0-2.fc15 has been pushed to the Fedora 15 testing repository.

Comment 14 Fedora Update System 2011-03-30 05:39:57 UTC
be-1.0.0-2.fc15 has been pushed to the Fedora 15 stable repository.

Comment 15 Fedora Update System 2011-04-05 05:21:07 UTC
be-1.0.0-2.fc14 has been pushed to the Fedora 14 stable repository.

Comment 16 Fedora Update System 2011-04-11 18:21:35 UTC
be-1.0.0-2.el5 has been pushed to the Fedora EPEL 5 stable repository.

Comment 17 Fedora Update System 2011-04-11 18:21:47 UTC
be-1.0.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository.


Note You need to log in before you can comment on or make changes to this bug.