Hide Forgot
Spec URL: http://cheeselee.fedorapeople.org/perl-Shipwright.spec SRPM URL: http://cheeselee.fedorapeople.org/perl-Shipwright-2.4.23-1.fc14.src.rpm Description: Shipwright is a tool to help you bundle your software with all its dependencies, regardless of whether they are CPAN modules or non-Perl modules from elsewhere. Shipwright makes the bundle work easy. $ rpmlint ./perl-Shipwright.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint ./perl-Shipwright-2.4.23-1.fc14.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
- rpmlint OK - package must be named according to Guidelines OK - spec file name must match the base package %{name} OK - package must meet the Packaging Guidelines OK - package must be licensed with Fedora approved license OK - license field must match actual license OK - text of the license in its own file must be included in %doc OK - sources must match the upstream source OK - package MUST successfully compile and build ? http://koji.fedoraproject.org/koji/taskinfo?taskID=2959749 - architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK - build dependencies must be listed in BuildRequires OK - handle locales properly with %find_lang macro OK - shared library files must call ldconfig in %post(un) OK - packages must NOT bundle system libraries OK - package must own all directories that it creates OK - permissions on files must be set properly OK - package must consistently use macros OK - package must contain code, or permissable content OK - large documentation must go in a -doc OK - %doc must not affect the runtime of the application OK - header files must be in a -devel package OK - static libraries must be in a -static package OK - library files that end in .so (without suffix) must go in a -devel OK - devel package usually require base package OK - packages must NOT contain any .la libtool archives OK - GUI applications must include a %{name}.desktop file OK - packages must not own files or directories already owned by other packages OK Couldn't you replace bundled Module::Install from inc to system's Module::Install? Also test part during build didn't pass in koji: t/10.flags.t ........ ok # Failed test 'Build.PL and Makefile.PL are run' # at /builddir/build/BUILD/Shipwright-2.4.23/blib/lib/Shipwright/Test.pm line 244. # 'building tgz_build # ' # doesn't match '(?ms-xi:run, run, Build\.PL.*run, run, Makefile\.PL)' # Looks like you failed 1 test of 140. t/71.script_cmds.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/140 subtests (less 106 skipped subtests: 33 okay) build Foo-Bar configure part failed, last output of build.log is: build configure part in Foo-Bar with cmd: /usr/bin/perl -I/tmp/shipwright_build_o8CDqf/inc -MShipwright::Util::CleanINC Makefile.PL LIB=/tmp/shipwright_install_bpN95x/lib/perl5/ PREFIX=/tmp/shipwright_install_bpN95x running shipwright build command: /usr/bin/perl -I/tmp/shipwright_build_o8CDqf/inc -MShipwright::Util::CleanINC Makefile.PL LIB=/tmp/shipwright_install_bpN95x/lib/perl5/ PREFIX=/tmp/shipwright_install_bpN95x Can't locate Cwd.pm in @INC (@INC contains: blib/lib blib/arch /tmp/shipwright_install_bpN95x/lib/perl5/x86_64-linux-thread-multi /tmp/shipwright_install_bpN95x/lib/perl5/site_perl /tmp/shipwright_install_bpN95x/lib/perl5 /tmp/shipwright_build_o8CDqf/inc . /usr/lib64/perl5 /usr/share/perl5) at inc/Module/Install.pm line 110. BEGIN failed--compilation aborted at inc/Module/Install.pm line 110. Compilation failed in require at Makefile.PL line 1. BEGIN failed--compilation aborted at Makefile.PL line 1. at bin/shipwright-builder line 573 main::_install('Foo-Bar', 'GLOB(0x16a2830)') called at bin/shipwright-builder line 412 main::install() called at bin/shipwright-builder line 276 # Failed test '/tmp/shipwright_install_bpN95x/lib/perl5/Foo/Bar.pm exists' # at t/hello/fs.t line 189. # Looks like you failed 1 test of 38. t/hello/fs.t ........ Dubious, test returned 1 (wstat 256, 0x100) Failed 1/38 subtests t/hello/git.t ....... ok
(In reply to comment #1) > Couldn't you replace bundled Module::Install from inc to system's > Module::Install? Any example or guideline?
(In reply to comment #2) > (In reply to comment #1) > > > Couldn't you replace bundled Module::Install from inc to system's > > Module::Install? > Any example or guideline? It's in SHOULD section: http://fedoraproject.org/wiki/PackagingGuidelines#Bundling_of_multiple_projects
(In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > > > Couldn't you replace bundled Module::Install from inc to system's > > > Module::Install? > > Any example or guideline? > > It's in SHOULD section: > http://fedoraproject.org/wiki/PackagingGuidelines#Bundling_of_multiple_projects Though replacing bundled Module::Install is usually possible, it doesn't make much sense and is not followed regularly, like perl-File-HomeDir.
Please post new koji build with working test suite and we can close this review.
Change: - Update to 2.4.24 Spec URL: http://cheeselee.fedorapeople.org/perl-Shipwright.spec SRPM URL: http://cheeselee.fedorapeople.org/perl-Shipwright-2.4.24-1.fc14.src.rpm
http://koji.fedoraproject.org/koji/taskinfo?taskID=2978308 Even on new version rpmlint doesn't complain. APPROVED
Thank you New Package SCM Request ======================= Package Name: perl-Shipwright Short Description: Build and Manage Self-contained Software Bundle Owners: cheeselee Branches: f13 f14 f15 InitialCC: perl-sig
Git done (by process-git-requests).