Bug 690746 - Review Request: perl-Perl-Critic-Swift - Set of additional policies for Perl::Critic
Summary: Review Request: perl-Perl-Critic-Swift - Set of additional policies for Perl:...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 690569
TreeView+ depends on / blocked
 
Reported: 2011-03-25 10:00 UTC by Petr Pisar
Modified: 2011-03-28 15:34 UTC (History)
2 users (show)

Fixed In Version: perl-Perl-Critic-Swift-1.0.3-1.fc16
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-03-28 15:34:27 UTC
Type: ---
Embargoed:
mmaslano: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Petr Pisar 2011-03-25 10:00:09 UTC
Spec URL: http://ppisar.fedorapeople.org/perl-Perl-Critic-Swift/perl-Perl-Critic-Swift.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-Perl-Critic-Swift/perl-Perl-Critic-Swift-1.0.3-1.fc16.src.rpm
Description:
Some Perl::Critic policies to make your code more clean. The included
policies are:

    * Perl::Critic::Policy::CodeLayout::RequireUseUTF8
    * Perl::Critic::Policy::Documentation::RequirePODUseEncodingUTF8

Comment 1 Marcela Mašláňová 2011-03-28 14:01:22 UTC
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

http://koji.fedoraproject.org/koji/taskinfo?taskID=2953777
rpm -qp --provides ../RPMS/noarch/perl-Perl-Critic-Swift-1.0.3-1.fc14.noarch.rpm 
perl(Perl::Critic::Policy::CodeLayout::RequireUseUTF8) = 1.0.3
perl(Perl::Critic::Policy::Documentation::RequirePODUseEncodingUTF8) = 1.0.3
perl(Perl::Critic::Swift) = 1.0.3
perl-Perl-Critic-Swift = 1.0.3-1.fc14
 rpm -qp --requires ../RPMS/noarch/perl-Perl-Critic-Swift-1.0.3-1.fc14.noarch.rpm 
perl(:MODULE_COMPAT_5.12.3)  
perl(List::MoreUtils) >= 0.21
perl(Perl::Critic::Policy) >= 1.082
perl(Perl::Critic::Utils) >= 1.082
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
perl >= 0:5.006
perl(base)  
perl(strict)  
perl(utf8)  
perl(version)  
perl(warnings)  

APPROVED

Comment 2 Petr Pisar 2011-03-28 14:23:09 UTC
New Package SCM Request
=======================
Package Name: perl-Perl-Critic-Swift
Short Description: Set of additional policies for Perl::Critic
Owners: ppisar mmaslano psabata
Branches: 
InitialCC: perl-sig

Comment 3 Jason Tibbitts 2011-03-28 15:18:57 UTC
Git done (by process-git-requests).

Comment 4 Petr Pisar 2011-03-28 15:34:27 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.