Spec URL: http://mkulemin.fedorapeople.org/packages/erlang-erlzmq2.spec SRPM URL: http://mkulemin.fedorapeople.org/packages/erlang-erlzmq2-0-2.20110323gitc459825.fc14.src.rpm Description: NIF based Erlang binding for ZeroMQ messaging library. This implementation is faster than port driver based.
I'll review it (as soon as blocker bug will be resolved)
The blocker bug is resolved in rawhide. I'll intent do push out packages to the other branches, once there is a new version of pyzmq (which will be "quite soon" according to upstream [1]). [1] https://github.com/zeromq/pyzmq/issues/90/#issue/90/comment/908382
Build new rpm from latest sources. Now socket is a tuple with index number. SRPM URL: http://mkulemin.fedorapeople.org/packages/erlang-erlzmq2-0-1.20110406gitfd99a31.fc14.src.rpm
This is wrong: %define debug_package %{nil} This package contains shared library object so it needs a debuginfo.
Failed to build in Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2978125
* Fix build on i686. * Add debuginfo. Koji build ok: https://koji.fedoraproject.org/koji/taskinfo?taskID=2981724 SRPM: http://mkulemin.fedorapeople.org/packages/erlang-erlzmq2-0-2.20110406gitfd99a31.fc14.src.rpm SPEC: http://mkulemin.fedorapeople.org/packages/erlang-erlzmq2.spec The only rpmlint issue is erlang-erlzmq2.x86_64: E: explicit-lib-dependency erlang-stdlib But erlang-stdlib is need.
Building errors (on i686) fixed in upstream, so new version Koji build ok: http://koji.fedoraproject.org/koji/taskinfo?taskID=2982724 SRPM: http://mkulemin.fedorapeople.org/packages/erlang-erlzmq2-0-1.20110408gita2b0693.fc14.src.rpm SPEC: http://mkulemin.fedorapeople.org/packages/erlang-erlzmq2.spec
REVIEW: Legend: + = PASSED, - = FAILED, 0 = Not Applicable + rpmlint is silent work ~/Desktop: rpmlint erlang-erlzmq2-* erlang-erlzmq2.src:67: W: macro-in-%changelog %{git_tag} erlang-erlzmq2.src:70: W: macro-in-%changelog %{git_tag} erlang-erlzmq2.src:74: W: macro-in-%changelog %{git_tag} erlang-erlzmq2.src:77: W: macro-in-%changelog %{git_tag} erlang-erlzmq2.src:81: W: macro-in-%changelog %{git_tag} erlang-erlzmq2.src:18: W: mixed-use-of-spaces-and-tabs (spaces: line 18, tab: line 4) ^^ this should be fixed (use real values instead of macros) erlang-erlzmq2.src: W: invalid-url Source0: zeromq-erlzmq2-a2b0693.tar.gz ^^ that's ok, however I advise you to add a description on how to obtain the tarball ( wget --no-check-certificate https://github.com/zeromq/erlzmq2/tarball/a2b0693 ) erlang-erlzmq2.x86_64: E: explicit-lib-dependency erlang-stdlib ^^^ That's ok for now. 3 packages and 0 specfiles checked; 1 errors, 7 warnings. work ~/Desktop: + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. I have the only proposal - please, invoke "rebar compile" with "-v" switch to raise verbosity level. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. - The License field in the package spec file MUST match the actual license (MIT and BSD, see c_src/vector.[ch] sources) + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL. sulaco ~/rpmbuild/SOURCES: sha256sum zeromq-erlzmq2-a2b0693.tar.gz* d6487a3c02d2ea379a959a92af0c497cdd174ea1ffacceedebd2030e167e1445 zeromq-erlzmq2-a2b0693.tar.gz d6487a3c02d2ea379a959a92af0c497cdd174ea1ffacceedebd2030e167e1445 zeromq-erlzmq2-a2b0693.tar.gz.1 sulaco ~/rpmbuild/SOURCES: + The package successfully compiles and builds into binary rpms on at least one primary architecture. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files in some of the dynamic linker's default paths. + The package does NOT bundle copies of system libraries. 0 The package is not designed to be relocatable. - The package MUST own all directories that it creates. You missed the only one - %{_libdir}/erlang/lib/%{real_name}-%{version}/include . + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No C header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 No devel sub-package. + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8. Please fix/comment issues mentioned above and I'll continue.
Fixes: * git tags in changelog * BSD license in spec * missing dir in %files section * comment about downloading upstream sources * verbose rebar output Update sources from latest commit (with bugfix in it) Koji build ok: https://koji.fedoraproject.org/koji/taskinfo?taskID=2994533 SPEC: http://mkulemin.fedorapeople.org/packages/erlang-erlzmq2.spec
Ok, good. I don't see any other issues so this package is APPROVED
New Package SCM Request ======================= Package Name: erlang-erlzmq2 Short Description: Erlang binding for ZeroMQ library Owners: mkulemin Branches: f14 f15 f16 InitialCC:
It is too early to request f16 branches; we haven't even released f15 yet. Otherwise, Git done (by process-git-requests).
erlang-erlzmq2-0-1.20110411gitec60b1d.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/erlang-erlzmq2-0-1.20110411gitec60b1d.fc14
erlang-erlzmq2-0-1.20110411gitec60b1d.fc14 has been pushed to the Fedora 14 testing repository.
erlang-erlzmq2-0-1.20110411gitec60b1d.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/erlang-erlzmq2-0-1.20110411gitec60b1d.fc15
erlang-erlzmq2-0-1.20110411gitec60b1d.fc15 has been pushed to the Fedora 15 testing repository.
erlang-erlzmq2-0-1.20110411gitec60b1d.fc14 has been pushed to the Fedora 14 stable repository.
erlang-erlzmq2-0-1.20110411gitec60b1d.fc15 has been pushed to the Fedora 15 stable repository.