Bug 691226 - Review Request: perl-HTML-Form - Class that represents an HTML form element
Summary: Review Request: perl-HTML-Form - Class that represents an HTML form element
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Iain Arnell
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-27 16:37 UTC by Emmanuel Seyman
Modified: 2014-01-28 13:01 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-04-02 09:55:33 UTC
Type: ---
Embargoed:
iarnell: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Emmanuel Seyman 2011-03-27 16:37:09 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-HTML-Form/perl-HTML-Form.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-HTML-Form/perl-HTML-Form-6.00-1.fc14.src.rpm
Description:
Objects of the HTML::Form class represents a single HTML <form> ... </form>
instance. A form consists of a sequence of inputs that usually have names,
and which can take on various values. The state of a form can be tweaked
and it can then be asked to provide HTTP::Request objects that can be
passed to the request() method of LWP::UserAgent.

This is used by perl-libwww-perl 6.xx but has not been submitted to Fedora as far as I can tell.

Koji scratch build : http://koji.fedoraproject.org/koji/taskinfo?taskID=2950823

Comment 1 Iain Arnell 2011-03-29 03:39:38 UTC
There's a few requires that weren't automatically detected and need to be manually declared in the spec:

perl(HTML::TokeParser)
perl(HTTP::Request) >= 6
perl(HTTP::Request::Common) >= 6

But otherwise, a nice clean package. APPROVED.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2950823

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
45fe6121ea15fbc3fad4ab6851d2dbf1c72971d1 HTML-Form-6.00.tar.gz
45fe6121ea15fbc3fad4ab6851d2dbf1c72971d1 HTML-Form-6.00.tar.gz.srpm

Final provides / requires are sane:

======> perl-HTML-Form-6.00-1.fc16.noarch.rpm <======
====> rpmlint
perl-HTML-Form.noarch: W: spelling-error %description -l en_US UserAgent -> User Agent, User-agent, Superagency
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
====> provides
perl(HTML::Form) = 6.00
perl-HTML-Form = 6.00-1.fc16
perl(HTML::Form::FileInput)  
perl(HTML::Form::IgnoreInput)  
perl(HTML::Form::ImageInput)  
perl(HTML::Form::Input)  
perl(HTML::Form::KeygenInput)  
perl(HTML::Form::ListInput)  
perl(HTML::Form::SubmitInput)  
perl(HTML::Form::TextInput)  
====> requires
perl(Carp)  
perl(Encode)  
perl(:MODULE_COMPAT_5.12.3)  
perl(strict)  
perl(URI)  
perl(vars)  
====> obsoletes
====> conflicts

======> perl-HTML-Form-6.00-1.fc16.src.rpm <======
====> rpmlint
perl-HTML-Form.src: W: spelling-error %description -l en_US UserAgent -> User Agent, User-agent, Superagency
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
====> provides
====> requires
perl(ExtUtils::MakeMaker)  
perl(HTML::TokeParser)  
perl(HTTP::Request) >= 6
perl(HTTP::Request::Common) >= 6
perl(Test::More)  
perl(URI)  
====> obsoletes
====> conflicts


====> mock install
INFO: mock.py version 1.1.9 starting...
State Changed: init plugins
INFO: selinux enabled
State Changed: start
Mock Version: 1.1.9
INFO: Mock Version: 1.1.9
State Changed: lock buildroot
INFO: installing package(s): perl-HTML-Form-6.00-1.fc16.noarch.rpm
INFO: 
================================================================================
 Package         Arch    Version      Repository                           Size
================================================================================
Installing:
 perl-HTML-Form  noarch  6.00-1.fc16  /perl-HTML-Form-6.00-1.fc16.noarch   63 k
Installing for dependencies:
 perl-URI        noarch  1.58-1.fc16  fedora                              102 k

Transaction Summary
================================================================================
Install       2 Package(s)

Total size: 164 k
Installed size: 249 k

Installed:
  perl-HTML-Form.noarch 0:6.00-1.fc16                                           

Dependency Installed:
  perl-URI.noarch 0:1.58-1.fc16                                                 


State Changed: unlock buildroot

Comment 2 Marcela Mašláňová 2011-03-29 06:09:28 UTC
After you'll create this package, could you also rebuild WWW::Mechanize? It depends on this package.

Comment 3 Emmanuel Seyman 2011-03-29 06:54:38 UTC


(In reply to comment #1)
> 
> perl(HTML::TokeParser)
> perl(HTTP::Request) >= 6
> perl(HTTP::Request::Common) >= 6

I've added these to the spec file.

Spec URL:
http://people.parinux.org/~seyman/fedora/perl-HTML-Form/perl-HTML-Form.spec
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-HTML-Form/perl-HTML-Form-6.00-2.fc14.src.rpm

> But otherwise, a nice clean package. APPROVED.

Thanks, Ian.

New Package SCM Request
=======================
Package Name: perl-HTML-Form
Short Description: Class that represents an HTML form element
Owners: eseyman
Branches: f14 f15
InitialCC: perl-sig

(In reply to comment #2)
>
> After you'll create this package, could you also rebuild WWW::Mechanize? It
> depends on this package.

Will do.

Comment 4 Jason Tibbitts 2011-03-29 12:12:28 UTC
Git done (by process-git-requests).

Comment 5 Emmanuel Seyman 2011-04-02 09:55:33 UTC
Imported and build on rawhide.

(In reply to comment #2)
>
> After you'll create this package, could you also rebuild WWW::Mechanize? It
> depends on this package.

Done.

Comment 6 Lubomir Rintel 2014-01-28 11:43:51 UTC
Package Change Request
======================
Package Name: perl-HTML-Form
New Branches: epel7
Owners: lkundrak eseyman

> Emmanuel Seyman isn't an EPEL user and is happy for others to branch
> and build his packages, and they can add him as co-maintainer:
> https://bugzilla.redhat.com/show_bug.cgi?id=485897#c9

Comment 7 Gwyn Ciesla 2014-01-28 13:01:05 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.