Bug 691841
| Summary: | content upload lets you upload same file multiple times if the checksums are different. | ||
|---|---|---|---|
| Product: | [Retired] Pulp | Reporter: | Preethi Thomas <pthomas> |
| Component: | z_other | Assignee: | Pradeep Kilambi <pkilambi> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Preethi Thomas <pthomas> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-08-16 14:02:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 641987 | ||
$ sudo pulp-admin content upload --repoid=myupload --dir=files/ -v
* Starting Content Upload
* Performing Content Uploads to Pulp server
Successfully uploaded [testup2.txt] to server
* Performing Repo Associations
Content association Complete for Repo [myupload]:
Packages:
None
Files:
testup2.txt
* Content Upload complete.
$ echo 3 > files/testup2.txt
$ sudo pulp-admin content upload --repoid=myupload --dir=files/ -v
* Starting Content Upload
* Performing Content Uploads to Pulp server
Successfully uploaded [testup2.txt] to server
* Performing Repo Associations
Content association Complete for Repo [myupload]:
Packages:
None
Files:
testup2.txt
* Content Upload complete.
$ sudo pulp-admin repo content --id=myupload
+------------------------------------------+
Contents of myupload
+------------------------------------------+
Packages in myupload:
none
Errata in myupload:
none
Files in myupload:
test4.iso
test2.iso
testup2.txt
testup2.txt
$ sudo pulp-admin content upload --repoid=myupload --dir=files/ -v
* Starting Content Upload
* Performing Content Uploads to Pulp server
Content [testup2.txt] already exists on the server with checksum [1121cfccd5913f0a63fec40a6ffd44ea64f9dc135c66634ba001d10bcf4302a2]
* Performing Repo Associations
Content association Complete for Repo [myupload]:
Packages:
None
Files:
testup2.txt
* Content Upload complete.
$ sudo pulp-admin repo content --id=myupload
+------------------------------------------+
Contents of myupload
+------------------------------------------+
Packages in myupload:
none
Errata in myupload:
none
Files in myupload:
test4.iso
test2.iso
testup2.txt
testup2.txt
from what I see this is working exactly as intended. When the checksums are different we allow the upload; if a file with same checksum exists we skip the upload with a warning.
misunderstanding on my part moving to verified Closing with Community Release 15 pulp-0.0.223-4. |
Description of problem: I am able to upload the same file multiple time to pulp-server if the checksums are different [root@preethi upload]# rpm -q pulp pulp-0.0.158-1.fc14.noarch 1. Upload a file test.txt to a repo 2. Now edit the the test.txt so that the checksum is different from the first upload. 3. Now upload test.txt again 4. run repo content and check the manifest file in the repo [root@preethi upload]# pulp-admin repo create --id=upload Successfully created repository [ upload ] [root@preethi upload]# pulp-admin content upload -r upload -v --dir=/root/upload/ --nosig * Starting Package Upload * Performing Package Uploads to Pulp server Successfully uploaded [test2.txt] to server Successfully uploaded [test.txt] to server Successfully uploaded [gofer-0.27-1.fc14.noarch.rpm] to server * Performing Repo Associations Package association Complete for Repo [upload]: Packages: gofer-0.27-1.fc14.noarch.rpm Files: test2.txt test.txt * Content Upload complete. [root@preethi upload]# cat /var/lib/pulp/repos/upload/MANIFEST 8ff2165791201edf1f3ed70518d8b30115a1272eabe231a50fe50445a9ff19ae test2.txt 661a151fd58bdf8778ee37adce5cccc7c6cfe2e2780d0d7f7a14144984144dc8 test.txt [root@preethi upload]# After editing test.txt [root@preethi upload]# pulp-admin content upload -r upload -v --dir=/root/upload/ --nosig * Starting Package Upload * Performing Package Uploads to Pulp server Package [test2.txt] already exists on the server with checksum [8ff2165791201edf1f3ed70518d8b30115a1272eabe231a50fe50445a9ff19ae] Successfully uploaded [test.txt] to server Package [gofer-0.27-1.fc14.noarch.rpm] already exists on the server with checksum [83c7fda05c52a1e49c67dccecb3841b689675fd98259370cf36c4e9c95bed195] * Performing Repo Associations Package association Complete for Repo [upload]: Packages: gofer-0.27-1.fc14.noarch.rpm Files: test2.txt test.txt * Content Upload complete. [root@preethi upload]# cat /var/lib/pulp/repos/upload/MANIFEST 8ff2165791201edf1f3ed70518d8b30115a1272eabe231a50fe50445a9ff19ae test2.txt 661a151fd58bdf8778ee37adce5cccc7c6cfe2e2780d0d7f7a14144984144dc8 test.txt 119e74eb7308817acef45688fac0e33262b960802f5fda45c55cd6093dd9d343 test.txt [root@preethi upload]# pulp-admin repo content --id=upload +------------------------------------------+ Contents of upload +------------------------------------------+ Packages in upload: gofer-0.27-1.fc14.noarch.rpm Errata in upload: none Files in upload: test2.txt test.txt test.txt