Description of problem: I'm trying to build the latest version of coq. The build is failing on F-15. Coq upstream claims it is a known bug in the camlp5 pretty printer. The upstream discussion is here (may require registration): http://www.lix.polytechnique.fr/coq/bugs/show_bug.cgi?id=2468 That bug says the patch to fix the problem is as follows (may be whitespace mangled due to cutting and pasting between browser tabs): Index: etc/pr_o.ml =================================================================== RCS file: /home/ROCQ/aosteroc/deraugla/repository/camlp5/etc/pr_o.ml,v retrieving revision 6.48 retrieving revision 6.49 diff -r6.48 -r6.49 2c2 < (* $Id: pr_o.ml,v 6.48 2010-11-21 17:17:45 deraugla Exp $ *) --- > (* $Id: pr_o.ml,v 6.49 2010-12-06 10:31:00 deraugla Exp $ *) 2083c2083 < | None -> patt pc p ] --- > | None -> pprintf pc "~%p" patt p ] Version-Release number of selected component (if applicable): ocaml-camlp5-6.02.1-2.fc15.x86_64 How reproducible: Always Steps to Reproduce: 1. Attempt to compile coq (vanilla upstream tarball shows the problem) 2. 3. Actual results: File "toplevel/mltop.optml", line 112, characters 63-64: Error: The function applied to this argument has type ?warn:bool -> System.physical_path * string This argument cannot be applied without label make[1]: *** [toplevel/mltop.cmx] Error 2 Expected results: Successful compilation. Additional info:
FTR, the latest version of Coq (8.3pl1) compiles with the latest version of camlp5 (6.02.2 + the three patches listed on the camlp5 website). I guess you are using camlp5 6.02.1, which needs the matching patches still available from [1]. [1] http://pauillac.inria.fr/~ddr/camlp5/distrib/src/
Jerry, if you are in the Fedora packager group, please apply to co-maintain ocaml-camlp5. That way you can add these patches yourself.
(In reply to comment #2) > Jerry, if you are in the Fedora packager group, please > apply to co-maintain ocaml-camlp5. That way you can add > these patches yourself. Actually, coq upstream provided a workaround for this bug. Plus, I don't know that I'm competent to maintain any core ocaml packages, given my almost total lack of knowledge of things ocaml. I think it would be better for me to apply the coq workaround, to be removed once a fixed camlp5 makes it into Fedora.
Even though I still don't want to comaintain ocaml-camlp5, I would like to see us get a version with this bug fixed. I'm going to commit the changes necessary to move to version 6.02.3, which fixes all the (known) bugs I care about as coq comaintainer.
Thanks for pushing a fix. Can we close this bug?
I'd like to update ocaml-camlp5 for F16 too, unless you object. Since I'm not a maintainer of this package, I'll need you to do a build override for me so I can rebuild coq. (There are 2 ocaml-camlp5 symbols that coq depends on whose hashes are different in this new version.) I can ask you for the override here or in email, your choice. If email, then we might as well close this bug, sure. I'm building the ocaml-camlp5 -> coq chain in Rawhide right now. If all goes well with that, I'll build ocaml-camlp5 for F16 afterwards and then contact you. Also, I believe that coq is the only package that requires a rebuild due to this update. At least, I had repoquery check everything ocaml-camlp5 provides, and coq was the only dependency I turned up.
Yes please, go for it. If you were co-maint then you should be able to request build overrides too?
Zing! :-) Yes, you're right, But I'm trying really hard to NOT pick up more packages to comaintain, because I've got a couple dozen packages waiting in the wings that I want to push into Fedora. Plus, I'm still pretty uncomfortable with ocaml. I've got to learn that language one of these days.... I'm ready for the F16 buildroot override any time now, please. Thanks.
Done ... $ bodhi --buildroot-override=ocaml-camlp5-6.02.3-1.fc16 Notes: Password for rjones: Notes: Your buildroot override has been successfully tagged. It may take up to 20 minutes for the buildroot to regenerate. You can wait for the new buildroot by running `koji wait-repo f16-build`
ocaml-camlp5-6.02.3-1.fc16,coq-8.3pl2-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ocaml-camlp5-6.02.3-1.fc16,coq-8.3pl2-3.fc16
Thank you. I'm all done with the buildroot override. Sorry for being such a pain about comaintaining.
Package ocaml-camlp5-6.02.3-1.fc16, coq-8.3pl2-3.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing ocaml-camlp5-6.02.3-1.fc16 coq-8.3pl2-3.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2011-15177 then log in and leave karma (feedback).
ocaml-camlp5-6.02.3-1.fc16, coq-8.3pl2-3.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report.