Spec URL: http://jamesni.fedorapeople.org/zanata-python-client/zanata-python-client.spec SRPM URL: http://jamesni.fedorapeople.org/zanata-python-client/zanata-python-client-1.2.0-1.fc13.src.rpm Description: Hi, I just finished the packaging for zanata-python-client. Zanata Python client is a client that working with Zanata server for creating project and iteration, retrieving info of all the projects on Zanata server, retrieving info of single project or single iteration. It provides functions for pushing or pulling the publican files from/to Zanata server. It also includes functions supporting software projects. Zanata Python client also include a library which provide basic operations for communicating with Zanata server.
1. In Field Summary: Replace "Flies" with "Zanata" 2. In Field URL: (optional) you may consider use github project page of zanata-python-client 3. Duplicated: "Requires: python-httplib2", please remove the unneeded one. 4. For users who have installed flies-python-client, we need "Provides" and "Obsoletes" to helping them to do the conversion. Specifically, add two following lines: Provides: flies-python-client = %{version}-%{release} Obsoletes: flies-python-client < 1.3 5. In changelog section, both version and release should be provided: That is, 1.2.0-1, not 1.2.0 Regards.
6. It's good to keep "flies" as a command, just make it a wrapper to execute zanata
Hi, Dean Thanks for your review and comment, i have update the package and spec file based on your comment Spec URL: http://jamesni.fedorapeople.org/zanata-python-client/zanata-python-client.spec SRPM URL: http://jamesni.fedorapeople.org/zanata-python-client/zanata-python-client-1.2.1-1.fc13.src.rpm Best Regards
Created attachment 489271 [details] Patch that address rpmlint errors
Output of: find . -name "zanata*.rpm" -exec rpmlint '{}' \; zanata-python-client.noarch: E: explicit-lib-dependency python-httplib2 zanata-python-client.noarch: E: explicit-lib-dependency python-polib zanata-python-client.noarch: W: self-obsoletion flies-python-client < 1.3 obsoletes flies-python-client=1.2.1-1.el6 1 packages and 0 specfiles checked; 2 errors, 1 warnings. zanata-python-client.src:51: W: macro-in-%changelog %doc zanata-python-client.src: W: no-rhel-conditional zanata-python-client.spec 1 packages and 0 specfiles checked; 0 errors, 2 warnings. I should be blame on: zanata-python-client.noarch: W: self-obsoletion flies-python-client < 1.3 obsoletes flies-python-client = 1.2.1-1.el6 I have provide a patch that address the rpmlint errors and warnings, i.e. zanata-python-client.src:51: W: macro-in-%changelog %doc and zanata-python-client.noarch: W: self-obsoletion flies-python-client < 1.3 obsoletes flies-python-client=1.2.1-1.el6
However, when running zanata list --url <flies-server>, it outputs something like: Overwrite the url of server with command line options Loading zanata/flies user config from /home/dchen/.config/flies.ini zanata/flies server: http://flies-devel.englab.bne.redhat.com/flies-test Traceback (most recent call last): File "/usr/bin/zanata", line 26, in <module> client.run() File "/usr/lib/python2.6/site-packages/zanataclient/zanata.py", line 1365, in run file = open('./VERSION-FILE', 'rb') IOError: [Errno 2] No such file or directory: './VERSION-FILE' Perhaps you give wrong path to VERSION-FILE.
Hi, Dean I have apply your patch and fix path issue of VERSION-FILE, i have update the package to 1.2.2, this new package include a make file for generating tar ball. Also, if you want to running zanata command directly under the folder extract from tar ball, you should copy the VERSION-FILE to zanataclient folder. Spec URL: http://jamesni.fedorapeople.org/zanata-python-client/zanata-python-client.spec SRPM URL: http://jamesni.fedorapeople.org/zanata-python-client/zanata-python-client-1.2.2-1.fc13.src.rpm
Hi, Dean I just update the setup.py so the tall ball have correct VERSION-FILE under zanataclient folder now. But if you use git and running zanata command, you still need to copy the VERSION-FILE to zanataclient. Spec URL: http://jamesni.fedorapeople.org/zanata-python-client/zanata-python-client.spec SRPM URL: http://jamesni.fedorapeople.org/zanata-python-client/zanata-python-client-1.2.2-1.fc13.src.rpm
MUST: + rpmlint output is acceptable. + Package meets naming and packaging guidelines. + Package meets licensing guidelines, and match the source license. + Source files match upstream. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + BuildRoot is proper. + BuildRequires are proper. + Requires are proper. + %install starts with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) + %clean contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT) + locale is handle by %find_lang. + %doc files present. + %doc files do not interfere runtime application. + Macros are consistently used. + Package builds in koji. + Package contains code or permissible content. + Package installed properly. + No system library is bundled. + Not relocatable, unless proper justification is presented. + %files section must include a %defattr(...) line, and file permissions are correct. + No duplication in %files + File names are in valid UTF-8. + Own all directory it creates. + Files or directories are not owned by other packages. + Large documentation files goes in a -doc subpackage. + Static libraries in -static package. SHOULD: + License text are in separate files. + Translations for supported non-English languages if available. + Package build in mock. + Package can build in all supported architectures. + Package runs properly. + Scriptlets are sane. + No direct files dependencies, unless they are in either /etc, /bin, /sbin, /usr/bin, or /usr/sbin - Have man pages for each binary You may consider adding man pages for your packages. But it's not a blocker of review. APPROVED
New Package SCM Request ======================= Package Name: zanata-python-client Short Description: zanata-python-client is a client that communicate with Zanata server. Owners: jamesni Branches: f13 f14 f15 el5 el6 InitialCC: dchen petersen
This ticket seems to be assigned to the owner of the package. It should be assigned to the reviewer, and you can't review your own packages. Please fix and re-raise the fedora-cvs flag.
Done
Git done (by process-git-requests).