Spec URL: http://goldmann.fedorapeople.org/package_review/rubygem-kwalify.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/rubygem-kwalify-0.7.2-1.fc14.src.rpm Description: Kwalify is a parser, schema validator, and data binding tool for YAML and JSON. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2963270
I'll review it
The spec has one problem with the compliance with the guidelines. Please, fix this issue. * Add ----%define ruby_sitelib %(ruby -rrbconfig -e "puts Config::CONFIG['sitelibdir']")---- to the spec rmplint is silent: rpmlint rubygem-kwalify-0.7.2-1.fc14.src.rpm rubygem-kwalify.src: W: spelling-error Summary(en_US) validator -> invalidator, validation, validate rubygem-kwalify.src: W: spelling-error %description -l en_US validator -> invalidator, validation, validate ---- This two may be omitted. 1 packages and 0 specfiles checked; 0 errors, 2 warnings. I can't find any other issues.
If I may suggest, it is better to use "gem install --bindir DIR" instead of the magical four lines bellow gem install. Also the "rm -rf %{buildroot}" at the top of %install and %clean section are no longer needed: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean i.e. whole %clean section could be removed in your case.
Oxana, Vit, Thank you for input, I'll shortly have updated version for you.
Updated files: Spec URL: http://goldmann.fedorapeople.org/package_review/rubygem-kwalify.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/rubygem-kwalify-0.7.2-2.fc14.src.rpm Oxana, it looks like the ruby_sitelib line is not required for rubygems (my previous rubygems submitted and accepted for Fedora didn't have this line). It's only required for pure Ruby applications. Vit, I cleaned the spec file. Thank you!
(In reply to comment #5) > Updated files: > > Spec URL: http://goldmann.fedorapeople.org/package_review/rubygem-kwalify.spec > SRPM URL: > http://goldmann.fedorapeople.org/package_review/rubygem-kwalify-0.7.2-2.fc14.src.rpm > > Oxana, it looks like the ruby_sitelib line is not required for rubygems (my > previous rubygems submitted and accepted for Fedora didn't have this line). > It's only required for pure Ruby applications. That is true. You don't need the line. > Vit, I cleaned the spec file. The "find %{buildroot}%{geminstdir}/bin -type f | xargs chmod a+x" is not required IMO. * Licensing - What is the reason for "and LGPLv2"? I see everywhere mentioned just MIT * Test suite - It would be nice if you could execute the testsuite during build process. * setup.rb could be move into -doc subpackage, since it is not essential for runtime
(In reply to comment #6) > The "find %{buildroot}%{geminstdir}/bin -type f | xargs chmod a+x" is not > required IMO. Checked, confirmed, removed. > * Licensing > - What is the reason for "and LGPLv2"? I see everywhere mentioned just MIT The setup.rb file has this license. Moved the license to -doc package, see below. > * Test suite > - It would be nice if you could execute the testsuite during build process. Agree. I looked at the tests and it failed for me locally, I tried to find the workaround to create a patch, but it can take more time than I want to spend on this. > * setup.rb could be move into -doc subpackage, since it is not essential > for runtime Agree and done. Updated files: Spec URL: http://goldmann.fedorapeople.org/package_review/rubygem-kwalify.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/rubygem-kwalify-0.7.2-3.fc14.src.rpm
Ping? I'm quite short on time as this is a dependency of my project. Thanks!
Oxana? Are you going to finish the review? Or should I do it?
Vit, you were so active that I can't say anything else. :) So this package is APPROVED.
Oxana, Vit -- thank you very much! New Package SCM Request ======================= Package Name: rubygem-kwalify Short Description: A parser and schema validator for YAML and JSON Owners: goldmann Branches: f13 f14 f15 el5 el6
Git done (by process-git-requests).
rubygem-kwalify-0.7.2-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-kwalify-0.7.2-3.fc14
rubygem-kwalify-0.7.2-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-kwalify-0.7.2-3.fc13
rubygem-kwalify-0.7.2-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/rubygem-kwalify-0.7.2-3.fc15
rubygem-kwalify-0.7.2-3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/rubygem-kwalify-0.7.2-3.el5
rubygem-kwalify-0.7.2-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/rubygem-kwalify-0.7.2-3.el6
rubygem-kwalify-0.7.2-3.fc15 has been pushed to the Fedora 15 testing repository.
rubygem-kwalify-0.7.2-3.fc15 has been pushed to the Fedora 15 stable repository.
rubygem-kwalify-0.7.2-3.fc13 has been pushed to the Fedora 13 stable repository.
rubygem-kwalify-0.7.2-3.fc14 has been pushed to the Fedora 14 stable repository.
rubygem-kwalify-0.7.2-3.el5 has been pushed to the Fedora EPEL 5 stable repository.
rubygem-kwalify-0.7.2-3.el6 has been pushed to the Fedora EPEL 6 stable repository.