Bug 692727 - Deja Dup remains paused waiting for a network connection after update to NM 0.9
Summary: Deja Dup remains paused waiting for a network connection after update to NM 0.9
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: deja-dup
Version: 15
Hardware: i686
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Rahul Sundaram
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: https://fedoraproject.org/wiki/Common...
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-31 23:26 UTC by Rob Garth
Modified: 2011-04-21 05:31 UTC (History)
9 users (show)

Fixed In Version: deja-dup-18.1.1-1.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-04-21 05:31:51 UTC
Type: ---


Attachments (Terms of Use)
Updated patch for NM 0.9 (1.60 KB, patch)
2011-04-11 13:24 UTC, Jirka Klimes
no flags Details | Diff
Build error when passing --enable-maintainer-mode (75.30 KB, application/octet-stream)
2011-04-12 11:38 UTC, Chris Smart
no flags Details
Deja-Dup 18.1 (9.49 MB, application/x-rpm)
2011-04-15 05:02 UTC, Rob Garth
no flags Details

Description Rob Garth 2011-03-31 23:26:50 UTC
Description of problem:

I am connected to the network and have no connectivity problems. Backups wont run as deju dup fails to detect the network connection.

Version-Release number of selected component (if applicable):

Name        : deja-dup
Arch        : i686
Version     : 17.92
Release     : 1.fc15


How reproducible:

Everytime

Steps to Reproduce:
1. Setup a network backup with Deja-dup and try and run
  
Actual results:
No backup, but a continual poll from deja-dup (evident through a strace)

Expected results:
Successful Backup

Additional info:
selinux is off.

Comment 1 Rahul Sundaram 2011-03-31 23:34:26 UTC
Does downgrading to the older version fix this problem?  I am wondering if this change was because of the recent NM update.  Would you do a yum downgrade and confirm that it works?

Comment 2 Rob Garth 2011-04-01 00:06:50 UTC
No it doesn't. I actually think this might be a problem between vala and network-manager looking into it closer. The deja-dup code simply reads:

if (Network.get().connected)
      resume();
    else
      pause(_("Paused (no network)"));
}

It seems the NetworkManager upgrade may have broken this check.

Comment 3 Rob Garth 2011-04-01 00:09:24 UTC
Downgrading NetworkManager has fixed the problem for me.

Does this bug need to be reported against NetworkManager?

Comment 4 Rahul Sundaram 2011-04-01 00:12:55 UTC
Reassigning.  Dan,  let me know if there is something I need to do about this.

Comment 5 Fedora Update System 2011-04-06 21:38:51 UTC
deja-dup-17.92-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/deja-dup-17.92-2.fc15

Comment 6 Rob Garth 2011-04-07 00:39:17 UTC
Tried update. Problem is still there.

Comment 7 Fedora Update System 2011-04-07 02:22:17 UTC
Package deja-dup-17.92-3.fc15:
* should fix your issue,
* was pushed to the Fedora 15 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing deja-dup-17.92-3.fc15'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/deja-dup-17.92-3.fc15
then log in and leave karma (feedback).

Comment 8 Rob Garth 2011-04-07 03:53:59 UTC
This release does not fix the problem. Sorry. Have left a comment at the URL provided.

Comment 9 Chris Smart 2011-04-09 05:08:00 UTC
I've just confirmed that the new 18.0 release does not fix the problem either, even though it includes the network manager 0.9 patch.

-c

Comment 10 Jirka Klimes 2011-04-11 13:24:51 UTC
Created attachment 491233 [details]
Updated patch for NM 0.9

New states weren't updated in handle_signal() function. These bits are already upstream:  http://bazaar.launchpad.net/~deja-dup-team/deja-dup/20/revision/887

Comment 11 Jirka Klimes 2011-04-11 13:35:46 UTC
The patch replaces the previous nm09.patch in Fedora git.

Comment 12 Rahul Sundaram 2011-04-11 22:11:24 UTC
Chris, 

Would you mind testing and applying this patch?  Don't have a network to test now.

Comment 13 Michael Terry 2011-04-11 22:58:28 UTC
Hey folks.  The patch will be upstream in 18.1.  I have some concern that the patch is not being applied correctly in the rpm because without that second commit it should not compile at all.  If you are patching the vala sources, make sure to pass --enable-maintainer-mode to allow the c sources to be regenerated.

Comment 14 Rob Garth 2011-04-11 23:55:35 UTC
Even with --enable-maintainer mode the source fails to compile with this patch:

libnotify.vapi:22.37-22.39: error: The symbol `Gdk' could not be found
		public void set_icon_from_pixbuf (Gdk.Pixbuf icon);
		                                  ^^^

Comment 15 Rahul Sundaram 2011-04-12 00:12:17 UTC
Adding CommonBugs as a keyword for tracking.  We need to get this documented in the wiki for the beta.  I don't think blocking the release itself is necessary since it can be fixed with an upstream 18.1 release in the worst case within a few days.

For reference, the release schedule is at 

http://fedoraproject.org/wiki/Releases/15

Comment 16 Chris Smart 2011-04-12 11:25:26 UTC
I manually applied the updated patch to source and created a new src rpm which builds for me using f15 mock build, however the problem persists (tested under F15 live CD).

http://csmart.fedorapeople.org/deja-dup/deja-dup-18.0-2.fc15.src.rpm

-c

Comment 17 Chris Smart 2011-04-12 11:38:46 UTC
Created attachment 491462 [details]
Build error when passing --enable-maintainer-mode

Build log from mock build with updated NM patch and passing --enable-maintainer-mode for vala.

Comment 18 Rob Garth 2011-04-12 12:34:58 UTC
Unfortunately I can confirm. I built Chris's SRPM with the patch pre-applied to the source and the network connections still remains undetected.

Comment 19 Michael Terry 2011-04-12 12:48:04 UTC
I will work on this tonight and test with the latest 0.9 (my development machine is Ubuntu 11.04 so I don't have 0.9 yet, which is why I never noticed the problem myself).  Hopefully I can get it working.  I'll release 18.1 once I do.

As for the compile problems with --enable-maintainer-mode, I'm not sure why that would happen.  Deja Dup uses its own libnotify.vapi file in the vapi/ directory, with its own libnotify.deps that includes gdk-pixbuf-2.0...  Is there some difference between Fedora and Ubuntu valac?  They should both be 0.12.

The issue with --enable-maintainer-mode needn't block this bug, since I can release 18.1, but it should really be fixed long term unless you're comfortable patching C sources in the future instead of the Vala sources.

Comment 20 Rob Garth 2011-04-12 12:57:22 UTC
I built 19.0 from launchpad (the current development branch). It correctly detects network state and works.

Comment 21 Chris Smart 2011-04-13 00:53:55 UTC
deja-dup 18.1 is out, which is supposed to have the fixes applied. I will build this, test, and report back.

-c

Comment 22 Chris Smart 2011-04-13 12:03:42 UTC
(In reply to comment #21)
> deja-dup 18.1 is out, which is supposed to have the fixes applied. I will build
> this, test, and report back.

OK, well 18.1 doesn't seem to work for me either. I did a mock build and tested on F15 live CD. No joy.

-c

Comment 23 Michael Terry 2011-04-13 12:28:45 UTC
Guh...  I tested with NM 0.9 and it worked for me.

Comment 24 Michael Terry 2011-04-15 02:47:36 UTC
Why are we getting conflicting reports?  Rob tested 19.0 (which had the same patch that 18.1 has) and I tested 18.1 fine.  But Chris tested 18.1 and it didn't work.  Can we get more results?

I'm willing to help here, but I'm not sure what the next step is.

Comment 25 Rob Garth 2011-04-15 03:18:50 UTC
Michael did you build deja-dup from upstream or from the srpm that Chris provided?

I think that is where the conflicting reports are coming from.

Built from upstream it works.

Comment 26 Rob Garth 2011-04-15 04:31:53 UTC
Just to double check I pulled the 18 branch from Launchpad,and the problem is fixed. Sorry Chris but it seems the problem might now lie in the SRPM you have provided.

Comment 27 Chris Smart 2011-04-15 04:44:53 UTC
Sorry if that's the case! I'll create a new SRPM from 18.1 tarball, and try again. If someone has a SRPM already, then let me know and I'll compare that.

Rob, how were you testing it? I was doing a mock build for Fedora 15 x86_64 on my Fedora 14 machine, and then installing the resulting RPM in Fedora 15 alpha release system under VirtualBox. I then kicked up Deja Dup and created a backup over SSH, which pauses.

-c

Comment 28 Rob Garth 2011-04-15 04:48:06 UTC
No I have been downloading the upstream source and building it on the system, without using mock, or even building an RPM.

I have recently switched to using F15 as my primary OS.

Comment 29 Rob Garth 2011-04-15 05:02:20 UTC
Created attachment 492279 [details]
Deja-Dup 18.1

SRPM of the 18.1 release of deja-dup

Comment 30 Rob Garth 2011-04-15 05:03:11 UTC
I have uploaded an SRPM which builds with mock for me.

Comment 31 Chris Smart 2011-04-15 13:47:21 UTC
(In reply to comment #30)
> I have uploaded an SRPM which builds with mock for me.

Hey Rob,

I did a mock build of your SRPM and it also works for me (although it's not using the same source as 18.1, and backups across SSH don't _actually_ occur).

Anyway, I also used your spec file with the 18.1 source tarball (spectool -g deja-dup.spec) from deja-dup on launchpad, built and tested this - it also works on my freshly installed F15 test system (and backups actually run).

I compared your spec file to mine and it was identical except for yours having a newer build number. So I must have made a mistake with something, for which I apologise.

Thanks to you (and Michael, of course) for your help! I've committed 18.1 for Rawhide. Perhaps some others can also test?

Cheers,
Chris

Comment 32 Adam Williamson 2011-04-15 15:10:34 UTC
for Rawhide, why not just commit 19? it's Rawhide! :)

Comment 33 Michael Terry 2011-04-15 18:16:42 UTC
Look, I'm really sorry, but I just realized why we may have had different results.  The 18.1 tarball had the patch applied to the Vala sources but did not include regenerated C sources (I have to figure out how that happened to avoid it in the future).

I just released 18.1.1 with confirmed patched C code and a bonus Basque translation update.  :-/

Adam, 19.0 isn't released yet.

Comment 34 Chris Smart 2011-04-16 02:20:42 UTC
Thanks Michael. This seems to work and I have pushed this new release to Rawhide. I do some more test builds for F15 and push.

-c

Comment 35 Fedora Update System 2011-04-16 02:41:55 UTC
deja-dup-18.1.1-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/deja-dup-18.1.1-1.fc15

Comment 36 Chris Smart 2011-04-16 12:49:00 UTC
Please confirm that the build in F15 testing/Rawhide fixes the problem, so that I can close this bug. Thanks!

-c

Comment 37 Rob Garth 2011-04-16 13:09:22 UTC
I can confirm this package works. Please close.

Comment 38 Fedora Update System 2011-04-17 02:03:29 UTC
Package deja-dup-18.1.1-1.fc15:
* should fix your issue,
* was pushed to the Fedora 15 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing deja-dup-18.1.1-1.fc15'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/deja-dup-18.1.1-1.fc15
then log in and leave karma (feedback).

Comment 39 Rahul Sundaram 2011-04-17 06:40:45 UTC
Michael Terry,  Christopher Smart and Rob Garth  -  Thanks for coordinating.  Much appreciated.

Comment 40 Fedora Update System 2011-04-21 05:31:45 UTC
deja-dup-18.1.1-1.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.