Spec URL: http://fedorapeople.org/~iarnell/review/perl-Test-HasVersion.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Test-HasVersion-0.012-1.fc16.src.rpm Description: Do you wanna check that every one of your Perl modules in a distribution has a version number? You wanna make sure you don't forget the brand new modules you just added? Well, that's the module you have been looking for. Use it! Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2968073 *rt-0.10_01
Taking.
- = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the Perl specific items [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2973232 [x] Rpmlint output: perl-Test-HasVersion.noarch: W: no-manual-page-for-binary test_version 2 packages and 1 specfiles checked; 0 errors, 1 warnings. [x] Package is not relocatable. [x] Buildroot is correct None specified, default used. [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPL+ or Artistic [-] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. d9cb18aa27bbbb95b96a008248ebfb27 Test-HasVersion-0.012.tar.gz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [-] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [-] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [x] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: rawhide.x86_64 [x] Package should compile and build into binary rpms on all supported architectures. Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2973232 [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [x] %check is present and the tests pass All tests successful. Files=8, Tests=27, 1 wallclock secs ( 0.03 usr 0.02 sys + 0.91 cusr 0.12 csys = 1.08 CPU) Result: PASS APPROVED.
Thanks, as ever, for the review. But would you mind setting the fedora-review flag (not fedora-cvs) and hitting the little 'take' link next to 'Assigned To'.
/me signs
New Package SCM Request ======================= Package Name: perl-Test-HasVersion Short Description: Check Perl modules have version numbers Owners: iarnell Branches: f13 f14 f15 InitialCC: perl-sig
Git done (by process-git-requests).
perl-Test-HasVersion-0.012-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-Test-HasVersion-0.012-1.fc14
perl-Test-HasVersion-0.012-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/perl-Test-HasVersion-0.012-1.fc13
perl-Test-HasVersion-0.012-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Test-HasVersion-0.012-1.fc15
perl-Test-HasVersion-0.012-1.fc14 has been pushed to the Fedora 14 testing repository.
perl-Test-HasVersion-0.012-1.fc13 has been pushed to the Fedora 13 stable repository.
perl-Test-HasVersion-0.012-1.fc14 has been pushed to the Fedora 14 stable repository.
perl-Test-HasVersion-0.012-1.fc15 has been pushed to the Fedora 15 stable repository.
I'd like to request EPEL (4/5/6) branches of this package please. I'm happy to maintain them if Iain doesn't want to.
Package Change Request ====================== Package Name: perl-Test-HasVersion New Branches: el4 el5 el6 Owners: iarnell pghmcfc
No problem for me, Paul. Feel free to make and push the builds if you get a chance before I do.
perl-Test-HasVersion-0.012-3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Test-HasVersion-0.012-3.el5
perl-Test-HasVersion-0.012-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Test-HasVersion-0.012-2.el6
perl-Test-HasVersion-0.012-3.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/perl-Test-HasVersion-0.012-3.el4
Thanks Iain. Builds are done - can you add buildroot overrides for them with no expiry so the builds stay in the buildroot until the updates are pushed to stable? I can't do it myself as I believe buildroot overrides can only be submitted by people with commit access for the devel branch.
Yeah, bodhi ticket 620. Overrides are in place now.
perl-Test-HasVersion-0.012-3.el5 has been pushed to the Fedora EPEL 5 stable repository.
perl-Test-HasVersion-0.012-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
perl-Test-HasVersion-0.012-3.el4 has been pushed to the Fedora EPEL 4 stable repository.
Hi Iain, the EPEL builds are now in stable, so you can expire the buildroot overrides now. Thanks for your help.