Bug 693342 - Review Request: perl-MooseX-TrackDirty-Attributes - Track dirtied attributes
Summary: Review Request: perl-MooseX-TrackDirty-Attributes - Track dirtied attributes
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-04-04 11:30 UTC by Petr Pisar
Modified: 2011-04-06 07:15 UTC (History)
2 users (show)

Fixed In Version: perl-MooseX-TrackDirty-Attributes-0.02-1.fc16
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-04-06 07:15:40 UTC
Type: ---
Embargoed:
mmaslano: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Petr Pisar 2011-04-04 11:30:34 UTC
Spec URL: http://ppisar.fedorapeople.org/perl-MooseX-TrackDirty-Attributes/perl-MooseX-TrackDirty-Attributes.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-MooseX-TrackDirty-Attributes/perl-MooseX-TrackDirty-Attributes-0.02-1.fc14.src.rpm
Description:
MooseX::TrackDirty::Attributes does the necessary metaclass fiddling to
track if attributes are dirty; that is, if they're set to some value not
from a builder, default, or construction. An attribute can be returned to a
clean state by invoking its clearer.

Comment 1 Marcela Mašláňová 2011-04-05 12:28:09 UTC
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

APPROVED

Comment 2 Petr Pisar 2011-04-05 16:29:30 UTC
New Package SCM Request
=======================
Package Name: perl-MooseX-TrackDirty-Attributes 
Short Description: Track dirtied attributes
Owners: ppisar mmaslano psabata
Branches: 
InitialCC: perl-sig

Comment 3 Jason Tibbitts 2011-04-05 17:55:35 UTC
Git done (by process-git-requests).

Comment 4 Petr Pisar 2011-04-06 07:15:40 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.