Hide Forgot
Description of problem: Additional settings for sadc are stored in /etc/sysconfig/sysstat file (SADC_OPTIONS variable). This file should be sourced in sysstat init file (/etc/init.d/sysstat). Version-Release number of selected component (if applicable): sysstat-9.0.4-18.el6 Actual results: Value of ${SADC_OPTIONS} variable is set in sysstat init script Expected results: Value of ${SADC_OPTIONS} variable is taken from /etc/sysconfig/sysstat file.
Since RHEL 6.1 External Beta has begun, and this bug remains unresolved, it has been rejected as it is not proposed as exception or blocker. Red Hat invites you to ask your support representative to propose this request, if appropriate and relevant, in the next release of Red Hat Enterprise Linux.
After further investigation I found out other small issues which should be corrected: 1. ${SADC_OPTIONS} should be removed from sysstat init script and no sourcing of sysstat configuration file (/etc/sysconfig/sysstat) is needed. This is because sysstat init script runs sa1 script which pass options to sadc using ${SADC_OPTIONS} set in /etc/sysconfig/sysstat. 2. option "-S DISK" should be removed from sysstat cron file (/etc/cron.d/sysstat) (see bellow). cron starts sa1 script which is now able to handle options set in sysstat config file (/etc/sysconfig/sysstat) using ${SADC_OPTIONS}. Interval and count value "1 1" can be removed too, because these are implicit values from sa1 script. # cat /etc/cron.d/sysstat # Run system activity accounting tool every 10 minutes */10 * * * * root /usr/lib64/sa/sa1 -S DISK 1 1 # 0 * * * * root /usr/lib64/sa/sa1 -S DISK 600 6 & # Generate a daily summary of process accounting at 23:53 53 23 * * * root /usr/lib64/sa/sa2 -A 3. If we want to collect optional activities (like disk stats) in default installation, it's should be set in /etc/sysconfig/sysstat? 4. note similar to one bellow would be nice in sadc manual page: Important note: The activities (including optional ones) saved in an existing data file prevail over those selected with option -S. As a consequence, appending data to an existing data file will result in option -S being ignored.
Created attachment 499529 [details] proposed patch This patch adds SADC_OPT option to sysstat configuration file. Implicit value is set to "-S DISK" and the value if the configuration file is "-S DISK" to be compatible with the older el6 version - upstream implicit value is "".
Hi Ivana, a) do we need to set SADC_OPTIONS in sa1 script? SADC_OPTIONS value should be set in sysstat configuration file only, now. b) there is still one occurrence of "-S DISK" in cron file: # Run system activity accounting tool every @CRON_INTERVAL@ minutes */@CRON_INTERVAL@ * * * * @CRON_OWNER@ @SA_LIB_DIR@/sa1 -S DISK 1 1 <----- HERE # 0 * * * * @CRON_OWNER@ @SA_LIB_DIR@/sa1 @CRON_INTERVAL_SEC@ @CRON_COUNT@ & # Generate a daily summary of process accounting at 23:53 53 23 * * * @CRON_OWNER@ @SA_LIB_DIR@/sa2 -A
(In reply to comment #5) > Hi Ivana, > > a) do we need to set SADC_OPTIONS in sa1 script? SADC_OPTIONS value should be > set in sysstat configuration file only, now. If the configuration file will not be replaced (the user do edit it), then SADC_OPTION will not be set using it thus to preserve the present behaviour it is necessary in this case to set SADC_OPTION as -S DISK by default. > b) there is still one occurrence of "-S DISK" in cron file: > > # Run system activity accounting tool every @CRON_INTERVAL@ minutes > */@CRON_INTERVAL@ * * * * @CRON_OWNER@ @SA_LIB_DIR@/sa1 -S DISK 1 1 <----- > HERE > # 0 * * * * @CRON_OWNER@ @SA_LIB_DIR@/sa1 @CRON_INTERVAL_SEC@ @CRON_COUNT@ & > # Generate a daily summary of process accounting at 23:53 > 53 23 * * * @CRON_OWNER@ @SA_LIB_DIR@/sa2 -A Thanks, you are right.
Created attachment 499588 [details] fixed proposed patch
This request was evaluated by Red Hat Product Management for inclusion in the current release of Red Hat Enterprise Linux. Because the affected component is not scheduled to be updated in the current release, Red Hat is unfortunately unable to address this request at this time. Red Hat invites you to ask your support representative to propose this request, if appropriate and relevant, in the next release of Red Hat Enterprise Linux. If you would like it considered as an exception in the current release, please ask your support representative.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2012-0866.html