Bug 694026

we should follow https://www.redhat.com/archives/libvir-list/2011-February/msg00789.html to disabled sysv init script and enable the upstart one.

Changing the status to assigned.  Investigated the changes required. 
Following are the changes required for implementation. 
1. Spec file - Finalise the Location of the vdsmd upstart script ?  Some information is required from the vdsm developers -  This is my understanding that the upstart script should be part of vdsm-reg but not sure at the moment. 
2.  Following are the expected contents of the upstart script.  
a) Run level -  Based upon the existing chkconfig output, the run level of the upstart script should be [2345] 

[root@rhevh-4 ~]# chkconfig --list vdsmd
vdsmd          	0:off	1:off	2:on	3:on	4:on	5:on	6:off
[root@rhevh-4 ~]# 
[root@rhevh-4 ~]# chkconfig --list vdsm-reg
vdsm-reg       	0:off	1:off	2:on	3:on	4:on	5:on	6:off

b) Clean up the pid files and cache ( if applicable ) 
c) start the vdsmd daemon process with args - vdsmd start job
d) Apply the same concept a), b) and stop the vdsmd process  - vdsmd stop job

Some more investigation required for vdsm-reg package and process.

The vdsmd file is currently been updated with the changes for 678039.  

Following are the code snippet that needs a change. 
a) 

start_needed_srv() {
    local srv
    local ret_val

    for srv in $NEEDED_SERVICES
    do
        if ! /sbin/service $srv status > /dev/null 2>&1;
        then
            echo "Starting $srv..."
            /sbin/service $srv start
            $ret_val=$?
            if [ $ret_val -ne 0 ]
            then
                 # What if any of the dependent service fails to start. 
                 # Send the return value based on that. 
                log_failure_msg "$prog: Dependent $srv failed to start "
                return $ret_val
            fi
        fi
    done

where $srv is libvirtd 

b) 
    /usr/sbin/setsebool virt_use_nfs on

    # no return status check is required, libvirtd is started again by start_needed_srv

    service libvirtd condrestart

comment from Dan,  the solution should also have the following. 

$Subject - as part of Libvirtd's upstart job- vdsm should initctl Libvirtd

When vdsmd decides that it should configure libvirt, it should also
handle $Subject. Special handling should be done on vdsm removal, to
undo that.

http://gerrit.usersys.redhat.com/675

Verified in vdsm-86

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Vdsm needs to make sure libvirtd is kept alive, even after a libvirtd crash. Therefore, Vdsm configures libvirtd to run as an Upstart job, instead of a SysV service.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2011-1782.html